[flac-dev] [PATCH] configure: only use -mstackrealign on mingw32/os2
And only for i686. --- configure.ac | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..9751745 100644 --- a/configure.ac +++ b/configure.ac @@ -399,11 +399,17 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test x$asm_optimisation$sse_os = xyesyes ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi fi +case $host_os in + mingw32|os2) + if test $host_cpu = i686; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi +esac + XIPH_ADD_CFLAGS([-Wextra]) if test x$enable_werror = xyes ; then -- 2.1.0 ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH] configure: only use -mstackrealign on mingw32/os2
On 04/10/15 10:05 PM, Tristan Matthews wrote: And only for i686. LGTM, thanks Dave ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] [PATCH] configure: only use -mstackrealign on mingw32/os2
And only for i686. --- configure.ac | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..8dd5b0d 100644 --- a/configure.ac +++ b/configure.ac @@ -399,11 +399,16 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test x$asm_optimisation$sse_os = xyesyes ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi - fi +case $host_os in + mingw32|os2) + if test $host_cpu = i686; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi +esac + XIPH_ADD_CFLAGS([-Wextra]) if test x$enable_werror = xyes ; then -- 2.1.0 ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
--- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..e7d68c3 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test x$asm_optimisation$sse_os = xyesyes ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi + fi +if test $host_os = mingw32 ; then + XIPH_ADD_CFLAGS([-mstackrealign]) fi XIPH_ADD_CFLAGS([-Wextra]) -- 2.1.0 ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
Tristan Matthews wrote: --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..e7d68c3 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test x$asm_optimisation$sse_os = xyesyes ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi + fi +if test $host_os = mingw32 ; then + XIPH_ADD_CFLAGS([-mstackrealign]) fi XIPH_ADD_CFLAGS([-Wextra]) Everyone happy with this patch? Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
On 04/10/15 02:10 pm, Erik de Castro Lopo wrote: Tristan Matthews wrote: --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..e7d68c3 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test x$asm_optimisation$sse_os = xyesyes ; then XIPH_ADD_CFLAGS([-msse2]) -XIPH_ADD_CFLAGS([-mstackrealign]) fi +fi +if test $host_os = mingw32 ; then +XIPH_ADD_CFLAGS([-mstackrealign]) fi XIPH_ADD_CFLAGS([-Wextra]) Everyone happy with this patch? Should it be a case statement so other OSes can be added or just use || ? OS/2 should also have the -mstackrealign option added as well. Dave ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
On 4/11/2015 05:10, Erik de Castro Lopo wrote: Tristan Matthews wrote: --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..e7d68c3 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test x$asm_optimisation$sse_os = xyesyes ; then XIPH_ADD_CFLAGS([-msse2]) -XIPH_ADD_CFLAGS([-mstackrealign]) fi +fi +if test $host_os = mingw32 ; then +XIPH_ADD_CFLAGS([-mstackrealign]) fi XIPH_ADD_CFLAGS([-Wextra]) Everyone happy with this patch? Erik This should only apply to i686 host 32bit mingw. signature.asc Description: OpenPGP digital signature ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
