Re: [flac-dev] Prelease now available
On 07/19/19 02:35 PM, Erik de Castro Lopo wrote: Erik de Castro Lopo wrote: Hopefull the final release candidate: http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc I am assuming everyone was happy with that and that I can release a new version. Compiles without warnings here and passes all the tests I tried and am fine with a release. Make check does seem to be getting less portable, with dash, (pdk)sh and (mk)sh here, FLAC__TEST_LEVEL=1 FLAC__TEST_WITH_VALGRIND=no ECHO_N="-n" ECHO_C="" ./test_libFLAC.sh common.sh: 20: common.sh: Illegal number: make[1]: *** [check] Error 2 Also notice that you're using COMSPEC, a DOS thing that is set in all Dosish operating systems including here on OS/2, to check for Windows. Not too important for a minor OS and it would eventually die here due to a crappy dd port. Dave ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
On Fri, 19 Jul 2019 at 23:35, Erik de Castro Lopo wrote: > > Erik de Castro Lopo wrote: > > > Hopefull the final release candidate: > > > > http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz > > http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc Builds fine on FreeBSD with clang / LLVM 8.0.0. (I tested the build using Makefile.lite). Riggs ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Hi Erik, Am 19.07.2019 um 23:35 schrieb Erik de Castro Lopo : > Erik de Castro Lopo wrote: >> Hopefull the final release candidate: >> >>http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz >>http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc > > I am assuming everyone was happy with that and that I can release > a new version. Fine with me, builds cleanly on Solaris now. Best regards — Dago -- "You don't become great by trying to be great, you become great by wanting to do something, and then doing it so hard that you become great in the process." - xkcd #896 ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Looks good. Please do. On 20.7.2019 0.35, Erik de Castro Lopo wrote: Erik de Castro Lopo wrote: Hopefull the final release candidate: http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc I am assuming everyone was happy with that and that I can release a new version. Cheers, Erik ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Erik de Castro Lopo wrote: > Hopefull the final release candidate: > > http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz > http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc I am assuming everyone was happy with that and that I can release a new version. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Erik de Castro Lopo wrote: Hopefull the final release candidate: http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc3.tar.xz.asc Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Dagobert Michelsen wrote: > I did use autotools, the problem is that -lrt is missing for the respective > binary > during linkage. I created > https://github.com/xiph/flac/pull/112 > to take care of this. I suggest to continue discussion on this PR on Github. Merged, thanks. I will roll one more pre-release, probably today. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Hi Erik, Am 16.07.2019 um 11:47 schrieb Erik de Castro Lopo : > Erik de Castro Lopo wrote: >> Which build system are your using? Any chance of a patch? > > I just checked, and the autotool build system should just do the > right thing on Solaris. Maybe you are using the CMake build > system and should try the other one. I did use autotools, the problem is that -lrt is missing for the respective binary during linkage. I created https://github.com/xiph/flac/pull/112 to take care of this. I suggest to continue discussion on this PR on Github. Best regards — Dago -- "You don't become great by trying to be great, you become great by wanting to do something, and then doing it so hard that you become great in the process." - xkcd #896 ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Erik de Castro Lopo wrote: > Which build system are your using? Any chance of a patch? I just checked, and the autotool build system should just do the right thing on Solaris. Maybe you are using the CMake build system and should try the other one. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Dagobert Michelsen wrote: > I have an undefined symbol on Solaris 10 Sparc with GCC 5.5: > > > Undefined first referenced > > symbol in file > > clock_gettime util.o > > At the moment librt is only added for Linux whereas it would be better to > check > on all operating systems if the function is in librt. Which build system are your using? Any chance of a patch? Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Hi Erik, Am 15.07.2019 um 02:32 schrieb Erik de Castro Lopo : > Erik de Castro Lopo wrote: > >> I have a new pre-reelase (with a GPG signature) up here: > > New version: > >http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz >http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz.asc I have an undefined symbol on Solaris 10 Sparc with GCC 5.5: > Undefined first referenced > symbol in file > clock_gettime util.o At the moment librt is only added for Linux whereas it would be better to check on all operating systems if the function is in librt. Best regards — Dago -- "You don't become great by trying to be great, you become great by wanting to do something, and then doing it so hard that you become great in the process." - xkcd #896 ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Version info is now correct. I noticed there have been some file changes and Visual Studio 2005 project files hadn't been updated. Here's a patch for git version to fix compilation. On 15.7.2019 3.32, Erik de Castro Lopo wrote: Erik de Castro Lopo wrote: I have a new pre-reelase (with a GPG signature) up here: New version: http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz.asc Erik diff --git a/src/libFLAC/libFLAC_dynamic.vcproj b/src/libFLAC/libFLAC_dynamic.vcproj index 3815c79b..ecddc1e7 100644 --- a/src/libFLAC/libFLAC_dynamic.vcproj +++ b/src/libFLAC/libFLAC_dynamic.vcproj @@ -345,6 +345,10 @@ RelativePath=".\lpc_intrin_sse41.c" > + + @@ -397,6 +401,10 @@ RelativePath=".\stream_encoder_intrin_ssse3.c" > + + diff --git a/src/libFLAC/libFLAC_static.vcproj b/src/libFLAC/libFLAC_static.vcproj index 6b6edf0c..9b6f37d1 100644 --- a/src/libFLAC/libFLAC_static.vcproj +++ b/src/libFLAC/libFLAC_static.vcproj @@ -386,6 +386,10 @@ RelativePath=".\lpc_intrin_sse41.c" > + + @@ -438,6 +442,10 @@ RelativePath=".\stream_encoder_intrin_ssse3.c" > + + ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Erik de Castro Lopo wrote: > I have a new pre-reelase (with a GPG signature) up here: New version: http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc2.tar.xz.asc Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Janne Hyvärinen wrote: > Replace 'PACKAGE_VERSION=\1.3.2\' with > 'PACKAGE_VERSION=\1.3.3rc1\' in > src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And > replace 'PACKAGE_VERSION="1.3.2"' with 'PACKAGE_VERSION="1.3.3rc1"' in > src/libFLAC/libFLAC_dynamic.vcxproj and libFLAC_static.vcxproj. Never mind, I responded before the coffee had kicked in. I can do that. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Erik de Castro Lopo wrote: > Janne Hyvärinen wrote: > > > Minor changes needed for Visual Studio as the version is defined in the > > project files. > > > > Replace 'PACKAGE_VERSION=\1.3.2\' with > > 'PACKAGE_VERSION=\1.3.3rc1\' in > > src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And > > replace 'PACKAGE_VERSION="1.3.2"' with 'PACKAGE_VERSION="1.3.3rc1"' in > > src/libFLAC/libFLAC_dynamic.vcxproj and libFLAC_static.vcxproj. > > I have not way of verifying if any hand edit I do is correct. > > For that reason I reall do need a proper diff. Sorry, The diff can be against current git master. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Janne Hyvärinen wrote: > Minor changes needed for Visual Studio as the version is defined in the > project files. > > Replace 'PACKAGE_VERSION=\1.3.2\' with > 'PACKAGE_VERSION=\1.3.3rc1\' in > src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And > replace 'PACKAGE_VERSION="1.3.2"' with 'PACKAGE_VERSION="1.3.3rc1"' in > src/libFLAC/libFLAC_dynamic.vcxproj and libFLAC_static.vcxproj. I have not way of verifying if any hand edit I do is correct. For that reason I reall do need a proper diff. Sorry, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Prelease now available
Minor changes needed for Visual Studio as the version is defined in the project files. Replace 'PACKAGE_VERSION=\1.3.2\' with 'PACKAGE_VERSION=\1.3.3rc1\' in src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And replace 'PACKAGE_VERSION="1.3.2"' with 'PACKAGE_VERSION="1.3.3rc1"' in src/libFLAC/libFLAC_dynamic.vcxproj and libFLAC_static.vcxproj. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] Prelease now available
Hi all, I have a new pre-reelase (with a GPG signature) up here: http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz.asc This code is built from commit 10a28d482a8e48b806f61ab766992b2add98ec43 plus another commmit to change the version numbers which I will not be pushing to the public repo before the final release. Note that audio files encoded with a pre-releases will be 3 bytes longer than the the file encoded with the 1.3.3 final release because the version string is "1.3.3rc1" instead of "1.3.3". I hope to make a full release within a week. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
