[flac-dev] flac 1.3.0pre2 pre-release
Hi all, Second and hopefully final pre-release is here: http://downloads.xiph.org/releases/flac/beta/ I have personally tested this code on: x86-linux x86_64-linux powerpc-linux armhf-linux i386-freebsd9.1 i386-openbsd5.2 I also cross-compiled from Linux to 32 bit Windows and the compile ran to completion (the test suite requires a bunch of hacking before it can run under Wine). Ben Alison has also did the hard work required to make it compile with MSVC. Still need to work on the changelog. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Erik, Sorry for the confusion. There is one more patch. I had it in the first attempt I made but somehow these changes weren't in the redone patch. As mentioned before, this removes some of the 'inline' from the bitreader and bitwriter functions that were used in another translation unit. I'm surprised that this code works on other platform. It must be a bug in GCC, or maybe deliberately non-standard behavior. See 6.7.4 of the C99 spec for details. -Ben Allison > Hi all, > > Second and hopefully final pre-release is here: > > http://downloads.xiph.org/releases/flac/beta/ > > I have personally tested this code on: > > x86-linux > x86_64-linux > powerpc-linux > armhf-linux > i386-freebsd9.1 > i386-openbsd5.2 > > I also cross-compiled from Linux to 32 bit Windows and the compile ran to > completion (the test suite requires a bunch of hacking before it can run > under Wine). > > Ben Alison has also did the hard work required to make it compile with > MSVC. > > Still need to work on the changelog. > > Cheers, > Erik > > -- > -- > Erik de Castro Lopo > http://www.mega-nerd.com/ > ___ > flac-dev mailing list > flac-dev@xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev > FLAC-1-3-0-MSVC-round-three.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09.03.2013 15:37, Erik de Castro Lopo wrote: > Hi all, > > Second and hopefully final pre-release is here: > > http://downloads.xiph.org/releases/flac/beta/ > src/libFLAC/metadata_iterators.c:442:4: warning: implicit declaration of function 'ftello' [-Wimplicit-function-declaration] Same with ftello, it's all over the source code. Curiously, config.h contains: /* Define to 1 if fseeko (and presumably ftello) exists and is declared. */ /* #undef HAVE_FSEEKO */ for me, but FLAC doesn't seem to care... Here's a patch i've used. Compiles (mingw.org i386 gcc 4.7.2 + MSYS), passes the testsuite. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRPCQTAAoJEOs4Jb6SI2Cwu/gH/RgqFvNay07Fywz0rUcGqzRm c2jX1TRQ4dYg94x8dgn2VxGG/um1py1pko36zcxH22lx3hnz3AqttDrRBEy57Wxh dwXQyxbhgpJX1fG1mkj78n+Klh+G4bT5ALl/mvvBPgp8DI+KHwGKKn6LoCwRLhkS A2MbgAUBkMcLpctG9Q1V+mkNpWOq0IJM5LDbtGlJ+VQsVUt7IpxC+0ORT5bqot+M p8DtYkQxXyL0AUKrW3LkpA+MDPIK0iaH0fmhtZJCjcAjWH1Xf/q98mYa+FtpnCbi cZeeMTcoWtogLWkJEmCa0BnkCN4Gcyvoq1u2Zb1itBjszhK84V9rJD1+w22l49M= =9CjS -END PGP SIGNATURE- --- flac-1.3.0pre2/include/share/compat.h.orig 2013-03-08 13:22:15 +0400 +++ flac-1.3.0pre2/include/share/compat.h 2013-03-10 09:30:43 +0400 @@ -55,6 +55,12 @@ #ifndef ftello #define ftello ftell #endif +#else +/* MinGW */ +#if !defined(HAVE_FSEEKO) +# define fseeko fseeko64 +# define ftello ftello64 +#endif #endif #endif ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
LRN wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09.03.2013 15:37, Erik de Castro Lopo wrote: > > Hi all, > > > > Second and hopefully final pre-release is here: > > > > http://downloads.xiph.org/releases/flac/beta/ > > > src/libFLAC/metadata_iterators.c:442:4: warning: implicit declaration > of function 'ftello' [-Wimplicit-function-declaration] > > Same with ftello, it's all over the source code. Patch applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
On Sat, Mar 09, 2013 at 12:28:28PM -0500, Ben Allison wrote: > Erik, > > Sorry for the confusion. There is one more patch. I had it in the first > attempt I made but somehow these changes weren't in the redone patch. > > As mentioned before, this removes some of the 'inline' from the bitreader > and bitwriter functions that were used in another translation unit. I'm > surprised that this code works on other platform. It must be a bug in > GCC, or maybe deliberately non-standard behavior. See 6.7.4 of the C99 > spec for details. I don't see the problem. What exactly is the compiler error? It seems the declarations in the header files don't have inline and they are included with the definitions, so they shouldn't be inline definitions and should be callable from other units. -- Miroslav Lichvar ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > Here's a patch that fixes the creation of larger than 2 GB FLAC files. > Without this patch both GCC and MSVC compiles of FLAC will fail on > Windows when they have written 2 GB file while encoding from stdin. And > after 4GB when encoding from WAV file. Ok. > It includes Ben Allison's MSVC changes and JonY's MinGW changes with > some tweaks to make both environments happy. Please don't do that. Adding bits of other patches makes it more difficult to evaluate and review this patch which is already difficult to review because of its size. > And I had to do some more > inline changing to get my MSVC 2012 to compile the sources. I would still like to have this problem explained to me. > There may still be some bug in FLAC's large input wav handling as the > test FLAC I created by encoding over 22 hours of 24 bit data makes > foobar2000 report one sample mismatch in reported and decoded length. Or > it's a rounding bug in foobar2000. Is it not possible to test this without involving foobar2000? Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Ben Allison wrote: > As mentioned before, this removes some of the 'inline' from the bitreader > and bitwriter functions that were used in another translation unit. I'm > surprised that this code works on other platform. It must be a bug in > GCC, or maybe deliberately non-standard behavior. See 6.7.4 of the C99 > spec for details. I've read section 6.7.4 from here: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1124.pdf My reading of that section suggests that the usage in FLAC is valid and correct. As for the addition of safe_malloc_mul_2op_ to file src/share/utf8/utf8.c, that simply should not be necessary. I suggest this is an error in the Visual Studio project files. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
On 11.3.2013 13:05, Erik de Castro Lopo wrote: >> It includes Ben Allison's MSVC changes and JonY's MinGW changes with >> some tweaks to make both environments happy. > Please don't do that. Adding bits of other patches makes it more > difficult to evaluate and review this patch which is already difficult > to review because of its size. Sorry, I'm new at this. I don't know how things should be handled. >> And I had to do some more >> inline changing to get my MSVC 2012 to compile the sources. > I would still like to have this problem explained to me. With the sources as they are compiling produces these errors (this on MSVC 2012 SP1 Express): Error1error LNK2001: unresolved external symbol _FLAC__bitreader_bits_left_for_byte_alignment G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) flac Error2error LNK2001: unresolved external symbol _FLAC__bitreader_is_consumed_byte_aligned G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) flac Error3error LNK2001: unresolved external symbol _FLAC__bitreader_read_uint32_little_endian G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) flac Error4error LNK2001: unresolved external symbol _FLAC__bitreader_get_input_bits_unconsumed G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) flac Error5error LNK2001: unresolved external symbol _FLAC__bitwriter_write_raw_uint64 G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) flac Error6error LNK2001: unresolved external symbol _FLAC__bitwriter_write_raw_int32 G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) flac Error7error LNK2001: unresolved external symbol _FLAC__bitwriter_write_byte_block G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) flac Error8error LNK2001: unresolved external symbol _FLAC__bitwriter_write_raw_uint32_little_endian G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) flac Error9error LNK2001: unresolved external symbol _safe_malloc_mul_2op_ G:\Programming\flac-1.3.0pre2\src\flac\utf8_static.lib(utf8.obj) flac Error10error LNK1120: 9 unresolved externals G:\Programming\flac-1.3.0pre2\objs\release\bin\flac.exeflac Error 9 is related to the location of _safe_malloc_mul_2op_. It's easiest to fix by having the code in utf8.c. >> There may still be some bug in FLAC's large input wav handling as the >> test FLAC I created by encoding over 22 hours of 24 bit data makes >> foobar2000 report one sample mismatch in reported and decoded length. Or >> it's a rounding bug in foobar2000. > Is it not possible to test this without involving foobar2000? > It is and I actually verified it yesterday. I used the command-line flac to decode the file into RAW format and calculated sample count by dividing it with bytes per sample and channel count. It matched the reported sample count exactly, so it's not a bug in FLAC. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
> Ben Allison wrote:
>
>> As mentioned before, this removes some of the 'inline' from the
>> bitreader
>> and bitwriter functions that were used in another translation unit.
>> I'm
>> surprised that this code works on other platform. It must be a bug in
>> GCC, or maybe deliberately non-standard behavior. See 6.7.4 of the C99
>> spec for details.
>
> I've read section 6.7.4 from here:
>
> http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1124.pdf
>
> My reading of that section suggests that the usage in FLAC is valid and
> correct.
Take, for example, the function FLAC__bitreader_is_consumed_byte_aligned.
It is prototyped in bitreader.h It is used in stream_decoder.c, so it
must be defined and made available to the linker ("external definition").
However, the only definition in bitreader.c has been declared inline.
>From 6.7.4.6
An inline definition does not provide an external definition for the
function, and does not forbid an external definition in another
translation unit. An inline definition provides an alternative to an
external definition, which a translator may use to implement any call to
the function in the same translation unit.
> As for the addition of safe_malloc_mul_2op_ to file src/share/utf8/utf8.c,
> that simply should not be necessary. I suggest this is an error in the
> Visual Studio project files.
Correct. Rummaging through the code more, it appears that the
'grabbag_static' project isn't compiling grabbac/alloc.c, which is why
this is undefined. When I get to the office I will fix up the project
files.
-Ben Allison
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote:
> Take, for example, the function FLAC__bitreader_is_consumed_byte_aligned.
> It is prototyped in bitreader.h It is used in stream_decoder.c, so it
> must be defined and made available to the linker ("external definition").
> However, the only definition in bitreader.c has been declared inline.
>
> From 6.7.4.6
> An inline definition does not provide an external definition for the
> function, and does not forbid an external definition in another
> translation unit. An inline definition provides an alternative to an
> external definition, which a translator may use to implement any call to
> the function in the same translation unit.
My understanding is that it's not an "inline definition" as there is
a non-inline declaration in bitreader.h.
If there are no better solutions to fix the problem, I'd suggest to
#define inline to nothing for MSVC.
--
Miroslav Lichvar
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
> On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote: >> From 6.7.4.6 >> An inline definition does not provide an external definition for the >> function, and does not forbid an external definition in another >> translation unit. An inline definition provides an alternative to an >> external definition, which a translator may use to implement any call to >> the function in the same translation unit. > > My understanding is that it's not an "inline definition" as there is > a non-inline declaration in bitreader.h. > > If there are no better solutions to fix the problem, I'd suggest to > #define inline to nothing for MSVC. Looking at the spec again, and using the information in Example 7, I found that if we put the following AFTER the inline definition, it becomes available to other translation units. extern unsigned FLAC__bitreader_get_input_bits_unconsumed(const FLAC__BitReader *br); This appears to be different behavior than other uses of the keyword 'extern' (just like the multiple uses of the keyword 'static'). 6.7.4.7 of the C99 spec suggests that a statement such as the above turns an inline definition into an external definition. Add 'extern' to the .h file is unsafe, as any file that included bitreader.h and chose to define an alternate inline definition (as allowed by the spec) would also end up defining an external definition and would result in duplicate symbols. I will redo the patch with these 'extern' function definitions defined inside the corresponding .c files. Hope that helps. -Ben Allison ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
On Mon, Mar 11, 2013 at 08:51:43AM -0400, Ben Allison wrote: > >> From 6.7.4.6 > >> An inline definition does not provide an external definition for the > >> function, and does not forbid an external definition in another > >> translation unit. An inline definition provides an alternative to an > >> external definition, which a translator may use to implement any call to > >> the function in the same translation unit. > > > > My understanding is that it's not an "inline definition" as there is > > a non-inline declaration in bitreader.h. > > I don't see how that can be the case. The spec explicitly states that > inline definitions do not provide an external definition. > But it's not an inline definition according to 6.7.4.6 (the sentence before the part you have quoted): If all of the file scope declarations for a function in a translation unit include the inline function specifier without extern, then the definition in that translation unit is an inline definition. -- Miroslav Lichvar ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > With the sources as they are compiling produces these errors (this on > MSVC 2012 SP1 Express): > > Error1error LNK2001: unresolved external symbol > _FLAC__bitreader_bits_left_for_byte_alignment > G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) Ben Alison is working on tthis. Lets allow that work to come to a conclusion. > Error9error LNK2001: unresolved external symbol > _safe_malloc_mul_2op_ > G:\Programming\flac-1.3.0pre2\src\flac\utf8_static.lib(utf8.obj) flac > Error10error LNK1120: 9 unresolved externals > G:\Programming\flac-1.3.0pre2\objs\release\bin\flac.exeflac > > Error 9 is related to the location of _safe_malloc_mul_2op_. It's > easiest to fix by having the code in utf8.c. But that function is defined in src/share/grabbag/alloc.c and should be getting linked into flac.exe. It doesn't need to be redefined in utf8.c. Specifically, I think alloc.c should be added as one of the build files in src/share/grabbag/grabbag_static.vcproj src/share/grabbag/grabbag_dynamic.vcproj Please try this and if that fixes it, please send a patch containing only that change. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
>> On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote: > I will redo the patch with these 'extern' function definitions defined > inside the corresponding .c files. As promised, here is the patch to declare the inline functions as external definitions. -Ben Allison FLAC-1-3-0-inline-extern.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Hi, On 03/09/13 03:37 am, Erik de Castro Lopo wrote: > Hi all, > > Second and hopefully final pre-release is here: > > http://downloads.xiph.org/releases/flac/beta/ OS/2 now needs this patch. --- configure.ac.orig 2013-03-11 21:52:54.0 -0700 +++ configure.ac2013-03-11 21:53:30.0 -0700 @@ -378,7 +378,7 @@ XIPH_ADD_CFLAGS([-D_FORTIFY_SOURCE=2]) case "$host_os" in - mingw32msvc | mingw32 | freebsd* ) + mingw32msvc | mingw32 | freebsd* | os2*) # Stack protector not working on these platforms 2013/03/09. ;; *) Dave ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Ben Allison wrote: > >> On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote: > > I will redo the patch with these 'extern' function definitions defined > > inside the corresponding .c files. > > As promised, here is the patch to declare the inline functions as external > definitions. Thanks Ben, this is a good compromise. I improved the comments slightly as well. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Dave Yeo wrote: > OS/2 now needs this patch. > --- configure.ac.orig 2013-03-11 21:52:54.0 -0700 > +++ configure.ac2013-03-11 21:53:30.0 -0700 > @@ -378,7 +378,7 @@ > XIPH_ADD_CFLAGS([-D_FORTIFY_SOURCE=2]) > > case "$host_os" in > - mingw32msvc | mingw32 | freebsd* ) > + mingw32msvc | mingw32 | freebsd* | os2*) > # Stack protector not working on these platforms 2013/03/09. > ;; > *) Thats good feeback Dave, but I'm actually going to fix this by detecting at configure time if the stack protector stuff works correctly. Cheersm Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
On 11.3.2013 21:21, Erik de Castro Lopo wrote:
Error9error LNK2001: unresolved external symbol
_safe_malloc_mul_2op_
G:\Programming\flac-1.3.0pre2\src\flac\utf8_static.lib(utf8.obj) flac
Error10error LNK1120: 9 unresolved externals
G:\Programming\flac-1.3.0pre2\objs\release\bin\flac.exeflac
Error 9 is related to the location of _safe_malloc_mul_2op_. It's
easiest to fix by having the code in utf8.c.
But that function is defined in src/share/grabbag/alloc.c and should
be getting linked into flac.exe. It doesn't need to be redefined in
utf8.c. Specifically, I think alloc.c should be added as one of the
build files in
src/share/grabbag/grabbag_static.vcproj
src/share/grabbag/grabbag_dynamic.vcproj
Please try this and if that fixes it, please send a patch containing
only that change.
I thought Ben Allison would have made a patch. Here's a patch for this.
I suppose we were all blind at first for the cause.
diff -rupN a/src/share/grabbag/grabbag_static.vcproj
b/src/share/grabbag/grabbag_static.vcproj
--- a/src/share/grabbag/grabbag_static.vcproj Wed Jan 2 13:49:55 2013
+++ b/src/share/grabbag/grabbag_static.vcproj Tue Mar 12 09:46:01 2013
@@ -163,6 +163,10 @@
UniqueIdentifier="{4FC737F1-C7A5-4376-A066-2A32D752A2FF}"
>
+
+
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > I thought Ben Allison would have made a patch. Here's a patch for this. > I suppose we were all blind at first for the cause. Applied thanks. I'd now like to look at the 2/4Gig off_t issue in your original support_2gb_output patch. Unlike your original patch, you will have to avoid touchng anything in the directories: include/FLAC include/FLAC++ as these are the public API headers and we don't want to change the API in this release. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > I re-did the patch with these limitations. I also noticed I had left > stat() and fstat() functions unfixed previously. And encoder was limited > to 4G in many places when printing status info. Unfortunately, this patch did not apply cleanly. There were two problems; one in src/flac/main.c that was easy and obvious to fix, the other in include/share/compat.h. Can you please send your version of that file? Thanks, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > The patch was made from the published pre2 version. It missed the MinGW > changes that were applied to git version. And a couple of others. Usually better to go from the code that's actually in git. Anyway I have the code that you intended to sumbit. I will do a thorough review and test before committing. Thanks! Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > The patch was made from the published pre2 version. It missed the MinGW > changes that were applied to git version. Patch applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
On 14.3.2013 9:37, Erik de Castro Lopo wrote: Janne Hyvärinen wrote: The patch was made from the published pre2 version. It missed the MinGW changes that were applied to git version. Patch applied. Thanks. Erik Unfortunately with this commit the LRN's patch from commit b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch to bring its fixes back. Sorry I used old sources for the large patch. --- include/share/compat.h.orig 2013-03-14 19:05:33 +0200 +++ include/share/compat.h 2013-03-14 19:58:43 +0200 @@ -52,6 +52,11 @@ #if !defined __MINGW32__ #define fseeko _fseeki64 #define ftello _ftelli64 +#else /* MinGW */ +#if !defined(HAVE_FSEEKO) +#define fseeko fseeko64 +#define ftello ftello64 +#endif #endif #else #define FLAC__off_t off_t ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Janne Hyvärinen wrote: > > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > Janne Hyvärinen wrote: > > > >> The patch was made from the published pre2 version. It missed the MinGW > >> changes that were applied to git version. > > Patch applied. Thanks. > > > > Erik > > Unfortunately with this commit the LRN's patch from commit > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch > to bring its fixes back. Sorry I used old sources for the large patch. Applied, thanks! Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
I've been trying to get the test suite cleaned up and even with the original "untouched" test suite via flac 1.3.0pre2, I'm getting a test suite failure. *flac 1.3.0pre2* * * *configure options:* ./configure --prefix=/usr --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --enable-thorough-tests --enable-exhaustive-tests --disable-valgrind-testing --disable-static --disable-dependency-tracking --disable-debug --enable-sse --disable-3dnow --disable-altivec --disable-doxygen-docs --disable-xmms-plugin --enable-cpplibs --enable-ogg *make fullcheck:* This test fails with 'test_flac.sh': Testing --keep-foreign-metadata... round-trip test (wacky1.wav) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky2.wav) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky1.w64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky2.w64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky1.rf64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK round-trip test (wacky2.rf64) encode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test the output file before deleting the original. compare... OK Testing the metadata-handling properties of flac-to-flac encoding... case00a... Files case00a-expect.meta and out.meta differ ERROR: metadata does not match expected case00a-expect.meta make: *** [fullcheck] Error 1 Anyone else hitting this or is just my system? On Thu, Mar 14, 2013 at 3:37 PM, Erik de Castro Lopo wrote: > Janne Hyvärinen wrote: > > > > > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > > Janne Hyvärinen wrote: > > > > > >> The patch was made from the published pre2 version. It missed the > MinGW > > >> changes that were applied to git version. > > > Patch applied. Thanks. > > > > > > Erik > > > > Unfortunately with this commit the LRN's patch from commit > > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch > > to bring its fixes back. Sorry I used old sources for the large patch. > > Applied, thanks! > > Erik > -- > -- > Erik de Castro Lopo > http://www.mega-nerd.com/ > ___ > flac-dev mailing list > flac-dev@xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev > ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
I'd also like to note that this is happening for me with current HEAD (619b43df36b725e11e12db768d558b1930a583b6). On Mon, Mar 18, 2013 at 11:25 PM, Jaren Stangret wrote: > I've been trying to get the test suite cleaned up and even with the > original "untouched" test suite via flac 1.3.0pre2, I'm getting a test > suite failure. > > *flac 1.3.0pre2* > * > * > *configure options:* > ./configure --prefix=/usr --build=i686-pc-linux-gnu > --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info > --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib > --disable-dependency-tracking --enable-thorough-tests > --enable-exhaustive-tests --disable-valgrind-testing --disable-static > --disable-dependency-tracking --disable-debug --enable-sse --disable-3dnow > --disable-altivec --disable-doxygen-docs --disable-xmms-plugin > --enable-cpplibs --enable-ogg > > *make fullcheck:* > This test fails with 'test_flac.sh': > > Testing --keep-foreign-metadata... > round-trip test (wacky1.wav) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky2.wav) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky1.w64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky2.w64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky1.rf64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > round-trip test (wacky2.rf64) encode... NOTE: --keep-foreign-metadata is a > new feature; make sure to test the output file before deleting the original. > decode... NOTE: --keep-foreign-metadata is a new feature; make sure to > test the output file before deleting the original. > compare... OK > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 > > Anyone else hitting this or is just my system? > > > > On Thu, Mar 14, 2013 at 3:37 PM, Erik de Castro Lopo > wrote: > >> Janne Hyvärinen wrote: >> >> > >> > On 14.3.2013 9:37, Erik de Castro Lopo wrote: >> > > Janne Hyvärinen wrote: >> > > >> > >> The patch was made from the published pre2 version. It missed the >> MinGW >> > >> changes that were applied to git version. >> > > Patch applied. Thanks. >> > > >> > > Erik >> > >> > Unfortunately with this commit the LRN's patch from commit >> > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch >> > to bring its fixes back. Sorry I used old sources for the large patch. >> >> Applied, thanks! >> >> Erik >> -- >> -- >> Erik de Castro Lopo >> http://www.mega-nerd.com/ >> ___ >> flac-dev mailing list >> flac-dev@xiph.org >> http://lists.xiph.org/mailman/listinfo/flac-dev >> > > ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Jaren Stangret wrote: > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 > > Anyone else hitting this or is just my system? Yes, I'm getting this too. On the list of things to fix before the release :-). Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
Jaren Stangret wrote: > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 Last night I did a git bisect on this issue and this error arose when I changed the version from "1.2.1" to "1.3.0pre1". Obvioulsy the test shouldn't have failed just because the version string changed :-). Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
> Jaren Stangret wrote: > >> Testing the metadata-handling properties of flac-to-flac encoding... >> case00a... Files case00a-expect.meta and out.meta differ >> ERROR: metadata does not match expected case00a-expect.meta >> make: *** [fullcheck] Error 1 > > Last night I did a git bisect on this issue and this error arose > when I changed the version from "1.2.1" to "1.3.0pre1". Obvioulsy > the test shouldn't have failed just because the version string > changed :-). The metadata block contains the vendor string (aka libFLAC version number). I bet case00a-expect.meta still has 1.2.1. -Ben ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] flac 1.3.0pre2 pre-release
>> Jaren Stangret wrote: >> >>> Testing the metadata-handling properties of flac-to-flac encoding... >>> case00a... Files case00a-expect.meta and out.meta differ >>> ERROR: metadata does not match expected case00a-expect.meta >>> make: *** [fullcheck] Error 1 >> >> Last night I did a git bisect on this issue and this error arose >> when I changed the version from "1.2.1" to "1.3.0pre1". Obvioulsy >> the test shouldn't have failed just because the version string >> changed :-). > > The metadata block contains the vendor string (aka libFLAC version > number). I bet case00a-expect.meta still has 1.2.1. Slight correction. It isn't checking against the vendor string. However, it is checking against the length of the Vorbis Comments Metadata Block. the "pre1" adds 4 bytes and the test fails. -Ben ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Hi all, I'm currently going through the massive test suite, updating all the scripts making sure they conform to the POSIX standard. I've added a bunch of comments to them and have slightly changed/reworked some of the functions to make it easier to read and process. I'm also eliminating the use of 'echo' in favor of 'printf' since echo has many unspecified uses. Attached are only three patches (each patch is for a different test script). If everyone is happy with these three patches, I'll continue and rework the rest of the scripts. Thanks! test_libFLAC.sh.patch Description: Binary data test_libFLAC++.sh.patch Description: Binary data test_seeking.sh.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Jaren Stangret wrote: > Hi all, > > I'm currently going through the massive test suite, updating all the > scripts making sure they conform to the POSIX standard. > > I've added a bunch of comments to them and have slightly changed/reworked > some of the functions to make it easier to read and process. > > I'm also eliminating the use of 'echo' in favor of 'printf' since echo has > many unspecified uses. > > Attached are only three patches (each patch is for a different test > script). If everyone is happy with these three patches, I'll continue and > rework the rest of the scripts. I'd normally say no to a big set of patches like this so close to a final release, but if they only touch tests scripts and when I test them they work on Linux, FreeBSD and OpenBSD, then I'm happy to have them. I'll test this first batch within the next 8-12 hours. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
On Mar 11, 2013, at 21:37, Erik de Castro Lopo wrote: > Jaren Stangret wrote: > >> Hi all, >> >> I'm currently going through the massive test suite, updating all the >> scripts making sure they conform to the POSIX standard. >> >> I've added a bunch of comments to them and have slightly changed/ >> reworked >> some of the functions to make it easier to read and process. >> >> I'm also eliminating the use of 'echo' in favor of 'printf' since >> echo has >> many unspecified uses. >> >> Attached are only three patches (each patch is for a different test >> script). If everyone is happy with these three patches, I'll >> continue and >> rework the rest of the scripts. > > I'd normally say no to a big set of patches like this so close to a > final > release, but if they only touch tests scripts and when I test them > they work > on Linux, FreeBSD and OpenBSD, then I'm happy to have them. > > I'll test this first batch within the next 8-12 hours. > > Erik Hmm, if this huge patch breaks the tests, how do we know whether 1.3.0 is performing identically to 1.2.1? I'm thinking that there is a possibility that the tests might produce a false positive. It seems safer to only change the library or the tests, but not both at the same time. Maybe the patches to the tests should wait until 1.3.1 Brian Willoughby Sound Consulting ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Brian Willoughby wrote: > Hmm, if this huge patch breaks the tests, how do we know whether > 1.3.0 is performing identically to 1.2.1? The only way I can conceive of this "breaking the tests" is by making the test fail in a very obvious manner. > I'm thinking that there is a possibility that the tests might produce > a false positive. >From the patches I've seen so far I think that possibility is vanishingly small. > It seems safer to only change the library or the > tests, but not both at the same time. The tests and the library have already been changed for this release. Thesse patches don't make our problem any worse. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Jaren Stangret wrote: > Attached are only three patches (each patch is for a different test > script). If everyone is happy with these three patches, I'll continue and > rework the rest of the scripts. These look good so far. I've commited them to a branch. When I get the rest I'll test them thoroughly as a batch. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Seems time is going to be a constraint for me in the coming week, but I'll try and get more of these out to you as fast as I can get them written and tested. Keeping the patches in a separate branch for now seems like a good idea to me. Attached is a patch for 'test_streams.sh' On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo wrote: > Jaren Stangret wrote: > > > Attached are only three patches (each patch is for a different test > > script). If everyone is happy with these three patches, I'll continue > and > > rework the rest of the scripts. > > These look good so far. I've commited them to a branch. When I > get the rest I'll test them thoroughly as a batch. > > Erik > -- > -- > Erik de Castro Lopo > http://www.mega-nerd.com/ > ___ > flac-dev mailing list > flac-dev@xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev > test_streams.sh.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Attached is a patch for 'test_compression.sh'. Interestingly, I noticed compression level '0' is omitted, so I've added it in. Also, I tested this on a 24bit/96kHz FLAC file and the test failed between compression level 0 and compression level 1 -- the file size was greater with a compression level of 1, rather than 0. The test works on 'noisy-sine.wav'. It may be worth trying to run this test on a variety of FLAC files (multiple channels, multiple bps, multiple sample rates, etc). What do you guys think? On Tue, Mar 12, 2013 at 2:28 AM, Jaren Stangret wrote: > Seems time is going to be a constraint for me in the coming week, but I'll > try and get more of these out to you as fast as I can get them written and > tested. Keeping the patches in a separate branch for now seems like a good > idea to me. > > Attached is a patch for 'test_streams.sh' > > > On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo > wrote: > >> Jaren Stangret wrote: >> >> > Attached are only three patches (each patch is for a different test >> > script). If everyone is happy with these three patches, I'll continue >> and >> > rework the rest of the scripts. >> >> These look good so far. I've commited them to a branch. When I >> get the rest I'll test them thoroughly as a batch. >> >> Erik >> -- >> -- >> Erik de Castro Lopo >> http://www.mega-nerd.com/ >> ___ >> flac-dev mailing list >> flac-dev@xiph.org >> http://lists.xiph.org/mailman/listinfo/flac-dev >> > > test_compression.sh.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Jaren Stangret wrote: > Interestingly, I noticed compression level '0' is omitted, so I've added it > in. Thanks. > Also, I tested this on a 24bit/96kHz FLAC file and the test failed between > compression level 0 and compression level 1 -- the file size was greater > with a compression level of 1, rather than 0. The test works on > 'noisy-sine.wav'. It may be worth trying to run this test on a variety of > FLAC files (multiple channels, multiple bps, multiple sample rates, etc). Compression levels are always highly dependent on the source material. This particular test was added to test for the most gross kind of regressions like the one I fixed in fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6. When and if we come to update/improve FLAC's core compression code, that is when we would need a more comprehensive test for compressed file sizes. At this point, I think what we have is sufficient. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as the other patches, this patch consists of minor reworks of functions/commands as well as heavily commenting what's going on. More than halfway there! Thanks, Jaren On Tue, Mar 12, 2013 at 9:40 PM, Erik de Castro Lopo wrote: > > Jaren Stangret wrote: > > > Interestingly, I noticed compression level '0' is omitted, so I've added it > > in. > > Thanks. > > > Also, I tested this on a 24bit/96kHz FLAC file and the test failed between > > compression level 0 and compression level 1 -- the file size was greater > > with a compression level of 1, rather than 0. The test works on > > 'noisy-sine.wav'. It may be worth trying to run this test on a variety of > > FLAC files (multiple channels, multiple bps, multiple sample rates, etc). > > Compression levels are always highly dependent on the source material. This > particular test was added to test for the most gross kind of regressions > like the one I fixed in fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6. > > When and if we come to update/improve FLAC's core compression code, that > is when we would need a more comprehensive test for compressed file sizes. > > At this point, I think what we have is sufficient. > > Cheers, > Erik > -- > -- > Erik de Castro Lopo > http://www.mega-nerd.com/ > ___ > flac-dev mailing list > flac-dev@xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev test_grabbag.sh.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Jaren Stangret wrote: > Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as > the other patches, this patch consists of minor reworks of > functions/commands as well as heavily commenting what's going on. > > More than halfway there! Jaren, Any sign of the patches for the rest of these tests? I have some other changes to the tests that I'd like to make and don't want my patches to clash with yours. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Erik, There are changes coming, but I can't give an ETA. I finally have a uniform "feel" to the changes I want to incorporate. The biggest hurdle right now is 'test_flac.sh'. It is a BIG script with a lot of hard to read expressions. Most of my time is spent trying to break it up and make it more legible, while still maintaining the correct behavior/execution. Sorry for the wait! Go ahead and make your changes if you already have them ready. I've been following the tree and will just your changes in myself. Thanks! On Sat, Mar 23, 2013 at 6:37 AM, Erik de Castro Lopo wrote: > Jaren Stangret wrote: > > > Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein > as > > the other patches, this patch consists of minor reworks of > > functions/commands as well as heavily commenting what's going on. > > > > More than halfway there! > > Jaren, > > Any sign of the patches for the rest of these tests? I have some other > changes to the tests that I'd like to make and don't want my patches > to clash with yours. > > Cheers, > Erik > -- > -- > Erik de Castro Lopo > http://www.mega-nerd.com/ > ___ > flac-dev mailing list > flac-dev@xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev > ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Wow, bad last sentence there. I meant to say that I'm actively following HEAD, so go ahead and make any changes and I'll merge them into my local repository. No need to worry about clashing. Thanks! On Sat, Mar 23, 2013 at 9:14 AM, Jaren Stangret wrote: > Erik, > > There are changes coming, but I can't give an ETA. I finally have a > uniform "feel" to the changes I want to incorporate. The biggest hurdle > right now is 'test_flac.sh'. It is a BIG script with a lot of hard to read > expressions. Most of my time is spent trying to break it up and make it > more legible, while still maintaining the correct behavior/execution. > > Sorry for the wait! Go ahead and make your changes if you already have > them ready. I've been following the tree and will just your changes in > myself. > > Thanks! > > > On Sat, Mar 23, 2013 at 6:37 AM, Erik de Castro Lopo > wrote: > >> Jaren Stangret wrote: >> >> > Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein >> as >> > the other patches, this patch consists of minor reworks of >> > functions/commands as well as heavily commenting what's going on. >> > >> > More than halfway there! >> >> Jaren, >> >> Any sign of the patches for the rest of these tests? I have some other >> changes to the tests that I'd like to make and don't want my patches >> to clash with yours. >> >> Cheers, >> Erik >> -- >> -- >> Erik de Castro Lopo >> http://www.mega-nerd.com/ >> ___ >> flac-dev mailing list >> flac-dev@xiph.org >> http://lists.xiph.org/mailman/listinfo/flac-dev >> > > ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
