Re: [flac-dev] issue with flac versions > 1.3.2

[Adam Sampson]

Hi Scott,

Scott Brown  writes:

> I actually modified the shntool source to handle WAVEFORMATEXTENSIBLE
> so I can use 1.3.4.

If you're maintaining updated source for shntool somewhere, I have a
couple of patches to make it handle large files better:

http://offog.org/git/garstow/media/shntool/patches/

It'd be nice to have a Git repo somewhere to collect fixes like this.

Cheers,

-- 
Adam Sampson  
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] issue with flac versions > 1.3.2

[Scott Brown]

Thank you.

I actually modified the shntool source to handle WAVEFORMATEXTENSIBLE so I
can use 1.3.4.

Scott

On Sat, Apr 23, 2022 at 11:30 AM Martijn van Beurden 
wrote:

> Op za 23 apr. 2022 16:17 schreef Scott Brown :
>
>> Is there a flag to switch this back to the old behavior?
>>
>
> Not yet. Technically the old behaviour could be considered non-compliant
> with Microsofts WAVE specification, but many programs, including FLAC up to
> 1.3.3 used it anyway.
>
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] issue with flac versions > 1.3.2

[Martijn van Beurden]

Op za 23 apr. 2022 16:17 schreef Scott Brown :

> Is there a flag to switch this back to the old behavior?
>

Not yet. Technically the old behaviour could be considered non-compliant
with Microsofts WAVE specification, but many programs, including FLAC up to
1.3.3 used it anyway.
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] issue with flac versions > 1.3.2

[Scott Brown]

Thanks, that would explain it.

Is there a flag to switch this back to the old behavior?

I guess I could try to modify shntool to handle it.

Thanks,
Scott

On Sat, Apr 23, 2022 at 6:16 AM Martijn van Beurden 
wrote:

> Op vr 22 apr. 2022 om 23:45 schreef Scott Brown :
> > 2. What changed in 1.3.3+ that may cause this?
>
> I presume this is because you are working with 24-bit material and
> FLAC changed output for such files to WAVEFORMATEXTENSIBLE.
>
> See here:
> - https://hydrogenaud.io/index.php?topic=122251.0
> - https://hydrogenaud.io/index.php?topic=122179.msg1008563#msg1008563
>
> Kind regards, Martijn van Beurden
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] issue with flac versions > 1.3.2

[Martijn van Beurden]

Op vr 22 apr. 2022 om 23:45 schreef Scott Brown :
> 2. What changed in 1.3.3+ that may cause this?

I presume this is because you are working with 24-bit material and
FLAC changed output for such files to WAVEFORMATEXTENSIBLE.

See here:
- https://hydrogenaud.io/index.php?topic=122251.0
- https://hydrogenaud.io/index.php?topic=122179.msg1008563#msg1008563

Kind regards, Martijn van Beurden
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] issue with flac versions > 1.3.2

[Dave Yeo]

On 04/22/22 02:45 PM, Scott Brown wrote:

on flac 1.3.2 and earlier, shntool has no problem reading in the decoded
flac data from std out.

But on 1.3.3 and 1.3.4, shntool doesn't seem to recognize the decoded
flac data as valid PCM data.

1. I hope I'm making sense. and
2. What changed in 1.3.3+ that may cause this?


Perhaps try doing a git bisect between 1.3.2 and 1.3.3 to find the 
commit that broke things?

Dave
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] issue with flac versions > 1.3.2

[Scott Brown]

Hi everyone,

I've run into an issue on flac versions greater than 1.3.2, both on an
intel macs and apple silicon macs. I've compiled natively for both
platforms and see the same issue on both.

With the compiled flac binary, I can encode and decode files just fine, but
the issue pops up when using a 3rd party utility called "shntool" from many
years ago.

When running shntool, I'm calling shntool's "len" and "info" functions.
Basically, shntool recognizes a flac file, knows to use command-line flac
to decode, and decodes the flac file to std out, calling:

flac -d -c -s

and streams the decoded flac data in.

on flac 1.3.2 and earlier, shntool has no problem reading in the decoded
flac data from std out.

But on 1.3.3 and 1.3.4, shntool doesn't seem to recognize the decoded flac
data as valid PCM data.

1. I hope I'm making sense. and
2. What changed in 1.3.3+ that may cause this?

Thanks,
Scott
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev