Re: [flac-dev] [PATCH 3/3] export MALLOC_PERTURB_ and MALLOC_CHECK_ in test suite
Cristian Rodríguez wrote: > That enables an special implementation that checks > for common memory errors and will save us from a lot pain. > --- > test/test_bins.sh |2 ++ > test/test_flac.sh |2 ++ > test/test_grabbag.sh |2 ++ > test/test_libFLAC++.sh |2 ++ > test/test_libFLAC.sh |3 +++ > test/test_metaflac.sh |2 ++ > test/test_seeking.sh |2 ++ > test/test_streams.sh |2 ++ > 8 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/test/test_bins.sh b/test/test_bins.sh > index 55a0b8a..9b1fa0f 100755 > --- a/test/test_bins.sh > +++ b/test/test_bins.sh > @@ -37,6 +37,8 @@ > LD_LIBRARY_PATH=../src/share/replaygain_synthesis/.libs:$LD_LIBRARY_PATH > LD_LIBRARY_PATH=../src/share/utf8/.libs:$LD_LIBRARY_PATH > LD_LIBRARY_PATH=../obj/$BUILD/lib:$LD_LIBRARY_PATH > export LD_LIBRARY_PATH > +export MALLOC_CHECK_=3 > +export MALLOC_PERTURB_==$(($RANDOM % 255 + 1)) This has problems. This fails in bash, sh and dash. Eg bash: $ echo $(($RANDON % 256)) bash: % 256: syntax error: operand expected (error token is "% 256") I do howver like this idea it if can be made to work Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH 3/3] export MALLOC_PERTURB_ and MALLOC_CHECK_ in test suite
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18.04.2012 16:08, Erik de Castro Lopo wrote: > Cristian Rodríguez wrote: > >> That enables an special implementation that checks for common >> memory errors and will save us from a lot pain. --- >> test/test_bins.sh |2 ++ test/test_flac.sh |2 >> ++ test/test_grabbag.sh |2 ++ test/test_libFLAC++.sh |2 >> ++ test/test_libFLAC.sh |3 +++ test/test_metaflac.sh | >> 2 ++ test/test_seeking.sh |2 ++ test/test_streams.sh | >> 2 ++ 8 files changed, 17 insertions(+), 0 deletions(-) >> >> diff --git a/test/test_bins.sh b/test/test_bins.sh index >> 55a0b8a..9b1fa0f 100755 --- a/test/test_bins.sh +++ >> b/test/test_bins.sh @@ -37,6 +37,8 @@ >> LD_LIBRARY_PATH=../src/share/replaygain_synthesis/.libs:$LD_LIBRARY_PATH >> >> LD_LIBRARY_PATH=../src/share/utf8/.libs:$LD_LIBRARY_PATH >> LD_LIBRARY_PATH=../obj/$BUILD/lib:$LD_LIBRARY_PATH export >> LD_LIBRARY_PATH +export MALLOC_CHECK_=3 +export >> MALLOC_PERTURB_==$(($RANDOM % 255 + 1)) > > This has problems. > > This fails in bash, sh and dash. Eg bash: > > $ echo $(($RANDON % 256)) bash: % 256: syntax error: operand > expected (error token is "% 256") > > I do howver like this idea it if can be made to work > Works for me (TM): $ echo $((RANDOM % 255 + 1)) 111 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPjrlbAAoJEOs4Jb6SI2CwPK8H/Au+sz3zdGtiJrDAnUoSoAmt czT0VTWh+i4eeXW/SfuocTc2VkFEuK4ky7fdjCSV1iD2Jrj+3RndqQQClwPTK5Je 9z7gKDOzRekvIF1pENnB8r7OdoiBhVSFU2rGN7GDXxh4des6rvJPHi6Z5VU6AYMO eX+CAppVKIcfRbX56A5HcvzaWOQB+KlH4i7nlVUQq2M5efXCSYKy9d2IjBnywYKa Ddt0Sly/VBwZNE5yiWz6xDU359/0eTfhfDR6N0eZz1B+N3U/67ZnzmWCP1NcLEuL M1coelMpevB8yfQPqYhQdGjgrKajMPsxe0QAoPeHLRic7h0qgSHkZZQTkHE3LoA= =kEcZ -END PGP SIGNATURE- ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH 3/3] export MALLOC_PERTURB_ and MALLOC_CHECK_ in test suite
On 18/04/12 09:08, Erik de Castro Lopo wrote: > Cristian Rodríguez wrote: > >> That enables an special implementation that checks >> for common memory errors and will save us from a lot pain. >> --- >> test/test_bins.sh |2 ++ >> test/test_flac.sh |2 ++ >> test/test_grabbag.sh |2 ++ >> test/test_libFLAC++.sh |2 ++ >> test/test_libFLAC.sh |3 +++ >> test/test_metaflac.sh |2 ++ >> test/test_seeking.sh |2 ++ >> test/test_streams.sh |2 ++ >> 8 files changed, 17 insertions(+), 0 deletions(-) >> >> diff --git a/test/test_bins.sh b/test/test_bins.sh >> index 55a0b8a..9b1fa0f 100755 >> --- a/test/test_bins.sh >> +++ b/test/test_bins.sh >> @@ -37,6 +37,8 @@ >> LD_LIBRARY_PATH=../src/share/replaygain_synthesis/.libs:$LD_LIBRARY_PATH >> LD_LIBRARY_PATH=../src/share/utf8/.libs:$LD_LIBRARY_PATH >> LD_LIBRARY_PATH=../obj/$BUILD/lib:$LD_LIBRARY_PATH >> export LD_LIBRARY_PATH >> +export MALLOC_CHECK_=3 >> +export MALLOC_PERTURB_==$(($RANDOM % 255 + 1)) > > This has problems. > > This fails in bash, sh and dash. Eg bash: > > $ echo $(($RANDON % 256)) > bash: % 256: syntax error: operand expected (error token is "% 256") > > I do howver like this idea it if can be made to work works for me in zsh, bash..etc.. there is a typo in the quoted line though. export MALLOC_PERTURB_==$(($RANDOM % 255 + 1)) must say export MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) however is not gonna work with dash. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH 3/3] export MALLOC_PERTURB_ and MALLOC_CHECK_ in test suite
Cristian Rodríguez wrote: > export MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) > > however is not gonna work with dash. $$ works (in POSIX AFAIK, unlike $RANDOM) and sufficient for this purpose ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
