[flashrom] Flashrom sp_stream_buffer_op() API issue
Hi, I'm trying to fix the build errors of flashrom and came across an API error "Argument with 'nonnull' attribute passed null" which occurred in memcpy() function called inside sp_stream_buffer_op() in file serprog.c. We are passing the third argument of sp_stream_buffer_op() as NULL which gets passed on to the second argument of memcpy() and it expects that argument to be nonnull. Can anybody please provide me with the info and docs for knowing exactly what sp_stream_buffer_op() function does? Also, should we report an error when the third argument passed in the sp_stream_buffer_op() is NULL? Thank You! Regards, Chinmay Lonkar ___ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
[flashrom] Re: Flashrom sp_stream_buffer_op() API issue
Hi Chinmay, Actually calling memcpy with NULL as parameters can lead to undefined behavior, so scan-build is showing that warning. There is already a patch regarding the same on Gerrit: https://review.coreboot.org/c/flashrom/+/62726 Aarya. On Sat, May 7, 2022 at 5:01 PM Chinmay Lonkar wrote: > Hi, > I'm trying to fix the build errors of flashrom and came across an API > error > "Argument with 'nonnull' attribute passed null" which occurred in memcpy() > function called inside sp_stream_buffer_op() in file serprog.c. > > We are passing the third argument of sp_stream_buffer_op() as NULL which > gets passed on to the second argument of memcpy() and it expects that > argument to be nonnull. > > Can anybody please provide me with the info and docs for knowing exactly > what sp_stream_buffer_op() function does? > > Also, should we report an error when the third argument passed in the > sp_stream_buffer_op() is NULL? > > Thank You! > > Regards, > Chinmay Lonkar > ___ > flashrom mailing list -- flashrom@flashrom.org > To unsubscribe send an email to flashrom-le...@flashrom.org > ___ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
[flashrom] Re: Gatekeeping, ACLs and Review Rules
On 06.05.22 03:52, Anastasia Klimchuk wrote: > There are several questions raised in this thread, but good news is > that at the meeting yesterday one of the questions was decided on! > > We decided to have a Reviewers group for flashrom. Technically the attendees agreed on it. Which is a kind of a random selection of people. I would prefer if topics that ask for a decision get their own mailing list thread. Not that I expect anyone to object, but it still would be nice to give busy people a chance to notice it. A little courtesy can't hurt, can it? Nico (Generally, when one top-posts it's a sign that the message might deserve its own thread.) ___ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
[flashrom] Re: Flashrom sp_stream_buffer_op() API issue
Thanks, I'll check it out. On Sat, 7 May 2022, 17:51 Aarya Chaumal, wrote: > Hi Chinmay, > > Actually calling memcpy with NULL as parameters can lead to undefined > behavior, so scan-build is showing that warning. > There is already a patch regarding the same on Gerrit: > https://review.coreboot.org/c/flashrom/+/62726 > > Aarya. > > On Sat, May 7, 2022 at 5:01 PM Chinmay Lonkar > wrote: > >> Hi, >> I'm trying to fix the build errors of flashrom and came across an API >> error >> "Argument with 'nonnull' attribute passed null" which occurred in >> memcpy() function called inside sp_stream_buffer_op() in file serprog.c. >> >> We are passing the third argument of sp_stream_buffer_op() as NULL which >> gets passed on to the second argument of memcpy() and it expects that >> argument to be nonnull. >> >> Can anybody please provide me with the info and docs for knowing exactly >> what sp_stream_buffer_op() function does? >> >> Also, should we report an error when the third argument passed in the >> sp_stream_buffer_op() is NULL? >> >> Thank You! >> >> Regards, >> Chinmay Lonkar >> ___ >> flashrom mailing list -- flashrom@flashrom.org >> To unsubscribe send an email to flashrom-le...@flashrom.org >> > ___ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
