Re: [flexcoders] clean up on aisle three - formatting request for Adobe
On Monday 24 July 2006 16:45, Pan Troglodytes wrote: :P :-) FYI, if you read, you will see that I was asking for standardization, not conversion to spaces. If only everyone had the same standard way of using tabs... -- Tom Chiverton This email is sent for and on behalf of Halliwells LLP. Halliwells LLP is a limited liability partnership registered in England and Wales under registered number OC307980 whose registered office address is at St James's Court Brown Street Manchester M2 2JF. A list of members is available for inspection at the registered office. Any reference to a partner in relation to Halliwells LLP means a member of Halliwells LLP. Regulated by the Law Society. CONFIDENTIALITY This email is intended only for the use of the addressee named above and may be confidential or legally privileged. If you are not the addressee you must not read it and must not use any information contained in nor copy it nor inform any person other than Halliwells LLP or the addressee of its existence or contents. If you have received this email in error please delete it and notify Halliwells LLP IT Department on 0870 365 8008. For more information about Halliwells LLP visit www.halliwells.com. Yahoo! Groups Sponsor ~-- Something is new at Yahoo! Groups. Check out the enhanced email design. http://us.click.yahoo.com/TktRrD/gOaOAA/yQLSAA/nhFolB/TM ~- -- Flexcoders Mailing List FAQ: http://groups.yahoo.com/group/flexcoders/files/flexcodersFAQ.txt Search Archives: http://www.mail-archive.com/flexcoders%40yahoogroups.com Yahoo! Groups Links * To visit your group on the web, go to: http://groups.yahoo.com/group/flexcoders/ * To unsubscribe from this group, send an email to: [EMAIL PROTECTED] * Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/
Re: [flexcoders] clean up on aisle three - formatting request for Adobe
On Friday 21 July 2006 20:13, Pan Troglodytes wrote: indents if it were cleaned up. Personally, I find 4 spaces makes things way to wide for my tastes. That's why tabs should be used :-) -- Tom Chiverton This email is sent for and on behalf of Halliwells LLP. Halliwells LLP is a limited liability partnership registered in England and Wales under registered number OC307980 whose registered office address is at St James's Court Brown Street Manchester M2 2JF. A list of members is available for inspection at the registered office. Any reference to a partner in relation to Halliwells LLP means a member of Halliwells LLP. Regulated by the Law Society. CONFIDENTIALITY This email is intended only for the use of the addressee named above and may be confidential or legally privileged. If you are not the addressee you must not read it and must not use any information contained in nor copy it nor inform any person other than Halliwells LLP or the addressee of its existence or contents. If you have received this email in error please delete it and notify Halliwells LLP IT Department on 0870 365 8008. For more information about Halliwells LLP visit www.halliwells.com. Yahoo! Groups Sponsor ~-- Great things are happening at Yahoo! Groups. See the new email design. http://us.click.yahoo.com/TISQkA/hOaOAA/yQLSAA/nhFolB/TM ~- -- Flexcoders Mailing List FAQ: http://groups.yahoo.com/group/flexcoders/files/flexcodersFAQ.txt Search Archives: http://www.mail-archive.com/flexcoders%40yahoogroups.com Yahoo! Groups Links * To visit your group on the web, go to: http://groups.yahoo.com/group/flexcoders/ * To unsubscribe from this group, send an email to: [EMAIL PROTECTED] * Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/
Re: [flexcoders] clean up on aisle three - formatting request for Adobe
Remind me to have you do a code review before I
post code, lol!
- Original Message -
From: Pan
Troglodytes
To: flexcoders
Sent: Friday, July 21, 2006 12:53 PM
Subject: [flexcoders] clean up on aisle three - formatting request
for Adobe
At some point, it would be nice if someone could go through the
various AS files in the SDK and standardize on using space for indent or tabs
for indent - not both. This is especially bad because it appears some
coders there use proportional fonts (sacrilege!). Anyone doing that has no
business using spaces to indent. XD For example, here's what I see using
fixed width font and two space tabs (DataGrid.as): override protected
function mouseOverHandler(event:MouseEvent):void
{ if (movingColumn)
return; var
r:IListItemRenderer; if (enabled
sortableColumns showHeaders listItems.length
!isPressed)
{ s =
Sprite(listContent.getChildByName("sortArrowHitArea"));
if (event.target != s) r =
mouseEventToItemRenderer(event);
var
n:int = listItems[0].length; for (var i:int =
0; i n;
i++)
{ if (!r s ==
event.target
visibleColumns[i].colNum == sortIndex)
{ r =
listItems[0][i];
}
if (r ==
listItems[0][i])
{
if
(visibleColumns[i].sortable)
{
var s:Sprite = Sprite(
selectionLayer.getChildByName("headerSelection"));
if
(!s)
{
s = new
FlexSprite();
s.name =
"headerSelection";
selectionLayer.addChild(s);
} var
g:Graphics =
s.graphics;
g.clear
();
g.beginFill(getStyle("rollOverColor"));
g.drawRect(0, 0, visibleColumns[i].width, rowInfo[0].height -
0.5);
g.endFill();
s.x =
r.x;
s.y =
rowInfo[0].y;
}
return;
}
}
} lastItemDown =
null;
super.mouseOverHandler(event); }OUCH.-- Jason
__._,_.___
--
Flexcoders Mailing List
FAQ: http://groups.yahoo.com/group/flexcoders/files/flexcodersFAQ.txt
Search Archives: http://www.mail-archive.com/flexcoders%40yahoogroups.com
SPONSORED LINKS
Web site design development
Computer software development
Software design and development
Macromedia flex
Software development best practice
YAHOO! GROUPS LINKS
Visit your group "flexcoders" on the web.
To unsubscribe from this group, send an email to:[EMAIL PROTECTED]
Your use of Yahoo! Groups is subject to the Yahoo! Terms of Service.
__,_._,___
RE: [flexcoders] clean up on aisle three - formatting request for Adobe
The convention is 4 spaces for an indent, tabs
are converted to 4 spaces. I imagine everyone uses fixed-width fonts and
Eclipse doesnt show whitespace characters (that I know of, to-date) so code
formatting like this must have just slipped through the cracks (in my
experience this is not unusual for large source bases). FWIW, in the past Ive
heard arguments of not doing such clean-ups as it complicates change history,
however modern source control systems have the ability to do diffs ignoring
whitespace so this point is somewhat moot.
From:
flexcoders@yahoogroups.com [mailto:[EMAIL PROTECTED] On Behalf Of Pan Troglodytes
Sent: Friday, July 21, 2006 12:53
PM
To: flexcoders
Subject: [flexcoders] clean up on
aisle three - formatting request for Adobe
At some
point, it would be nice if someone could go through the various AS files in the
SDK and standardize on using space for indent or tabs for indent - not
both. This is especially bad because it appears some coders there use
proportional fonts (sacrilege!). Anyone doing that has no business using
spaces to indent. XD
For example, here's what I see using fixed width font and two space tabs
(DataGrid.as):
override protected function
mouseOverHandler(event:MouseEvent):void
{
if (movingColumn)
return;
var r:IListItemRenderer;
if (enabled
sortableColumns showHeaders listItems.length
!isPressed)
{
s =
Sprite(listContent.getChildByName(sortArrowHitArea));
if (event.target != s)
r = mouseEventToItemRenderer(event);
var n:int =
listItems[0].length;
for (var i:int = 0; i n; i++)
{
if (!r s == event.target
visibleColumns[i].colNum
== sortIndex)
{
r = listItems[0][i];
}
if (r == listItems[0][i])
{
if (visibleColumns[i].sortable)
{
var s:Sprite = Sprite(
selectionLayer.getChildByName(headerSelection));
if (!s)
{
s = new FlexSprite();
s.name = headerSelection;
selectionLayer.addChild(s);
}
var
g:Graphics = s.graphics;
g.clear ();
g.beginFill(getStyle(rollOverColor));
g.drawRect(0, 0, visibleColumns[i].width, rowInfo[0].height - 0.5);
g.endFill();
s.x = r.x;
s.y = rowInfo[0].y;
}
return;
}
}
}
lastItemDown = null;
super.mouseOverHandler(event);
}
OUCH.
--
Jason
__._,_.___
--
Flexcoders Mailing List
FAQ: http://groups.yahoo.com/group/flexcoders/files/flexcodersFAQ.txt
Search Archives: http://www.mail-archive.com/flexcoders%40yahoogroups.com
SPONSORED LINKS
Web site design development
Computer software development
Software design and development
Macromedia flex
Software development best practice
YAHOO! GROUPS LINKS
Visit your group "flexcoders" on the web.
To unsubscribe from this group, send an email to:[EMAIL PROTECTED]
Your use of Yahoo! Groups is subject to the Yahoo! Terms of Service.
__,_._,___
