re: [Flightgear-devel] breakage

2002-10-19 Thread David Megginson
John Check writes:

 > Latest cvs build falls down with:
 > 
 > g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src  
 > -I/usr/X11R6/include  -g -O2 -D_REENTRANT -c -o pt_lights.o `test -f 
 > 'pt_lights.cxx' || echo './'`pt_lights.cxx
 > pt_lights.cxx: In function `ssgTimedSelector* gen_rabbit_lights(const
 >point_list&, const point_list&, const int_list&, const int_list&, const
 >std::string&, float*)':
 > pt_lights.cxx:304: `cout' undeclared (first use this function)
 > pt_lights.cxx:304: (Each undeclared identifier is reported only once for each
 >function it appears in.)
 > make[2]: *** [pt_lights.o] Error 1
 > 
 > 
 > commenting out the cout's in pt_lights.cxx gets me past it.

I had the same problem last night, but didn't have a chance to commit
my changes.  It's fixed in CVS now.


All the best,


David

-- 
David Megginson, [EMAIL PROTECTED], http://www.megginson.com/

___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread David Megginson
John Check writes:

 > g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src  
 > -I/usr/X11R6/include -DPKGLIBDIR=\"/usr/local/lib/FlightGear\" -g -O2 
 > -D_REENTRANT -c -o main.o `test -f 'main.cxx' || echo './'`main.cxx
 > main.cxx:152: `void (*glPointParameterfEXT)(unsigned int, float)' redeclared 
 > as
 >different kind of symbol
 > /usr/X11R6/include/GL/gl.h:2519: previous declaration of `void
 >glPointParameterfEXT(unsigned int, float)'
 > main.cxx:153: `void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)'
 >redeclared as different kind of symbol
 > /usr/X11R6/include/GL/gl.h:2520: previous declaration of `void
 >glPointParameterfvEXT(unsigned int, const GLfloat*)'

I didn't get this one.


All the best,


David

-- 
David Megginson, [EMAIL PROTECTED], http://www.megginson.com/

___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread Simon Fowler
On Fri, Oct 18, 2002 at 11:16:25PM -0400, John Check wrote:
> On Friday 18 October 2002 11:02 pm, John Check wrote:
> > Latest cvs build falls down with:
> >
> > g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src
> > -I/usr/X11R6/include  -g -O2 -D_REENTRANT -c -o pt_lights.o `test -f
> > 'pt_lights.cxx' || echo './'`pt_lights.cxx
> > pt_lights.cxx: In function `ssgTimedSelector* gen_rabbit_lights(const
> >point_list&, const point_list&, const int_list&, const int_list&, const
> >std::string&, float*)':
> > pt_lights.cxx:304: `cout' undeclared (first use this function)
> > pt_lights.cxx:304: (Each undeclared identifier is reported only once for
> > each function it appears in.)
> > make[2]: *** [pt_lights.o] Error 1
> >
> >
> > commenting out the cout's in pt_lights.cxx gets me past it.
> >
> > Plib Simgear and FG from CVS
> >
> 
> 
> Okay now it dies with:
> 
> g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src  
> -I/usr/X11R6/include -DPKGLIBDIR=\"/usr/local/lib/FlightGear\" -g -O2 
> -D_REENTRANT -c -o main.o `test -f 'main.cxx' || echo './'`main.cxx
> main.cxx:152: `void (*glPointParameterfEXT)(unsigned int, float)' redeclared 
> as
>different kind of symbol
> /usr/X11R6/include/GL/gl.h:2519: previous declaration of `void
>glPointParameterfEXT(unsigned int, float)'
> main.cxx:153: `void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)'
>redeclared as different kind of symbol
> /usr/X11R6/include/GL/gl.h:2520: previous declaration of `void
>glPointParameterfvEXT(unsigned int, const GLfloat*)'
> 
Are you using Mesa 4, or Mesa 3? I've had some problems building
Simgear and FlightGear recently, due to (apparently) some changes
between Mesa 3.4 and Mesa 4.0 (which I'm using through the DRI cvs
tree now). 

I'm not sure if this is a bug with Mesa 4.0 or with FlightGear - I'm
investigating it at the moment . . . 

Simon

-- 
PGP public key Id 0x144A991C, or http://himi.org/stuff/himi.asc
(crappy) Homepage: http://himi.org
doe #237 (see http://www.lemuria.org/DeCSS) 
My DeCSS mirror: ftp://himi.org/pub/mirrors/css/ 



msg08976/pgp0.pgp
Description: PGP signature


Re: [Flightgear-devel] breakage

2002-10-19 Thread Simon Fowler
On Sat, Oct 19, 2002 at 08:53:54PM +1000, Simon Fowler wrote:
> On Fri, Oct 18, 2002 at 11:16:25PM -0400, John Check wrote:
> > On Friday 18 October 2002 11:02 pm, John Check wrote:
> > > Latest cvs build falls down with:
> > >
> > > g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src
> > > -I/usr/X11R6/include  -g -O2 -D_REENTRANT -c -o pt_lights.o `test -f
> > > 'pt_lights.cxx' || echo './'`pt_lights.cxx
> > > pt_lights.cxx: In function `ssgTimedSelector* gen_rabbit_lights(const
> > >point_list&, const point_list&, const int_list&, const int_list&, const
> > >std::string&, float*)':
> > > pt_lights.cxx:304: `cout' undeclared (first use this function)
> > > pt_lights.cxx:304: (Each undeclared identifier is reported only once for
> > > each function it appears in.)
> > > make[2]: *** [pt_lights.o] Error 1
> > >
> > >
> > > commenting out the cout's in pt_lights.cxx gets me past it.
> > >
> > > Plib Simgear and FG from CVS
> > >
> > 
> > 
> > Okay now it dies with:
> > 
> > g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src  
> > -I/usr/X11R6/include -DPKGLIBDIR=\"/usr/local/lib/FlightGear\" -g -O2 
> > -D_REENTRANT -c -o main.o `test -f 'main.cxx' || echo './'`main.cxx
> > main.cxx:152: `void (*glPointParameterfEXT)(unsigned int, float)' redeclared 
> > as
> >different kind of symbol
> > /usr/X11R6/include/GL/gl.h:2519: previous declaration of `void
> >glPointParameterfEXT(unsigned int, float)'
> > main.cxx:153: `void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)'
> >redeclared as different kind of symbol
> > /usr/X11R6/include/GL/gl.h:2520: previous declaration of `void
> >glPointParameterfvEXT(unsigned int, const GLfloat*)'
> > 
> Are you using Mesa 4, or Mesa 3? I've had some problems building
> Simgear and FlightGear recently, due to (apparently) some changes
> between Mesa 3.4 and Mesa 4.0 (which I'm using through the DRI cvs
> tree now). 
> 
Actually, I just got the same error with (according to GL/gl.h) Mesa
3.4, so that's not it.

Simon

-- 
PGP public key Id 0x144A991C, or http://himi.org/stuff/himi.asc
(crappy) Homepage: http://himi.org
doe #237 (see http://www.lemuria.org/DeCSS) 
My DeCSS mirror: ftp://himi.org/pub/mirrors/css/ 



msg08977/pgp0.pgp
Description: PGP signature


Re: [Flightgear-devel] breakage

2002-10-19 Thread Simon Fowler
On Sat, Oct 19, 2002 at 09:55:46PM +1000, Simon Fowler wrote:
> On Sat, Oct 19, 2002 at 08:53:54PM +1000, Simon Fowler wrote:
> > On Fri, Oct 18, 2002 at 11:16:25PM -0400, John Check wrote:
> > > Okay now it dies with:
> > > 
> > > g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src  
> > > -I/usr/X11R6/include -DPKGLIBDIR=\"/usr/local/lib/FlightGear\" -g -O2 
> > > -D_REENTRANT -c -o main.o `test -f 'main.cxx' || echo './'`main.cxx
> > > main.cxx:152: `void (*glPointParameterfEXT)(unsigned int, float)' redeclared 
> > > as
> > >different kind of symbol
> > > /usr/X11R6/include/GL/gl.h:2519: previous declaration of `void
> > >glPointParameterfEXT(unsigned int, float)'
> > > main.cxx:153: `void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)'
> > >redeclared as different kind of symbol
> > > /usr/X11R6/include/GL/gl.h:2520: previous declaration of `void
> > >glPointParameterfvEXT(unsigned int, const GLfloat*)'
> > > 
> > Are you using Mesa 4, or Mesa 3? I've had some problems building
> > Simgear and FlightGear recently, due to (apparently) some changes
> > between Mesa 3.4 and Mesa 4.0 (which I'm using through the DRI cvs
> > tree now). 
> > 
> Actually, I just got the same error with (according to GL/gl.h) Mesa
> 3.4, so that's not it.
> 
And it went away again, when I stopped defining GL_GLEXT_LEGACY . .
. 

In Mesa 3.4's gl.h glPointParameterfvEXT is wrapped in a #ifdef
GL_GLEXT_LEGACY (as is glActiveTextureARB in Mesa 4.0, which is why
I was playing around with it). I got the error above when
GL_GLEXT_LEGACY was defined, and it went away without it. Anyone
with more knowledge of OpenGL got any clues? 

Simon

-- 
PGP public key Id 0x144A991C, or http://himi.org/stuff/himi.asc
(crappy) Homepage: http://himi.org
doe #237 (see http://www.lemuria.org/DeCSS) 
My DeCSS mirror: ftp://himi.org/pub/mirrors/css/ 



msg08978/pgp0.pgp
Description: PGP signature


Re: [Flightgear-devel] breakage

2002-10-19 Thread Erik Hofman
Simon Fowler wrote:



Actually, I just got the same error with (according to GL/gl.h) Mesa
3.4, so that's not it.


And it went away again, when I stopped defining GL_GLEXT_LEGACY . .

In Mesa 3.4's gl.h glPointParameterfvEXT is wrapped in a #ifdef
GL_GLEXT_LEGACY (as is glActiveTextureARB in Mesa 4.0, which is why
I was playing around with it). I got the error above when
GL_GLEXT_LEGACY was defined, and it went away without it. Anyone
with more knowledge of OpenGL got any clues? 

Well, I know it started as glPointParameterfvSGIS when SGI invented it, 
then it became glPointParameterfvEXT because it was an extension if 
nVidea and now it looks like the OpenGL ARB has adopted this feature and 
called it glPointParameterfvARB ...

Erik


___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel


Re: [Flightgear-devel] breakage

2002-10-19 Thread Andy Ross
John Check wrote:
> Latest cvs build falls down with:
>
> pt_lights.cxx:304: `cout' undeclared (first use this function)

You're using gcc 3.2 I assume?  It's a namespace issue.  The C++
standard library naming is stricter now.  You need to use std::cout,
or insert a "using namespace std;" above the usage.

> main.cxx:153:
>void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)
> /usr/X11R6/include/GL/gl.h:2520:
>glPointParameterfvEXT(unsigned int, const GLfloat*)'

OK, this one looks kinda wrong.  Our code is defining its own copy of
the glPointParameter function pointers, when they've already been
declared as regular functions in gl.h.  What's the purpose here?  All
of the declared extensions are supposed to be defined in the ARB
glext.h header, I believe.  User-level code shouldn't have to play
this kind of game anymore.

It's worth pointing out that I don't see this issue.  I have the
NVidia drivers installed, which might have differeing header behavior?

Andy

--
Andrew J. RossNextBus Information Systems
Senior Software Engineer  Emeryville, CA
[EMAIL PROTECTED]  http://www.nextbus.com
"Men go crazy in conflagrations.  They only get better one by one."
 - Sting (misquoted)


___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread Norman Vine
Andy Ross writes:

> John Check wrote:> 
>  > main.cxx:153:
>  >void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)
>  > /usr/X11R6/include/GL/gl.h:2520:
>  >glPointParameterfvEXT(unsigned int, const GLfloat*)'
> 
> OK, this one looks kinda wrong.  Our code is defining its own copy of
> the glPointParameter function pointers, when they've already been
> declared as regular functions in gl.h.  What's the purpose here?  All
> of the declared extensions are supposed to be defined in the ARB
> glext.h header, I believe.  User-level code shouldn't have to play
> this kind of game anymore.

This is true in the non-windows world, but since the distributed M$oft 
OpenGL is version 1.1 this is a major pain to do easily in a cross platform
way.  FWIW making this transparent is what the extgl package in the 
Clouds3D directory is trying to do.   Perhaps it is time to bring up
cross platform OpenGL extension handling on the PLIB list.

Norman


___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread Andy Ross
diff -u -w -r1.31 main.cxx
--- main.cxx17 Oct 2002 04:34:32 -  1.31
+++ main.cxx19 Oct 2002 18:38:22 -
@@ -141,16 +141,16 @@
   typedef void (APIENTRY * PFNGLPOINTPARAMETERFVEXTPROC)(GLenum pname,
  const GLfloat *params);

-  PFNGLPOINTPARAMETERFEXTPROC glPointParameterfEXT = 0;
-  PFNGLPOINTPARAMETERFVEXTPROC glPointParameterfvEXT = 0;
+  PFNGLPOINTPARAMETERFEXTPROC gl_PointParameterfEXT = 0;
+  PFNGLPOINTPARAMETERFVEXTPROC g_lPointParameterfvEXT = 0;
 #elif linux
   #include 

   typedef void (* OpenGLFuncExt)(GLenum pname, GLfloat param);
   typedef void (* OpenGLFuncExtv)(GLenum pname, const GLfloat *params);

-  OpenGLFuncExt glPointParameterfEXT = 0;
-  OpenGLFuncExtv glPointParameterfvEXT = 0;
+  OpenGLFuncExt gl_PointParameterfEXT = 0;
+  OpenGLFuncExtv gl_PointParameterfvEXT = 0;
 #endif

 float default_attenuation[3] = {1.0, 0.0, 0.0};
@@ -743,8 +743,8 @@
 glEnable(GL_POINT_SMOOTH);
 float quadratic[3] = {1.0, 0.001, 0.001};
 // makes the points fade as they move away
-glPointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT, quadratic);
-glPointParameterfEXT(GL_POINT_SIZE_MIN_EXT, 1.0);
+gl_PointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT, quadratic);
+gl_PointParameterfEXT(GL_POINT_SIZE_MIN_EXT, 1.0);
 glPointSize(4.0);
}

@@ -774,7 +774,7 @@

 #ifdef FG_EXPERIMENTAL_LIGHTING
if (glutExtensionSupported("GL_EXT_point_parameters")) {
-glPointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT,
+gl_PointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT,
   default_attenuation);
}

@@ -1578,14 +1578,14 @@
 #ifdef FG_EXPERIMENTAL_LIGHTING
 // get the address of our OpenGL extensions
 #  ifdef WIN32
-glPointParameterfEXT = (PFNGLPOINTPARAMETERFEXTPROC)
+gl_PointParameterfEXT = (PFNGLPOINTPARAMETERFEXTPROC)
 wglGetProcAddress("glPointParameterfEXT");
-glPointParameterfvEXT = (PFNGLPOINTPARAMETERFVEXTPROC)
+gl_PointParameterfvEXT = (PFNGLPOINTPARAMETERFVEXTPROC)
 wglGetProcAddress("glPointParameterfvEXT");
 #  elif linux
-glPointParameterfEXT = (OpenGLFuncExt)
+gl_PointParameterfEXT = (OpenGLFuncExt)
 glXGetProcAddressARB((GLubyte *)"glPointParameterfEXT");
-glPointParameterfvEXT = (OpenGLFuncExtv)
+gl_PointParameterfvEXT = (OpenGLFuncExtv)
 glXGetProcAddressARB((GLubyte *)"glPointParameterfvEXT");
 #  endif
 #endif

--
Andrew J. RossNextBus Information Systems
Senior Software Engineer  Emeryville, CA
[EMAIL PROTECTED]  http://www.nextbus.com
"Men go crazy in conflagrations.  They only get better one by one."
 - Sting (misquoted)


___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread Andy Ross
[Er, oops.  The last one had the patch but not the text.  Apologies!]

OK, looking more carefully, I think I see how this is supposed to
work.  Because not all OpenGL implementations export the
PointParameter functions, Curt is using function pointers and the
GetProcAddress stuff.

This is fine; the only bug is that the names of the function pointers
are identical to the names of the functions.  This is attractive,
because you can use the same syntax for both.

But it doesn't work across all implementations.  In some, the
definition of the functions are as "regular" functions, not pointers.
So while the invocation syntax is the same, the assignment syntax is
not.  You can't redeclare a regular function as a function pointer --
they're not compatible types.

The following patch just renames the symbol used to avoid the
collision.  It seems to work for me.

Andy


diff -u -w -r1.31 main.cxx
--- main.cxx17 Oct 2002 04:34:32 -  1.31
+++ main.cxx19 Oct 2002 18:38:22 -
@@ -141,16 +141,16 @@
   typedef void (APIENTRY * PFNGLPOINTPARAMETERFVEXTPROC)(GLenum pname,
  const GLfloat *params);

-  PFNGLPOINTPARAMETERFEXTPROC glPointParameterfEXT = 0;
-  PFNGLPOINTPARAMETERFVEXTPROC glPointParameterfvEXT = 0;
+  PFNGLPOINTPARAMETERFEXTPROC gl_PointParameterfEXT = 0;
+  PFNGLPOINTPARAMETERFVEXTPROC g_lPointParameterfvEXT = 0;
 #elif linux
   #include 

   typedef void (* OpenGLFuncExt)(GLenum pname, GLfloat param);
   typedef void (* OpenGLFuncExtv)(GLenum pname, const GLfloat *params);

-  OpenGLFuncExt glPointParameterfEXT = 0;
-  OpenGLFuncExtv glPointParameterfvEXT = 0;
+  OpenGLFuncExt gl_PointParameterfEXT = 0;
+  OpenGLFuncExtv gl_PointParameterfvEXT = 0;
 #endif

 float default_attenuation[3] = {1.0, 0.0, 0.0};
@@ -743,8 +743,8 @@
 glEnable(GL_POINT_SMOOTH);
 float quadratic[3] = {1.0, 0.001, 0.001};
 // makes the points fade as they move away
-glPointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT, quadratic);
-glPointParameterfEXT(GL_POINT_SIZE_MIN_EXT, 1.0);
+gl_PointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT, quadratic);
+gl_PointParameterfEXT(GL_POINT_SIZE_MIN_EXT, 1.0);
 glPointSize(4.0);
}

@@ -774,7 +774,7 @@

 #ifdef FG_EXPERIMENTAL_LIGHTING
if (glutExtensionSupported("GL_EXT_point_parameters")) {
-glPointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT,
+gl_PointParameterfvEXT(GL_DISTANCE_ATTENUATION_EXT,
   default_attenuation);
}

@@ -1578,14 +1578,14 @@
 #ifdef FG_EXPERIMENTAL_LIGHTING
 // get the address of our OpenGL extensions
 #  ifdef WIN32
-glPointParameterfEXT = (PFNGLPOINTPARAMETERFEXTPROC)
+gl_PointParameterfEXT = (PFNGLPOINTPARAMETERFEXTPROC)
 wglGetProcAddress("glPointParameterfEXT");
-glPointParameterfvEXT = (PFNGLPOINTPARAMETERFVEXTPROC)
+gl_PointParameterfvEXT = (PFNGLPOINTPARAMETERFVEXTPROC)
 wglGetProcAddress("glPointParameterfvEXT");
 #  elif linux
-glPointParameterfEXT = (OpenGLFuncExt)
+gl_PointParameterfEXT = (OpenGLFuncExt)
 glXGetProcAddressARB((GLubyte *)"glPointParameterfEXT");
-glPointParameterfvEXT = (OpenGLFuncExtv)
+gl_PointParameterfvEXT = (OpenGLFuncExtv)
 glXGetProcAddressARB((GLubyte *)"glPointParameterfvEXT");
 #  endif
 #endif

--
Andrew J. RossNextBus Information Systems
Senior Software Engineer  Emeryville, CA
[EMAIL PROTECTED]  http://www.nextbus.com
"Men go crazy in conflagrations.  They only get better one by one."
 - Sting (misquoted)


___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread John Check
On Saturday 19 October 2002 1:33 pm, Andy Ross wrote:
> John Check wrote:
>  > Latest cvs build falls down with:
>  >
>  > pt_lights.cxx:304: `cout' undeclared (first use this function)
>
> You're using gcc 3.2 I assume?  It's a namespace issue.  The C++
> standard library naming is stricter now.  You need to use std::cout,
> or insert a "using namespace std;" above the usage.
>
>  > main.cxx:153:
>  >void (*glPointParameterfvEXT)(unsigned int, const GLfloat*)
>  > /usr/X11R6/include/GL/gl.h:2520:
>  >glPointParameterfvEXT(unsigned int, const GLfloat*)'
>
> OK, this one looks kinda wrong.  Our code is defining its own copy of
> the glPointParameter function pointers, when they've already been
> declared as regular functions in gl.h.  What's the purpose here?  All
> of the declared extensions are supposed to be defined in the ARB
> glext.h header, I believe.  User-level code shouldn't have to play
> this kind of game anymore.
>
> It's worth pointing out that I don't see this issue.  I have the
> NVidia drivers installed, which might have differeing header behavior?
>
> Andy

nvidia-glx-1.0.3123 here. This is Gentoo 1.4-r1 machine FWIW.
I'll apply the patch from your later email. Your explaination
is right in line with the error message.

___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread John Check
On Saturday 19 October 2002 2:47 pm, Andy Ross wrote:
> [Er, oops.  The last one had the patch but not the text.  Apologies!]
>
> OK, looking more carefully, I think I see how this is supposed to
> work.  Because not all OpenGL implementations export the
> PointParameter functions, Curt is using function pointers and the
> GetProcAddress stuff.
>
> This is fine; the only bug is that the names of the function pointers
> are identical to the names of the functions.  This is attractive,
> because you can use the same syntax for both.
>
> But it doesn't work across all implementations.  In some, the
> definition of the functions are as "regular" functions, not pointers.
> So while the invocation syntax is the same, the assignment syntax is
> not.  You can't redeclare a regular function as a function pointer --
> they're not compatible types.
>
> The following patch just renames the symbol used to avoid the
> collision.  It seems to work for me.
>
> Andy
>
>
> diff -u -w -r1.31 main.cxx
> --- main.cxx17 Oct 2002 04:34:32 -  1.31
> +++ main.cxx19 Oct 2002 18:38:22 -
> @@ -141,16 +141,16 @@
> typedef void (APIENTRY * PFNGLPOINTPARAMETERFVEXTPROC)(GLenum pname,
>const GLfloat
> *params);
>
> -  PFNGLPOINTPARAMETERFEXTPROC glPointParameterfEXT = 0;
> -  PFNGLPOINTPARAMETERFVEXTPROC glPointParameterfvEXT = 0;
> +  PFNGLPOINTPARAMETERFEXTPROC gl_PointParameterfEXT = 0;
> +  PFNGLPOINTPARAMETERFVEXTPROC g_lPointParameterfvEXT = 0;

Is this last line correct? The rest of the patch uses gl_PointParameterfvEXT

FWIW I couldn't get the patch to apply and I noticed while applying changes 

___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread Andy Ross
John Check wrote:
> Is this last line correct?

Uh, no. :)

Sorry.  I don't compile on a windows box, so that part of the change
was blind.

Obviously, the actual names of the symbols used isn't important.  You
could just as easily use "GL" or "fg", or "fgfsgl" or whatnot so long
as it's consistent and doesn't collide with the existing OpenGL
names.

But the patch should have applied cleanly -- it just would have failed
during compilation.  Or is that what you meant?

Andy

--
Andrew J. RossNextBus Information Systems
Senior Software Engineer  Emeryville, CA
[EMAIL PROTECTED]  http://www.nextbus.com
"Men go crazy in conflagrations.  They only get better one by one."
 - Sting (misquoted)


___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel



Re: [Flightgear-devel] breakage

2002-10-19 Thread John Check
On Saturday 19 October 2002 8:52 pm, Andy Ross wrote:
> John Check wrote:
>  > Is this last line correct?
>
> Uh, no. :)
>
> Sorry.  I don't compile on a windows box, so that part of the change
> was blind.

windows box? I don't like the way they look. Shutters are okay,
but windowboxes.. not my thing. 

>
> Obviously, the actual names of the symbols used isn't important.  You
> could just as easily use "GL" or "fg", or "fgfsgl" or whatnot so long
> as it's consistent and doesn't collide with the existing OpenGL
> names.

Right.


>
> But the patch should have applied cleanly -- it just would have failed
> during compilation.  Or is that what you meant?
>

It wouldn't apply. I was getting 4 failed hunks. I should have saved the .rej 
file. It might have been because I saved the email and trimmed off the 
headers and the list sig.


> Andy

___
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel