[Flightgear-devel] [PATCH] shutdown engine on fuel shortage
hi there,
if noticed that my engine doesn't shutdown if i'am out of
fuel. the attached patch fixes that.
cu markus
? filtersjb/.deps
? filtersjb/Makefile
? filtersjb/Makefile.in
Index: models/propulsion/FGEngine.cpp
===
RCS file: /var/cvs/FlightGear-0.9/source/src/FDM/JSBSim/models/propulsion/FGEngine.cpp,v
retrieving revision 1.1
diff -r1.1 FGEngine.cpp
178c178,181
< if (TanksWithFuel==0 || (haveOxTanks && TanksWithOxidizer==0)) return;
---
> if (TanksWithFuel==0 || (haveOxTanks && TanksWithOxidizer==0)) {
> Starved = true;
> return;
> }
--
Markus Barenhoff - phone: +49-40-39991368 - cell: +49-173-7215776
Stellinger Chaussee 26c - D-22529 Hamburg - Germany - Earth
url: http://www.alios.org/ - mail: [EMAIL PROTECTED]
pgpkey: 0xAE7C7759 fp: 79 64 AA D9 B7 16 F5 06 6A 88 5F A9 4D 49 45 BB
Re: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
On Sat, 18 Mar 2006 09:27:45 +0100 Markus Barenhoff wrote: > > > hi there, > > if noticed that my engine doesn't shutdown if i'am out of > fuel. the attached patch fixes that. Do JSBSim patches get submitted here? (as opposed to directly to JSBSim, at http://jsbsim.sourceforge.net/) -c -- Chris Metzler [EMAIL PROTECTED] (remove "snip-me." to email) "As a child I understood how to give; I have forgotten this grace since I have become civilized." - Chief Luther Standing Bear signature.asc Description: PGP signature
Re: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
· Chris Metzler <[EMAIL PROTECTED]> wrote: > On Sat, 18 Mar 2006 09:27:45 +0100 > Markus Barenhoff wrote: > >> if noticed that my engine doesn't shutdown if i'am out of >> fuel. the attached patch fixes that. > > Do JSBSim patches get submitted here? (as opposed to directly to > JSBSim, at http://jsbsim.sourceforge.net/) i've mailed it to both list. (but no replay on neighter of them ;-)) cu markus -- Markus Barenhoff - phone: +49-40-39991368 - cell: +49-173-7215776 Stellinger Chaussee 26c - D-22529 Hamburg - Germany - Earth url: http://www.alios.org/ - mail: [EMAIL PROTECTED] pgpkey: 0xAE7C7759 fp: 79 64 AA D9 B7 16 F5 06 6A 88 5F A9 4D 49 45 BB pgpHeyTQClvyK.pgp Description: PGP signature
RE: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
Markus - I've got your patch. I hope to take a look and implement this shortly - might be a day or two. Email me if I forget. Jon Jon S. Berndt Development Coordinator JSBSim Project www.JSBSim.org > > > >> if noticed that my engine doesn't shutdown if i'am out of > >> fuel. the attached patch fixes that. > > > > Do JSBSim patches get submitted here? (as opposed to directly to > > JSBSim, at http://jsbsim.sourceforge.net/) > > i've mailed it to both list. (but no replay on neighter of them ;-)) > > cu markus --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
On Saturday 18 March 2006 23:34, Jon S. Berndt wrote: > Markus - I've got your patch. I hope to take a look and implement this > shortly - might be a day or two. Email me if I forget. I've quite possibly missed something - but was pretty sure (and others have also confirmed) that this functionality is already present in JSBSim? I didn't do anything fancy with the Lightning regarding fuel handling, and its engines stopped when there was no fuel left in any of the tanks (all too common an occurrance with the Lightning IRL too :-) Slightly confused... AJ --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
RE: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
> > Markus - I've got your patch. I hope to take a look and implement this > > shortly - might be a day or two. Email me if I forget. > > I've quite possibly missed something - but was pretty sure (and > others have > also confirmed) that this functionality is already present in JSBSim? > > I didn't do anything fancy with the Lightning regarding fuel > handling, and its > engines stopped when there was no fuel left in any of the tanks (all too > common an occurrance with the Lightning IRL too :-) > > AJ You may very well be correct. It's supposed to work. I've seen it work before. That's going to be part of the process of implementing (or not) the patch. Jon --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
· AJ MacLeod <[EMAIL PROTECTED]> wrote: > On Saturday 18 March 2006 23:34, Jon S. Berndt wrote: >> Markus - I've got your patch. I hope to take a look and implement this >> shortly - might be a day or two. Email me if I forget. > > I've quite possibly missed something - but was pretty sure (and others have > also confirmed) that this functionality is already present in JSBSim? > > I didn't do anything fancy with the Lightning regarding fuel handling, and > its > engines stopped when there was no fuel left in any of the tanks (all too > common an occurrance with the Lightning IRL too :-) > mmm as far as i understood the code the variable Starved is supposed to be set true, if there is not enough fuel. the only place where this variable is set, was in FGEnginge::ConsumeFuel(). The the function simply returned if TanksWithFuel==0, without setting Starved anywhere ... cu markus -- Markus Barenhoff - phone: +49-40-39991368 - cell: +49-173-7215776 Stellinger Chaussee 26c - D-22529 Hamburg - Germany - Earth url: http://www.alios.org/ - mail: [EMAIL PROTECTED] pgpkey: 0xAE7C7759 fp: 79 64 AA D9 B7 16 F5 06 6A 88 5F A9 4D 49 45 BB pgp10VxMf0PNp.pgp Description: PGP signature
RE: [Flightgear-devel] [PATCH] shutdown engine on fuel shortage
The patch has been incorporated into JSBSim and has been committed to JSBSim CVS. Thanks, Markus. Jon --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
