Re: [Flightgear-devel] How to get my bug fix into the git?
ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/, is still at Boost 1.44, and many MSVC users will be using that rather than the latest version. I am updating my own Boost version at the moment, and will report if that solves the compilation problem. Alan -Original Message- From: Thomas Geymayer Sent: Wednesday, March 06, 2013 12:42 AM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] How to get my bug fix into the git? Hi, Am 2013-03-06 00:11, schrieb Godspeed Dash: I don't think it is related specific to the strdup(), it looks more like it has something to do with boost 1.44, I was compiling using a higher version, boost 1.53. The warnings should now have gone, but the other errors look like due to a very old boost version. Tom -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
On 6 Mar 2013, at 11:11, Alan Teeder ajtee...@v-twin.org.uk wrote: ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/, is still at Boost 1.44, and many MSVC users will be using that rather than the latest version. I am updating my own Boost version at the moment, and will report if that solves the compilation problem. Yes, I am suspect this issue too. I am working on making the fgmeta build uses the Boost compiled by Jenkins, I would suggest other people try that too, as an alternative to building boost themselves - there are also prebuilt installer for Boost on Windows, again much simpler than building your own. James -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Am 2013-03-06 12:11, schrieb Alan Teeder: ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/, is still at Boost 1.44, and many MSVC users will be using that rather than the latest version. I am updating my own Boost version at the moment, and will report if that solves the compilation problem. I've now found a solution. This problem is due to argument depended lookup inside templates and the new c++11 mem_fn which creates an unresolvable overload. It should be fixed in Boost 1.47, or by applying a simple two line patch to the boost installation: https://svn.boost.org/trac/boost/attachment/ticket/4073/function_template_for_c%2B%2B0x.patch Tom -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
-Original Message- From: James Turner Sent: Wednesday, March 06, 2013 11:42 AM To: FlightGear developers discussions Subject: Re: [Flightgear-devel] How to get my bug fix into the git? On 6 Mar 2013, at 11:11, Alan Teeder ajtee...@v-twin.org.uk wrote: ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/, is still at Boost 1.44, and many MSVC users will be using that rather than the latest version. I am updating my own Boost version at the moment, and will report if that solves the compilation problem. Yes, I am suspect this issue too. I am working on making the fgmeta build uses the Boost compiled by Jenkins, I would suggest other people try that too, as an alternative to building boost themselves - there are also prebuilt installer for Boost on Windows, again much simpler than building your own. James Boostpro, (http://www.boostpro.com/download/) who used to provide the pre-built binaries, have closed and are no longer providing this service. 1.51.1 is the last version available from them. Alan -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
I have upgraded boost to 1.53, building with MSVC10. All now runs. The biggest problem was sorting out the resulting Cmake chaos. Alan -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Hi Thomas, Anyhow, I have just pushed a fix which replaces the manual string copying with directly using std::string. Please test if this also solves your problem. Not sure if I'm experiencing the same issue, but it looks related. SimGear fails to compile for me, showing these errors: http://pastebin.com/917r9B1s Thanks! Gijs -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Hi Gijs, I don't think it is related specific to the strdup(), it looks more like it has something to do with boost 1.44, I was compiling using a higher version, boost 1.53. And @Tom, I used macros to work around the strdup() under MSVC, as you suggested, and I have submitted the merge request to both simgear and flightgear, please have a look. Thanks! Sincerely Godspeed On Tue, Mar 5, 2013 at 1:23 PM, Gijs de Rooy gijsr...@hotmail.com wrote: Hi Thomas, Anyhow, I have just pushed a fix which replaces the manual string copying with directly using std::string. Please test if this also solves your problem. Not sure if I'm experiencing the same issue, but it looks related. SimGear fails to compile for me, showing these errors: http://pastebin.com/917r9B1s Thanks! Gijs -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Hi, Am 2013-03-06 00:11, schrieb Godspeed Dash: I don't think it is related specific to the strdup(), it looks more like it has something to do with boost 1.44, I was compiling using a higher version, boost 1.53. The warnings should now have gone, but the other errors look like due to a very old boost version. And @Tom, I used macros to work around the strdup() under MSVC, as you suggested, and I have submitted the merge request to both simgear and flightgear, please have a look. I'd prefer to add it globally instead of doing it for every single occurrence. Could you try it with adding -Dstrdup=_strdup to the respective set(MSVC_FLAGS commands in FlightGear/SimGear root CMakeLists.txt files? Tom -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and remains a good choice in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Am 2013-03-03 05:20, schrieb Zhitao Li: I believe your commit has fixed the specific problem, however, there is more similar string related heap corruptions popping up in the debug mode, I think I can try to fix them in a similar way you did to fix this one, if it's OK Yes, there strdup is used 7 more times, but we can not replace all with std::string as eg. in BufferedLogCallback.cxx it would get very slow. Maybe you can try if somehow adding a #define strdup _strdup works with MSVC? Tom -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Hi Tom, I have seem [1], and I don't think it is caused by the linking problem, I check and experimented the cmake parameter, it's more likely the implementation of the function in visual studio that's causing it. (the malloc() within the strdup() is probably using a different heap than the outside free()) And I don't think what I did only hides the symptoms, since _strdup() is OK to use in the windows environment. But I do believe the best solution is to replace this function. If that's required, just let me know, I can replace it and create a new merge. Thanks! Godspeed -Original Message- From: Thomas Geymayer [mailto:tom...@gmail.com] Sent: Friday, March 01, 2013 4:22 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] How to get my bug fix into the git? Hi Godspeed, Am 2013-03-01 10:14, schrieb Zhitao Li: I am new to the FlightGear project, I just found and fixed my first bug, Great ;) I'm not sure if your fix [2] is really a fix or just hiding symptoms. I currently have no VS available for testing but eg. at [1] it seems like its a linking problem instead. I am wondering how to get my fix into the main git next branch? You can always open a merge request into the next branch at gitorious. Tom [1] http://stackoverflow.com/questions/8740500/heap-corruption-with-strdup?rq=1 [2] https://gitorious.org/~plutonium/fg/plutoniums-simgear/commit/0455e8f3253a2b c26e4a34265e1227984408713a -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Am 2013-03-03 00:49, schrieb Zhitao Li: I have seem [1], and I don't think it is caused by the linking problem, I check and experimented the cmake parameter, it's more likely the implementation of the function in visual studio that's causing it. (the malloc() within the strdup() is probably using a different heap than the outside free()) As I normally don't use Windows/VS I don't know if this is really possible. Anyhow, I have just pushed a fix which replaces the manual string copying with directly using std::string. Please test if this also solves your problem. Tom -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Thanks Tom, I believe your commit has fixed the specific problem, however, there is more similar string related heap corruptions popping up in the debug mode, I think I can try to fix them in a similar way you did to fix this one, if it's OK Thanks. Godspeed -Original Message- From: Thomas Geymayer [mailto:tom...@gmail.com] Sent: Saturday, March 02, 2013 5:20 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] How to get my bug fix into the git? Am 2013-03-03 00:49, schrieb Zhitao Li: I have seem [1], and I don't think it is caused by the linking problem, I check and experimented the cmake parameter, it's more likely the implementation of the function in visual studio that's causing it. (the malloc() within the strdup() is probably using a different heap than the outside free()) As I normally don't use Windows/VS I don't know if this is really possible. Anyhow, I have just pushed a fix which replaces the manual string copying with directly using std::string. Please test if this also solves your problem. Tom -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] How to get my bug fix into the git?
Hi everyone, I am new to the FlightGear project, I just found and fixed my first bug, I am wondering how to get my fix into the main git next branch? Thanks! Sincerely Godspeed -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
On Fri, 1 Mar 2013 02:14:59 -0700, Zhitao wrote in message 004601ce165d$409a80c0$c1cf8240$@gmail.com: Hi everyone, I am new to the FlightGear project, I just found and fixed my first bug, I am wondering how to get my fix into the main git next branch? ..you put it here?: https://code.google.com/p/flightgear-bugs/ ..attach your patch to your message, or to your bug report. -- ..med vennlig hilsen = with Kind Regards from Arnt Karlsen ...with a number of polar bear hunters in his ancestry... Scenarios always come in sets of three: best case, worst case, and just in case. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] How to get my bug fix into the git?
Hi Godspeed, Am 2013-03-01 10:14, schrieb Zhitao Li: I am new to the FlightGear project, I just found and fixed my first bug, Great ;) I'm not sure if your fix [2] is really a fix or just hiding symptoms. I currently have no VS available for testing but eg. at [1] it seems like its a linking problem instead. I am wondering how to get my fix into the main git next branch? You can always open a merge request into the next branch at gitorious. Tom [1] http://stackoverflow.com/questions/8740500/heap-corruption-with-strdup?rq=1 [2] https://gitorious.org/~plutonium/fg/plutoniums-simgear/commit/0455e8f3253a2bc26e4a34265e1227984408713a -- Thomas Geymayer www.tomprogs.at / C-Forum und Tutorial: www.proggen.org Student of Computer Science @ Graz University of Technology --- Austria -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
