Re: remove layout package?

[Clay Leeds]

On Sep 5, 2004, at 5:00 AM, Glen Mazza wrote:
Team,
With the recent removal (who did that? ;) of the
unused layout.AreaClass and layout.TextState classes,
the fop.layout package is now empty save for its
hyphenation subpackage.
Thanks! Simple is better!
I'd like to drop the layout package and make
hyphenation a top-level package (i.e.,
org.apache.fop.hyphenation).  Comments?
I like that... org.apache.fop.hyphenation is a much cleaner, and less 
confusing change.

These changes make sense to me!
Thanks!
Web Maestro Clay

DO NOT REPLY [Bug 31063] - "id already in this document" error with no duplicate id

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31063

"id already in this document" error with no duplicate id

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 19:33 ---


*** This bug has been marked as a duplicate of 14962 ***

DO NOT REPLY [Bug 14962] - Bug in ID Generation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14962

Bug in ID Generation

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||jean-
   ||[EMAIL PROTECTED]
   ||rg



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 19:33 ---
*** Bug 31063 has been marked as a duplicate of this bug. ***

DO NOT REPLY [Bug 31063] - "id already in this document" error with no duplicate id

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31063

"id already in this document" error with no duplicate id

[EMAIL PROTECTED] changed:

   What|Removed |Added

URL|http://tigreraye.org/essai.f|http://tigreraye.org/essai.f
   |o   |o
   |http://tigreraye.org/essai.x|
   |ml  |



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 18:24 ---
The DocBook XML file is available here: http://tigreraye.org/essai.xml

Re: remove layout package?

[Simon Pepping]

On Sun, Sep 05, 2004 at 05:00:07AM -0700, Glen Mazza wrote:
> Team,
> 
> With the recent removal (who did that? ;) of the
> unused layout.AreaClass and layout.TextState classes,
> the fop.layout package is now empty save for its
> hyphenation subpackage.
> 
> I'd like to drop the layout package and make
> hyphenation a top-level package (i.e.,
> org.apache.fop.hyphenation).  Comments?

I have no problem with your proposal.

Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl

DO NOT REPLY [Bug 29124] - New line breaking algorithm

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29124

New line breaking algorithm

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 18:21 ---
Luca,

Patch applied. Thanks for this innovative and extensive contribution.

Still to be done:

- Resolve the regressions mentioned above.
- I support the idea to create an InlineLayoutManager interface, which
  extends LayoutManager.
- This patch has made a lot of existing code redundant. Much of that
  code is still present. To keep the code clean and intelligible, the
  redundant pieces should be removed at some time by somebody.

I have added a space after casts. See the style guidelines in the file
dev/conventions.html of the FOP web site.

I have a few remarks about the code. I leave it to you to follow these
up or not, but I would like to see point 1 addressed:

1. In TextLM:
// linefeed; this can happen when linefeed-treatment="preserve"
// the linefeed character is the first one in textArray,
// so we can just return a list with a penalty item

In LineLM:
if (returnedList.size() > 1
|| !(thisElement.isPenalty() && ((KnuthPenalty)thisElement).getP() ==
-KnuthElement.INFINITE)) {
} else {
// a list with a single penalty item whose value is -inf
// represents a preserved linefeed, wich forces a line break

Can we be sure that U+A is always alone or the first item in a
textArray; does this not depend on the Parser, how it calls the SAX
characters method?

2. In InlineStackingLM.applyChanges: Falling over the end of
oldListIterator can be done better: treat only currLM != prevLM in the
loop, treat !oldListIterator.hasNext() after the loop. Same for
getChangedKnuthElements? :

while(oldListIterator.hasNext()) {
oldElement = (KnuthElement)oldListIterator.next();
currLM = oldElement.getLayoutManager();
// initialize prevLM
if (prevLM == null) {
prevLM = currLM;
}

if (currLM != prevLM) {
bSomethingChanged = prevLM.applyChanges(oldList.subList(fromIndex,
oldListIterator.previousIndex()))
|| bSomethingChanged;
prevLM = currLM;
fromIndex = oldListIterator.previousIndex();
}
}
bSomethingChanged = currLM.applyChanges(oldList.subList(fromIndex, oldList.size()))
|| bSomethingChanged;

Possible cases, after the loop:
xxyy or yy, xx done
prevLM = currLM = y
fromIndex = last done (2 and 0)

3. In InlineStackingLM: Unnecessary differences between treatment of
returnedList and returnList in getNextKnuthElements and
getChangedKnuthElements. In getChangedKnuthElements it is not
necessary to have a separate returnedList and returnList.

4. Break up long methods in LineLM: findHyphenationPoints,
getNextBreakPoss, considerLegalBreak (?), findBreakingPoints (?).

Regards, Simon

DO NOT REPLY [Bug 31063] New: - "id already in this document" error with no duplicate id

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31063

"id already in this document" error with no duplicate id

   Summary: "id already in this document" error with no duplicate id
   Product: Fop
   Version: 0.20.5
  Platform: PC
   URL: http://tigreraye.org/essai.fo
http://tigreraye.org/essai.xml
OS/Version: Linux
Status: NEW
  Severity: Normal
  Priority: Other
 Component: general
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I am using FOP to produce PDF or PS documents (from a DocBook XML
source converted to FO). For some specific documents, I always end up with the
following error:

[ERROR] file:/home/fevrier/essai.fo:48:206 The id "id2455426" already exists in
this document

I tried to build the FO file with both xsltproc and xalan, with the same
result each time.

The attached files are the minimal DocBook XML file I was able to make that
exhibit this issue and the corresponding FO file.

I am able to work around this issue by adding a blank paragraph (or two) before
the page break solve this issue.

It would seem that this problem happens when a QANDASET (DocBook XML) is over a
page border. However, since fop complains about a duplicate id in the file, and
no id is duplicated in the FO file, it would seem to be a FOP issue.

Thanks.

Bug report for Fop [2004/09/05]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|  635|Opn|Nor|2001-02-18|Doesn't support id= attribute in fo:page-sequence |
|  953|Opn|Nor|2001-03-12|Incorrect hyperlinks area rendering in justified t|
| 1063|New|Nor|2001-03-21|fop does not handle large fo files|
| 1180|New|Maj|2001-04-02|Problem with monospaced font  |
| 1859|Opn|Min|2001-05-22|org.apache.fop.apps.Driver.reset() doesn't fully r|
| 1998|New|Nor|2001-06-05|linefeed-treatment not understood |
| 2150|Ass|Maj|2001-06-13|New page with  a table-header but without any tabl|
| 2475|Ass|Nor|2001-07-06|Borders don't appear to work in |
| 2740|New|Maj|2001-07-23|multi-page tables sometimes render badly  |
| 2909|New|Maj|2001-07-30|Gradient render error |
| 2964|Ass|Nor|2001-08-02|problems with height of cells in tables   |
| 2988|New|Maj|2001-08-03|0.19: list-item-label does not stick to list-item-|
| 3044|Ass|Maj|2001-08-08|keep-together not functioning |
| 3280|New|Nor|2001-08-27|PCL Renderer doesn't work |
| 3305|Opn|Nor|2001-08-28|list-block overlapping footnote body  |
| 3497|New|Maj|2001-09-07|id already exists error when using span="all" attr|
| 3824|New|Blk|2001-09-25|MIF option with tables|
| 4030|New|Nor|2001-10-08|IOException creating Postscript with graphics on S|
| 4126|New|Nor|2001-10-12|FontState.width() returns pts instead of millipts |
| 4226|New|Nor|2001-10-17|The orphans property doesn't seem to work |
| 4388|New|Nor|2001-10-24|Nullpointer exception in the construction of new D|
| 4415|New|Nor|2001-10-25|scaling="uniform" does not work on images...  |
| 4510|New|Nor|2001-10-30|fo:inline common properties ignored?  |
| 4535|New|Maj|2001-10-31|PCL renderer 1.13 not rendering SVG   |
| 4767|New|Nor|2001-11-09|SVG text is distored in PDF output|
| 5001|New|Nor|2001-11-21|content-width and content-height ignored? |
| 5010|New|Enh|2001-11-21|Better error reporting needed |
| 5124|New|Maj|2001-11-27|fo:block-container is not rendered properly using |
| 5335|Opn|Min|2001-12-10|Text with embedded CID fonts not retrievable from |
| 5655|Ass|Nor|2002-01-02|text-decoration cannot take multiple values   |
| 6094|Opn|Maj|2002-01-29|0.20.3rc hangs in endless loop|
| 6237|Opn|Nor|2002-02-05|fi (fi ligature) produces a "sharp"? |
| 6305|New|Nor|2002-02-07|Using fo:table-and-caption results in empty output|
| 6427|New|Enh|2002-02-13|Adding additional Type 1 fonts problem|
| 6437|New|Maj|2002-02-13|Tables without fo:table-column don't render   |
| 6483|New|Nor|2002-02-15|Table, Loop, "footer could not fit on page, moving|
| 6844|New|Nor|2002-03-04|No line breaks inserted in list-item-label|
| 6918|New|Enh|2002-03-06|reference-orientation has no effect   |
| 6997|New|Nor|2002-03-09|[PATCH] Row-spanned row data breaks over a page wi|
| 7140|New|Enh|2002-03-15|page-position attribute set to "last" on condition|
| 7241|New|Nor|2002-03-19|keep-with-previous, keep-with-next only working on|
| 7283|New|Nor|2002-03-20|Table border misaligned when using margin-left in |
| 7337|New|Nor|2002-03-21|border around external image leaves empty space   |
| 7487|New|Nor|2002-03-26|break-before="page" for table inserts empty page  |
| 7496|New|Nor|2002-03-26|The table header borders are not adjusted to the b|
| 7525|New|Cri|2002-03-27|table with spans inside a list-block  |
| 7919|New|Cri|2002-04-10|problem to use attribute linefeed-treatment and li|
| 8003|Ass|Maj|2002-04-12|FopImageFactory never releases cached images  |
| 8050|New|Nor|2002-04-13|Soft hyphen (­) is not handled properly   |
| 8321|New|Nor|2002-04-19|from-parent('width') returns 0 for nested tables  |
| 8463|New|Nor|2002-04-24|SVG clipping in external.fo example doc when rende|
| 8767|Ass|Min|2002-05-03|Image

remove layout package?

[Glen Mazza]

Team,

With the recent removal (who did that? ;) of the
unused layout.AreaClass and layout.TextState classes,
the fop.layout package is now empty save for its
hyphenation subpackage.

I'd like to drop the layout package and make
hyphenation a top-level package (i.e.,
org.apache.fop.hyphenation).  Comments?

As a newbie last year, having both a layout and a
layoutmgr package was confusing [1]--so another
benefit for this change is to eliminate confusion for
people just starting to look at the code.

Thanks,
Glen

[1]
http://marc.theaimsgroup.com/?l=fop-dev&m=105660878214898&w=2