Re: A performance patch for PDFInfo class
ok, sorry for the disturbance. Laszlo Hornyak ps: StringBuffering code: time for test: 45479 String += code: time for test: 52011 difference: 14.36% java version "1.4.1_01" Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.1_01-b01) Java HotSpot(TM) Client VM (build 1.4.1_01-b01, mixed mode) On Tue, Nov 12, 2002 at 09:13:36AM +0100, Keiron Liddle wrote: > On Mon, 2002-11-11 at 23:44, Kevin O'Neill wrote: > > Like anybody else there are times when I optimize as I go, but I really > > try and keep in mind, "is this the simplest thing I could do?" Fighting > > the urge to apply "optimizations" as you go is hard sometimes but in my > > experience leads to a better code base. > > This is the most important statement IMO. > Especially with Fop, if it is not simple there we are going to dig > ourselves into a hole. > Things are complicated enough without making convoluted and confusing > optimisations. > > Keep parts simple and have a well defined contract between parts. > > Keiron. > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Re: patches (part III)
I think it is done.
Laszlo
On Mon, Nov 11, 2002 at 02:06:47PM +0100, Jeremias Maerki wrote:
> For patches, it would be best if you submitted the patch via bugzilla
> with a "[PATCH]" prefix in the title. That way patches don't get lost
> that easily. Sorry, that it's not yet properly documented that way.
> You'll find bugzilla here: http://nagoya.apache.org/bugzilla/
>
> Thanks.
>
> On Mon, 11 Nov 2002 14:00:04 +0100 Laszlo Hornyak wrote:
> > Hi all!
> >
> > I sent some days before a small patch to the mailing list, and I would like to
>send more, if you accept it.
> > I realized that the list ignored my previous mails (without any warning), so I
>subscribed to the list. The fop site ("Contributing code, trest...") doesn`t mention
>that it is required...
> > Should I resend the file?
>
>
> Jeremias Maerki
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, email: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
patches (part III)
Hi all!
I sent some days before a small patch to the mailing list, and I would like to send
more, if you accept it.
I realized that the list ignored my previous mails (without any warning), so I
subscribed to the list. The fop site ("Contributing code, trest...") doesn`t mention
that it is required...
Should I resend the file?
thanks,
Laszlo Hornyak
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
