Re: Cannot build with JDK 1.3
On Aug 17, 2007, at 18:33, Adrian Cumiskey wrote: Hi Adrian, Please review/try out the patch I just submitted (http:// issues.apache.org/bugzilla/show_bug.cgi?id=43156) and let me know if it fixes the MethodNotFoundError(s) on your ant junit target on the fop-0_94 branch when using jdk1.3. Although the patch solves this particular problem, I'm still wondering why we should alter our codebase to ensure compatibility with buggy JDK 1.3 implementations. I remember moving ColumnNumberPropertyMaker myself as an inner class, since it's small, does not apply to anything other than table-related FOs and so the related methods in the fo.flow package didn't have to become part of the public API (getCurrentColumnIndex() and the like). Apparently, either this is the first time anyone even tried building the trunk code with JDK 1.3 or some have already done that and didn't run into trouble, else we would have heard about this sooner. Maybe it's OK to leave this patch in existence for those foppers that need 1.3 compatibility, instead of applying it to the trunk. No veto, just something to think about. I mean, it's not as if discontinuing support for 1.3 is not the intention in the long run, so... Cheers Andreas
Re: Cannot build with JDK 1.3
Adrian Cumiskey schrieb: Guys, Please review/try out the patch I just submitted (http://issues.apache.org/bugzilla/show_bug.cgi?id=43156) and let me know if it fixes the MethodNotFoundError(s) on your ant junit target on the fop-0_94 branch when using jdk1.3. Yes, the junit target executes now without errors - well done! (But I don't have time to look at the patch now) Christian
Re: Cannot build with JDK 1.3
Vincent Hennebert schrieb: Hi Christian, Christian Geisert a écrit : Vincent Hennebert schrieb: [..] I don’t think we can wait any longer before releasing. So I’ll prepare Why? 1. because we’ve been talking about that 0.94 release for more than a month now, and it’s about time to actually do it; 2. because I’m taking vacation in one week or so and, although I’ll still be online, I’d like that to be handled before... Isn’t that a good reason? ;-) More than good enough ;-) It’s not that I don’t agree with you, quite on the contrary ;-). But, besides the fact that we didn’t vote on dropping 1.3 support, Jeremias wanted a poll to be launched on fop-user to gather user opinions. I can understand that, and damn me for having forgotten to launch it in the past months, but for now it’s preferable to provide a 1.3 build if we We'll do it immediately after the release ;-) can manage. Looks good, I just did a quick test with Adrian's patch. Christian
Re: Cannot build with JDK 1.3
Hi Andreas, Thanks for chiming in! That’s exactly the comment I was needing :-) Andreas L Delmelle a écrit : On Aug 17, 2007, at 18:33, Adrian Cumiskey wrote: Hi Adrian, Please review/try out the patch I just submitted (http://issues.apache.org/bugzilla/show_bug.cgi?id=43156) and let me know if it fixes the MethodNotFoundError(s) on your ant junit target on the fop-0_94 branch when using jdk1.3. Although the patch solves this particular problem, I'm still wondering why we should alter our codebase to ensure compatibility with buggy JDK 1.3 implementations. I remember moving ColumnNumberPropertyMaker myself as an inner class, since it's small, does not apply to anything other than table-related FOs and so the related methods in the fo.flow package didn't have to become part of the public API (getCurrentColumnIndex() and the like). Yes that striked my eye and I was wondering if that was a good thing. Apparently not. However, this doesn’t mean that the patch is useless. I’ll apply it to the 0.94 branch to be able to produce a 1.3 build. I won’t merge it into the Trunk since we will very probably drop 1.3 support after the release and the code is cleaner as is. So, many thanks Adrian for your patch. The last remaining problem is a testcase about PDF encoding which doesn’t pass (nothing excepted the starting “%PDF-1.4” string is output), but since I get a visually normal result when running it by hand I’ll disable it in the branch. Apparently, either this is the first time anyone even tried building the trunk code with JDK 1.3 or some have already done that and didn't run into trouble, else we would have heard about this sooner. Maybe it's OK to leave this patch in existence for those foppers that need 1.3 compatibility, instead of applying it to the trunk. No veto, just something to think about. I mean, it's not as if discontinuing support for 1.3 is not the intention in the long run, so... I’ll guess you’ll be happy with my proposal? ;-) Thanks everyone, Vincent
Re: Cannot build with JDK 1.3
Hi all, I believe it was the introduction of the property getInstance() refactoring which inadvertently introduced this incompatibility. I say this because all 1.3 because the unit tests all pass fine with 0.93. I totally agree with and understand your thinking on this Andreas, but on balance I think this minor change/patch is a quite a small price to pay for continued 1.3compatibility. Adrian.
[VOTE] Release FOP 0.94
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I’d like to launch a vote for releasing version 0.94 of Apache FOP. The candidate distribution files were created from the following tag: https://svn.apache.org/repos/asf/xmlgraphics/fop/tags/fop-0_94/ They may be found on the following page: http://people.apache.org/~vhennebert/ They are signed with the same PGP key as the one which is used for this message. The MD5 sums are: c3abb854014c080fb3052dc805ae5a5e fop-0.94-src.zip f9544efe8130f8b3b65940e88ae0fe27 fop-0.94-src.tar.gz eebe11409fc31194c554911d8cf3cd5e fop-0.94-bin-jdk1.3.zip 64174d9eb3972138cfc68e2bb46ad9c8 fop-0.94-bin-jdk1.3.tar.gz 31a4bc9fa2e02a5f4ee412d936dbb81f fop-0.94-bin-jdk1.4.zip aa3c197c1b8133bbcc23104f27638023 fop-0.94-bin-jdk1.4.tar.gz The SHA sums are (can be checked using ‘openssl sha’): ad61931b9b5a8debe53ffc50dcf4755144216b04 fop-0.94-src.zip e0e073a421df8cc59cf1980ed0e9fb77f2c4931d fop-0.94-src.tar.gz 609827c0bdcfe9edd37d3f21edaf34976e1b2810 fop-0.94-bin-jdk1.3.zip 71ab946ea2f35a6d157e16713038b6bfa9ac7307 fop-0.94-bin-jdk1.3.tar.gz ad898b93c43e698113e232878bed9e52f00dbf4e fop-0.94-bin-jdk1.4.zip e970aa2d52ab3a50128b16372cbfbce63e900469 fop-0.94-bin-jdk1.4.tar.gz The new website can be checked at the following address: http://people.apache.org/~vhennebert/fop-0.94/index.html Given the importance of this release, I’d be grateful if as many people as possible could check that everything is OK. I’ll make the vote end on Thursay 23rd August, 12:00 CEST (10:00 UTC). Votes only on general@ please. Thanks, Vincent Hennebert -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGx0CNoHLU0ENYxYQRAmdxAJ4wKmLu5QmLXdUp1MZ030b6eRuQZwCdFeF7 Ra8LEgzj03+tc17bXZooHbU= =mz5V -END PGP SIGNATURE-
DO NOT REPLY [Bug 43156] - [PATCH] jdk1.3 compatibility fix for fop-0_94
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43156. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43156 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2007-08-18 12:06 --- Patch applied to the 0.94 branch. Thanks Adrian! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
