[jira] [Commented] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Glenn Adams (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579685#comment-13579685
 ] 

Glenn Adams commented on FOP-2213:
--

As Luis says, see also TextLayoutManager#processWordMapping, especially:


// 4. compute glyph position adjustments on (substituted) characters

 
int[][] gpa;
if ( font.performsPositioning() ) {
// handle GPOS adjustments  

 
gpa = font.performPositioning ( mcs, script, language );
} else if ( font.hasKerning() ) {
// handle standard (non-GPOS) kerning adjustments   

 
gpa = getKerningAdjustments ( mcs, font );
} else {
gpa = null;
}

font.performsPositioning() when CS is enabled and the font contains at least 
one GPOS subtable in the GPOS table; if some GPOS subtable applies, then the CS 
path assumes that the font designer will include a subtable mapped to the 
'kern' feature [1]

[1] http://www.microsoft.com/typography/otspec/features_ko.htm#kern

it is up the font designer to program the GPOS feature table to contain the 
desired subtables

i also notice the following warning under then non-GPOS (older) 'kern' table 
(do not confuse this with the 'kern' feature of the GPOS table) [2]:

OpenType™ fonts containing CFF outlines are not supported by the 'kern' table 
and must use the 'GPOS' OpenType Layout table.

[2] http://www.microsoft.com/typography/otspec/kern.htm

what I suspect is happening in the current case is that the font author 
includes some GPOS table (but not one containing a subtable mapped to the 
'kern' feature) and also includes a 'kern' table;

i wonder if there is a newer version of the font that fixes this

> Kerning is no longer applied
> 
>
> Key: FOP-2213
> URL: https://issues.apache.org/jira/browse/FOP-2213
> Project: Fop
>  Issue Type: Bug
>  Components: fonts
>Affects Versions: 1.1, trunk
>Reporter: Vincent Hennebert
> Attachments: fop.xconf, kerning_1.0.pdf, kerning_1.1.pdf, kerning.fo, 
> kerning-v2_1.1-cs.pdf, kerning-v2_1.1-nocs.pdf, kerning-v2.fo
>
>
> See attached example. With FOP 1.0 the dot can be seen 'inside' the Y glyph 
> as expected, while it's not the case with FOP 1.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Luis Bernardo (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luis Bernardo updated FOP-2213:
---

Attachment: kerning-v2_1.1-cs.pdf
kerning-v2_1.1-nocs.pdf
kerning-v2.fo

The attached example (kerning-v2.fo) uses the Arial font (font not provided) 
side to side with DejaVu. Since with Arial the kerning seems to be the same 
with or without CS the issue may be with the lack of a GPOS table in the DejaVu 
font.

> Kerning is no longer applied
> 
>
> Key: FOP-2213
> URL: https://issues.apache.org/jira/browse/FOP-2213
> Project: Fop
>  Issue Type: Bug
>  Components: fonts
>Affects Versions: 1.1, trunk
>Reporter: Vincent Hennebert
> Attachments: fop.xconf, kerning_1.0.pdf, kerning_1.1.pdf, kerning.fo, 
> kerning-v2_1.1-cs.pdf, kerning-v2_1.1-nocs.pdf, kerning-v2.fo
>
>
> See attached example. With FOP 1.0 the dot can be seen 'inside' the Y glyph 
> as expected, while it's not the case with FOP 1.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Luis Bernardo (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579610#comment-13579610
 ] 

Luis Bernardo commented on FOP-2213:


In FOP-1.1 we get the right (i.e., the same as in 1.0) kerning with -nocs (CS 
are enabled by default). If CS are enabled then glyph positioning uses the GPOS 
tables if they are available. There is no guarantee that the positioning will 
match the old kerning although one would expect it to be so (at least similar). 
This needs further investigation.

> Kerning is no longer applied
> 
>
> Key: FOP-2213
> URL: https://issues.apache.org/jira/browse/FOP-2213
> Project: Fop
>  Issue Type: Bug
>  Components: fonts
>Affects Versions: 1.1, trunk
>Reporter: Vincent Hennebert
> Attachments: fop.xconf, kerning_1.0.pdf, kerning_1.1.pdf, kerning.fo
>
>
> See attached example. With FOP 1.0 the dot can be seen 'inside' the Y glyph 
> as expected, while it's not the case with FOP 1.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Comment Edited] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Luis Bernardo (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579610#comment-13579610
 ] 

Luis Bernardo edited comment on FOP-2213 at 2/15/13 11:59 PM:
--

In FOP 1.1 we get the right (i.e., the same as in 1.0) kerning with -nocs (CS 
are enabled by default). If CS are enabled then glyph positioning uses the GPOS 
tables if they are available. There is no guarantee that the positioning will 
match the old kerning although one would expect it to be so (at least similar). 
This needs further investigation.

  was (Author: lmpmbernardo):
In FOP-1.1 we get the right (i.e., the same as in 1.0) kerning with -nocs 
(CS are enabled by default). If CS are enabled then glyph positioning uses the 
GPOS tables if they are available. There is no guarantee that the positioning 
will match the old kerning although one would expect it to be so (at least 
similar). This needs further investigation.
  
> Kerning is no longer applied
> 
>
> Key: FOP-2213
> URL: https://issues.apache.org/jira/browse/FOP-2213
> Project: Fop
>  Issue Type: Bug
>  Components: fonts
>Affects Versions: 1.1, trunk
>Reporter: Vincent Hennebert
> Attachments: fop.xconf, kerning_1.0.pdf, kerning_1.1.pdf, kerning.fo
>
>
> See attached example. With FOP 1.0 the dot can be seen 'inside' the Y glyph 
> as expected, while it's not the case with FOP 1.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Vincent Hennebert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vincent Hennebert updated FOP-2213:
---

Attachment: kerning_1.1.pdf
kerning_1.0.pdf
fop.xconf
kerning.fo

Sample FO file, fop.xconf (referring to the DejaVu LGC Serif font available in 
test/resources/fonts/ttf).
Correct output produced by FOP 1.0.
Incorrect output produced by FOP 1.1.

> Kerning is no longer applied
> 
>
> Key: FOP-2213
> URL: https://issues.apache.org/jira/browse/FOP-2213
> Project: Fop
>  Issue Type: Bug
>  Components: fonts
>Affects Versions: 1.1, trunk
>Reporter: Vincent Hennebert
> Attachments: fop.xconf, kerning_1.0.pdf, kerning_1.1.pdf, kerning.fo
>
>
> See attached example. With FOP 1.0 the dot can be seen 'inside' the Y glyph 
> as expected, while it's not the case with FOP 1.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2213:
--

 Summary: Kerning is no longer applied
 Key: FOP-2213
 URL: https://issues.apache.org/jira/browse/FOP-2213
 Project: Fop
  Issue Type: Bug
  Components: fonts
Affects Versions: 1.1, trunk
Reporter: Vincent Hennebert


See attached example. With FOP 1.0 the dot can be seen 'inside' the Y glyph as 
expected, while it's not the case with FOP 1.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (FOP-2212) o.a.f.fonts.Font.getKernValue should take glyph indices and not characters as parameters

2013-02-15 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2212:
--

 Summary: o.a.f.fonts.Font.getKernValue should take glyph indices 
and not characters as parameters
 Key: FOP-2212
 URL: https://issues.apache.org/jira/browse/FOP-2212
 Project: Fop
  Issue Type: Bug
  Components: fonts
Reporter: Vincent Hennebert


Kerning is intrinsic to glyphs and not characters. One character may be mapped 
to several different glyphs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (FOP-2210) [PATCH] Complex script IF to output missing glyphs

2013-02-15 Thread simon steiner (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

simon steiner updated FOP-2210:
---

Attachment: (was: cs11.patch)

> [PATCH] Complex script IF to output missing glyphs
> --
>
> Key: FOP-2210
> URL: https://issues.apache.org/jira/browse/FOP-2210
> Project: Fop
>  Issue Type: Bug
>Reporter: simon steiner
> Attachments: csspeedtrunk.patch, fop.xconf, test.fo
>
>
> fop test.fo -c fop.xconf -if application/pdf expected.if.xml
> fop -c fop.xconf -ifin expected.if.xml out.pdf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (FOP-2210) [PATCH] Complex script IF to output missing glyphs

2013-02-15 Thread simon steiner (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

simon steiner updated FOP-2210:
---

Attachment: csspeedtrunk.patch

> [PATCH] Complex script IF to output missing glyphs
> --
>
> Key: FOP-2210
> URL: https://issues.apache.org/jira/browse/FOP-2210
> Project: Fop
>  Issue Type: Bug
>Reporter: simon steiner
> Attachments: csspeedtrunk.patch, fop.xconf, test.fo
>
>
> fop test.fo -c fop.xconf -if application/pdf expected.if.xml
> fop -c fop.xconf -ifin expected.if.xml out.pdf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira