Re: Removing Checkstyle HTML Output [was: svn commit: r1551634 - /xmlgraphics/fop/trunk/build.xml]
Actually, perhaps you could just add a second target that creates the HTML
output, or define a boolean ANT property that I could set in my local
properties that I could set to generate.
On Fri, Dec 20, 2013 at 1:21 PM, Glenn Adams gl...@skynav.com wrote:
I always use the HTML version, so please re-enable.
On Tue, Dec 17, 2013 at 10:20 AM, Vincent Hennebert
vhenneb...@gmail.comwrote:
Hi,
I have personally never used the HTML output of Checkstyle as I find it
of very little use. It lists each and every file it checked along with
the number of errors in that file. That makes it virtually impossible to
find those files that have a non-zero number of errors, as they are lost
in an ‘ocean’ of non-erroneous files.
As I wanted to have Gump run Checkstyle, I needed to simplify the task
and the easiest was to remove the reference to the XSLT stylesheet that
creates the HTML out of the XML output.
If anybody feels that they would miss that feature, please let me know
and I’ll try and re-enable it in a separate target.
Thanks,
Vincent
On 17/12/13 18:11, vhennebert wrote:
Author: vhennebert
Date: Tue Dec 17 17:11:56 2013
New Revision: 1551634
URL: http://svn.apache.org/r1551634
Log:
Have Gump run Checkstyle on the source code
Removed HTML output for easier integration with Gump
Modified:
xmlgraphics/fop/trunk/build.xml
Modified: xmlgraphics/fop/trunk/build.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/build.
xml?rev=1551634r1=1551633r2=1551634view=diff
==
--- xmlgraphics/fop/trunk/build.xml (original)
+++ xmlgraphics/fop/trunk/build.xml Tue Dec 17 17:11:56 2013
@@ -1042,10 +1042,8 @@ NOTE:
!-- Checkstyle
--
!-- ===
--
property name=checkstyle.location
value=${lib-tools}/checkstyle-5.5-all.jar
/
- property name=checkstyle.noframes.xslt
value=${basedir}/checkstyle-noframes.xsl /
property name=checkstyle.config value=${basedir}/checkstyle-5.5.xml
/
path id=checkstyle-classpath
-path refid=libs-build-classpath/
pathelement location=${checkstyle.location}/
/path
condition property=checkstyle.avail
@@ -1053,14 +1051,12 @@ NOTE:
available classname=com.puppycrawl.tools.checkstyle.
CheckStyleTask
classpath refid=checkstyle-classpath/
/available
- available file=${checkstyle.noframes.xslt}/
available file=${checkstyle.config}/
/and
/condition
target name=checkstyle-avail unless=checkstyle.avail
echo message=Checkstyle support NOT present. Please download it
from http://checkstyle.sf.net/ and/
echo message=... please provide ${checkstyle.location}/
-echo message=... please provide ${checkstyle.noframes.xslt}/
echo message=... please provide ${checkstyle.config}/
/target
target name=checkstyle depends=package, checkstyle-avail
if=checkstyle.avail description=Runs Checkstyle for a code quality
report
@@ -1077,7 +1073,6 @@ NOTE:
fileset dir=${test.dir} includes=**/*.java/
formatter type=xml toFile=${build.dir}/report_
checkstyle.xml/
/checkstyle
-xslt in=${build.dir}/report_checkstyle.xml
out=${build.dir}/report_checkstyle.html style=${checkstyle.noframes.
xslt}/
/target
!-- ===
--
!-- PMD
--
@@ -1508,7 +1503,7 @@ NOTE:
!-- Special target for Gump
--
!-- ===
--
target name=gump depends=package,transcoder-pkg/
- target name=gump-test depends=junit-all
+ target name=gump-test depends=junit-all,checkstyle
fail
condition
or
[GUMP@vmgump]: Project xml-fop-test (in module xml-fop) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project xml-fop-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 16 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - xml-fop-test : XSL-FO (Formatting Objects) processor Full details are available at: http://vmgump.apache.org/gump/public/xml-fop/xml-fop-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.location. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/xml-fop/build/test-reports The following work was performed: http://vmgump.apache.org/gump/public/xml-fop/xml-fop-test/gump_work/build_xml-fop_xml-fop-test.html Work Name: build_xml-fop_xml-fop-test (Type: Build) Work ended in a state of : Failed Elapsed: 3 mins 31 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dant.build.clonevm=true -Xbootclasspath/p:/srv/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar:/srv/gump/public/workspace/xml-xalan/build/serializer.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.location=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar gump-test [Working Directory: /srv/gump/public/workspace/xml-fop] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/xml-fop/build/classes:/srv/gump/public/workspace/xml-fop/build/codegen-classes:/srv/gump/public/workspace/xml-fop/build/test-classes:/srv/gump/public/workspace/xml-fop/lib/build/asm-3.1.jar:/srv/gump/public/workspace/xml-fop/lib/build/mockito-core-1.8.5.jar:/srv/gump/public/workspace/xml-fop/lib/build/qdox-1.12.jar:/srv/gump/public/workspace/xml-fop/lib/fontbox-1.8.3-patched.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20131222.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons -logging-20131222.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20131222.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20131222.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-16.0-SNAPSHOT.jar:/srv/gump/public/workspace/xml-fop/build/fop.jar:/srv/gump/public/workspace/xml-fop/build/fop-sandbox.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/apache-attic/avalon-framework-api-4.3.jar:/srv/gump/packages/apache-attic/aval on-framework-impl-4.3.jar:/srv/gump/public/workspace/apache-commons/io/target/commons-io-2.5-SNAPSHOT.jar:/srv/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/batik-slideshow.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/batik-svgpp.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-anim.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-awt-util.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-bridge.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-codec.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-css.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-dom.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-ext.jar:/srv/gump/public/workspace/xml-batik/batik-20131222/lib/batik-extension.jar:/srv/gump/
