[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2017-04-05 Thread Matthias Reischenbacher (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957197#comment-15957197
 ] 

Matthias Reischenbacher commented on FOP-2536:
--

[~segadora], you might try the other patch: fop-2434-alternative.patch and set 
the following config option:
userAgent.getRendererOptions().put("overpaint-table-borders", Boolean.TRUE);

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FOP-2434) Varying table border thickness in PDF output

2017-04-05 Thread Christoffer Nielsen (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956680#comment-15956680
 ] 

Christoffer Nielsen commented on FOP-2434:
--

[~cbowditch] I might have it worked around by creating 3 tables, 1 for header, 
1 for body and 1 for footer.
I increased the border size to 2pt, but the varying thickness was still clearly 
visible. The other effect was the design looked worse after the borders were 
bigger.

I clearly understand its a limitation in Acrobat, but if it was possible to fix 
in fop in a manner which did not require a very large amount of work, then I 
hope you will reconsider later.

Alternatively it might also fix the issue not to use tables, but inline-blocks 
instead.

- With my previous comment I just wanted to clear out, that the bug was not 
only due to colspan.

> Varying table border thickness in PDF output
> 
>
> Key: FOP-2434
> URL: https://issues.apache.org/jira/browse/FOP-2434
> Project: FOP
>  Issue Type: Bug
>  Components: documentation
>Reporter: Anthony
> Attachments: adobe_reader_100%.png, borderThicknessTest.fo, 
> borderThicknessTest_FOP2.0.pdf, simple-table.fo, simple-table.pdf, 
> simple-table.png
>
>
> Tables in my documentation vary in border thickness throughout my PDF output. 
> I have determined that it occurs when cells are spanned (across rows and 
> columns).
> I have attempted to fix stylesheets and Adobe settings, and nothing has 
> helped. 
> I use Oxygen XML Editor 16.1 with an Apache FOP processor.
> I am unable to attach any sample images or topic.fo file. By request, I will 
> send both.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FOP-2434) Varying table border thickness in PDF output

2017-04-05 Thread Chris Bowditch (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956664#comment-15956664
 ] 

Chris Bowditch commented on FOP-2434:
-

The tables may be simple, but you're applying a 1px border which is extremely 
thin. The resolution of the device will also have an impact on such a thin 
border specified in px units. Can't you increase the border to say 2pt so the 
issue is less noticeable? As previously stated this is not a priority for me 
since I see this as working around a limitation in Acrobat.

> Varying table border thickness in PDF output
> 
>
> Key: FOP-2434
> URL: https://issues.apache.org/jira/browse/FOP-2434
> Project: FOP
>  Issue Type: Bug
>  Components: documentation
>Reporter: Anthony
> Attachments: adobe_reader_100%.png, borderThicknessTest.fo, 
> borderThicknessTest_FOP2.0.pdf, simple-table.fo, simple-table.pdf, 
> simple-table.png
>
>
> Tables in my documentation vary in border thickness throughout my PDF output. 
> I have determined that it occurs when cells are spanned (across rows and 
> columns).
> I have attempted to fix stylesheets and Adobe settings, and nothing has 
> helped. 
> I use Oxygen XML Editor 16.1 with an Apache FOP processor.
> I am unable to attach any sample images or topic.fo file. By request, I will 
> send both.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (FOP-2434) Varying table border thickness in PDF output

2017-04-05 Thread Christoffer Nielsen (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956653#comment-15956653
 ] 

Christoffer Nielsen edited comment on FOP-2434 at 4/5/17 10:46 AM:
---

[~cbowditch] I am experiencing the problems with simple tables too, thats why I 
have a hard time understanding why it cant even be prioritised.

I tried to apply a patch for it, but unfortunately my java skills aint good 
enough and the patch made for this issue, didnt solve the issue for me.


was (Author: segadora):
[~cbowditch] I am experiencing the problems with simple tables too, thats why I 
have a hard time understanding why it cant even be prioritised.

I tried to apply a patch for it, but unfortunately my java skills aint good 
enough and the patch made for this issue, didnt solve the issue for me.

For now I suppose I can fix the issue by making 3 tables, 1 header, 1 body, 1 
footer.

> Varying table border thickness in PDF output
> 
>
> Key: FOP-2434
> URL: https://issues.apache.org/jira/browse/FOP-2434
> Project: FOP
>  Issue Type: Bug
>  Components: documentation
>Reporter: Anthony
> Attachments: adobe_reader_100%.png, borderThicknessTest.fo, 
> borderThicknessTest_FOP2.0.pdf, simple-table.fo, simple-table.pdf, 
> simple-table.png
>
>
> Tables in my documentation vary in border thickness throughout my PDF output. 
> I have determined that it occurs when cells are spanned (across rows and 
> columns).
> I have attempted to fix stylesheets and Adobe settings, and nothing has 
> helped. 
> I use Oxygen XML Editor 16.1 with an Apache FOP processor.
> I am unable to attach any sample images or topic.fo file. By request, I will 
> send both.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (FOP-2434) Varying table border thickness in PDF output

2017-04-05 Thread Christoffer Nielsen (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956653#comment-15956653
 ] 

Christoffer Nielsen edited comment on FOP-2434 at 4/5/17 10:45 AM:
---

[~cbowditch] I am experiencing the problems with simple tables too, thats why I 
have a hard time understanding why it cant even be prioritised.

I tried to apply a patch for it, but unfortunately my java skills aint good 
enough and the patch made for this issue, didnt solve the issue for me.

For now I suppose I can fix the issue by making 3 tables, 1 header, 1 body, 1 
footer.


was (Author: segadora):
Same issue without colspan

> Varying table border thickness in PDF output
> 
>
> Key: FOP-2434
> URL: https://issues.apache.org/jira/browse/FOP-2434
> Project: FOP
>  Issue Type: Bug
>  Components: documentation
>Reporter: Anthony
> Attachments: adobe_reader_100%.png, borderThicknessTest.fo, 
> borderThicknessTest_FOP2.0.pdf, simple-table.fo, simple-table.pdf, 
> simple-table.png
>
>
> Tables in my documentation vary in border thickness throughout my PDF output. 
> I have determined that it occurs when cells are spanned (across rows and 
> columns).
> I have attempted to fix stylesheets and Adobe settings, and nothing has 
> helped. 
> I use Oxygen XML Editor 16.1 with an Apache FOP processor.
> I am unable to attach any sample images or topic.fo file. By request, I will 
> send both.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (FOP-2434) Varying table border thickness in PDF output

2017-04-05 Thread Christoffer Nielsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christoffer Nielsen updated FOP-2434:
-
Attachment: simple-table.pdf
simple-table.fo
simple-table.png

Same issue without colspan

> Varying table border thickness in PDF output
> 
>
> Key: FOP-2434
> URL: https://issues.apache.org/jira/browse/FOP-2434
> Project: FOP
>  Issue Type: Bug
>  Components: documentation
>Reporter: Anthony
> Attachments: adobe_reader_100%.png, borderThicknessTest.fo, 
> borderThicknessTest_FOP2.0.pdf, simple-table.fo, simple-table.pdf, 
> simple-table.png
>
>
> Tables in my documentation vary in border thickness throughout my PDF output. 
> I have determined that it occurs when cells are spanned (across rows and 
> columns).
> I have attempted to fix stylesheets and Adobe settings, and nothing has 
> helped. 
> I use Oxygen XML Editor 16.1 with an Apache FOP processor.
> I am unable to attach any sample images or topic.fo file. By request, I will 
> send both.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2017-04-05 Thread Christoffer Nielsen (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956555#comment-15956555
 ] 

Christoffer Nielsen commented on FOP-2536:
--

[~martin.leit...@infinica.com] I tried the patch for fop 2.1, but the border is 
still varying in thickness and color with a black border at 1px.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)