[jira] [Updated] (FOP-2969) Accented Letters composed of Unicode base letter and combining accent are rendered wrong as the first letter of a word.

2020-10-03 Thread Volker Kunert (Jira)


 [ 
https://issues.apache.org/jira/browse/FOP-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Volker Kunert updated FOP-2969:
---
Component/s: font/opentype

> Accented Letters composed of Unicode base letter and combining accent are 
> rendered  wrong as the first letter of a word.
> 
>
> Key: FOP-2969
> URL: https://issues.apache.org/jira/browse/FOP-2969
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype, renderer/pdf
>Affects Versions: 2.5, 2.4, trunk
>Reporter: Volker Kunert
>Priority: Major
> Attachments: DefaultScriptProcessor.java, TestFop.java, 
> expected-din-spec-sequences.fo.pdf, fop.xconf, test-din-spec-sequences.fo, 
> test-din-spec-sequences.fo.pdf
>
>
> E.g. with 0041 030B LATIN CAPITAL LETTER A WITH COMBINING DOUBLE ACUTE ACCENT 
> the accent E.g. with 0041 030B LATIN CAPITAL LETTER A WITH COMBINING DOUBLE 
> ACUTE ACCENT the accent appears at the right hand side of the letter A, not 
> above the letter A.
> If e.g. an "X" is prepended, the sequence is rendered correctly.
> The tested sequences are used in the following specification:
> DIN SPEC 91379: Characters in Unicode for the electronic processing of names 
> and dataexchange in Europe; with digital attachment
> [https://www.xoev.de/downloads-2316#StringLatin]
> [https://www.din.de/de/wdc-beuth:din21:301228458]
> The output of FOP is provided in test-din-spec-sequences.fo.pdf, which is 
> created by running TestFop.java that processes test-din-spec-sequences.fo.  
> Font used for testing: NotoSansMono-Regular.ttf, see 
> [https://www.google.com/get/noto/] 
>  download: 
> [https://noto-website-2.storage.googleapis.com/pkgs/NotoSansMono-hinted.zip]
>  The following dirty patch seems to resolve the problem for my test case:
> (delete "{{&& (unscaledWidths[index] != 0").}}
>  
> {code:java}
> --- 
> ./trunk/fop-core/src/main/java/org/apache/fop/complexscripts/scripts/DefaultScriptProcessor.java
>  2020-09-03 16:20:03.442089088 +0200
> +++ 
> /home/volker/software/xmlgraphics-fop-trunk/fop-core/src/main/java/org/apache/fop/complexscripts/scripts/DefaultScriptProcessor.java
>  2020-09-03 16:37:40.781775907 +0200
> @@ -151,7 +151,7 @@
>      }      
> protected boolean isReorderedMark(GlyphDefinitionTable gdef, int[] glyphs, 
> int[] unscaledWidths, int index) {
> -        return gdef.isGlyphClass(glyphs[index], 
> GlyphDefinitionTable.GLYPH_CLASS_MARK) && (unscaledWidths[index] != 0);
> +        return gdef.isGlyphClass(glyphs[index], 
> GlyphDefinitionTable.GLYPH_CLASS_MARK);      
> {code}
> See also PDFBOX-4951



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FOP-2972) Incorrectly trim edges of svg figure when using 'auto'

2020-10-03 Thread Petter Reinholdtsen (Jira)


 [ 
https://issues.apache.org/jira/browse/FOP-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Petter Reinholdtsen updated FOP-2972:
-
Description: 
When using docbook to create a document with a SVG figure, the figure left and 
right edges are clipped.  The following script demonstrate the problem.  This 
problem was first reported to the docbook xslt project as issue #212.

 ```
 #!/bin/sh

cat > circles.svg <
 
 http://www.w3.org/2000/svg; width="12cm" height="12cm">
 
 
 
 
 
 
 EOF

cat > test.xml <
 http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;>
 
 ...
 
 ...
 ...
 
 A set of circles, should be perfectly round
 
 
 
 
 
 With fop the left and right edges are flat
 
 
 
 
 
 EOF

xsltproc --output test.fo 
/usr/share/xml/docbook/stylesheet/docbook-xsl/fo/docbook.xsl test.xml
 fop -fo test.fo -pdf test.pdf
 ```
  

See the docbook bug report above for an example rendering with the flat edges 
of the circles.

The relevant FO output look like this:

 ```

  

```

  was:
When using docbook to create a document with a SVG figure, the figure left and 
right edges are clipped.  The following script demonstrate the problem.  This 
problem was first reported to the docbook xslt project as issue #212.

 ```
 #!/bin/sh

cat > circles.svg <
 
 http://www.w3.org/2000/svg; width="12cm" height="12cm">
 
 
 
 
 
 
 EOF

cat > test.xml <
 http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;>
 
 ...
 
 ...
 ...
 
 A set of circles, should be perfectly round
 
 
 
 
 
 With fop the left and right edges are flat
 
 
 
 
 
 EOF

xsltproc --output test.fo 
/usr/share/xml/docbook/stylesheet/docbook-xsl/fo/docbook.xsl test.xml
 fop -fo test.fo -pdf test.pdf
 ```
  

See the docbook bug report above for an example rendering with the flat edges 
of the circles.


> Incorrectly trim edges of svg figure when using 'auto'
> --
>
> Key: FOP-2972
> URL: https://issues.apache.org/jira/browse/FOP-2972
> Project: FOP
>  Issue Type: Bug
>  Components: image/svg
>Affects Versions: 2.3
> Environment: Debian Buster
>Reporter: Petter Reinholdtsen
>Priority: Major
>  Labels: Debian
>
> When using docbook to create a document with a SVG figure, the figure left 
> and right edges are clipped.  The following script demonstrate the problem.  
> This problem was first reported to the docbook xslt project as issue #212.
>  ```
>  #!/bin/sh
> cat > circles.svg <  
>  
>  http://www.w3.org/2000/svg; width="12cm" height="12cm">
>  
>transform="translate(0,50)" />
>transform="translate(70,150)" />
>transform="translate(-70,150)"/>
>  
>  
>  EOF
> cat > test.xml <  
>"http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;>
>  
>  ...
>  
>  ...
>  ...
>  
>  A set of circles, should be perfectly round
>  
>  
>  
>  
>  
>  With fop the left and right edges are flat
>  
>  
>  
>  
>  
>  EOF
> xsltproc --output test.fo 
> /usr/share/xml/docbook/stylesheet/docbook-xsl/fo/docbook.xsl test.xml
>  fop -fo test.fo -pdf test.pdf
>  ```
>   
> See the docbook bug report above for an example rendering with the flat edges 
> of the circles.
> The relevant FO output look like this:
>  ```
> 
>  width="auto" 
>   height="auto"
>   content-width="auto"
>   content-height="auto" />
> 
> ```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2727) fo:float needs to be inside a block

2020-10-03 Thread Petter Reinholdtsen (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206621#comment-17206621
 ] 

Petter Reinholdtsen commented on FOP-2727:
--

For the record, I tested the example in 
[https://bugs.debian.org/867538|https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=867538]
 using fop 2.5, and the sidefloat was still missing in the PDF output.

> fo:float needs to be inside a block
> ---
>
> Key: FOP-2727
> URL: https://issues.apache.org/jira/browse/FOP-2727
> Project: FOP
>  Issue Type: Improvement
>  Components: fo/unqualified
>Affects Versions: 1.1, 2.0, 2.1
> Environment: Debian Jessie and Stretch.
>Reporter: Petter Reinholdtsen
>Priority: Minor
>
> Hi.  When trying to figure out how to make sure my docbook sidebars end up on 
> the side of the text, I tried following the instructions on  http://www.sagehill.net/docbookxsl/SideFloats.html > and wrote a simple 
> example docbook file to test floating sidebars.  This do not work and I get a 
> message about a missing feature.  Please add support for sidebars placed at 
> the side of the text body.
> When processing my example, I get this message and the sidebar has 
> disappeared from the resulting PDF:
> {noformat}
>  % xmlto --with-fop pdf db-sidebar-test.xml
>   Making portrait pages on letter paper (215.9mmx279.4mm)
>   Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
>   Font "ZapfDingbats,normal,700" not found. Substituting with
> "ZapfDingbats,normal,400".
>   Rendered page #1.
>   Couldn't find hyphenation pattern for lang="en".
>   Rendered page #2.
>   The following feature isn't implemented by Apache FOP, yet: fo:float (on
> fo:float) (No context info available)
>   No LayoutManager maker for class class org.apache.fop.fo.flow.Float
>   Rendered page #3.
>   Rendered page #4.
>   /tmp/user/1000/xmlto.xvMMIW
>   %
> {noformat}
> I tried using both fop 1.1 and 2.1, and both fail to create a PDF with a 
> sidebar.
> This is the example docbook file I use:
> {noformat}
> 
>  "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;>
> 
>   
> Test docbook sidebar
>   
>   
> Sidebar example
> 
>   Some text in front of the sidebar.
> 
>  
>   Sidebar example
>   
>   A sidebar
>   can be used to emphasize certain
>   content. It can intrude into
>   the body area, or it can
>   appear in side indents as 
>   a margin note.
> 
> Some text following the sidebar.
>   
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-1196) [PATCH] GSoC: floats implementation

2020-10-03 Thread Petter Reinholdtsen (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206620#comment-17206620
 ] 

Petter Reinholdtsen commented on FOP-1196:
--

For the record, I tested the example in 
[https://bugs.debian.org/867538|https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=867538]
 using fop 2.5, and the sidefloat was still missing in the PDF output.

> [PATCH] GSoC: floats implementation
> ---
>
> Key: FOP-1196
> URL: https://issues.apache.org/jira/browse/FOP-1196
> Project: FOP
>  Issue Type: Improvement
>  Components: layout/unqualified
>Affects Versions: 2.5
> Environment: Operating System: All
> Platform: All
>Reporter: Vincent Hennebert
>Priority: Major
>  Labels: PatchAvailable
> Attachments: patch.diff, patch2.diff, patchBeforeFloats-2.diff, 
> patchBeforeFloats.diff, patchDisabledTestcases.diff, patchTestcases.diff
>
>
> This patch isn't really meant to be applied... Rather to be reviewed by
> interested parties to check if I'm not wrong. Changelog:
> * javadocs for the Knuth line- and page-breaking algorithms. Some items are
> marked with double question marks because I haven't found out yet what is 
> their
> purpose. I will probably find eventually, but if anybody has immediate hints
> they will be welcome.
> * some methods have been marked deprecated because AFAICT they are not called
> anywhere. If this is agreed I'll remove them in my next patch
> * bugfix? In the last for loop of the method
> layoutmgr.PageBreakingAlgorithm.noBreakBetween I think the exit condition 
> should
> be a strict comparison ('<' instead of '<='). Confirmation?
> * the javadoc comments for some methods have been removed because they will
> inherit them from their super-class
> * some checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FOP-2972) Incorrectly trim edges of svg figure when using 'auto'

2020-10-03 Thread Petter Reinholdtsen (Jira)


 [ 
https://issues.apache.org/jira/browse/FOP-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Petter Reinholdtsen updated FOP-2972:
-
Summary: Incorrectly trim edges of svg figure when using 'auto'  (was: Trim 
edges of svg figure when using 'auto')

> Incorrectly trim edges of svg figure when using 'auto'
> --
>
> Key: FOP-2972
> URL: https://issues.apache.org/jira/browse/FOP-2972
> Project: FOP
>  Issue Type: Bug
>  Components: image/svg
>Affects Versions: 2.3
> Environment: Debian Buster
>Reporter: Petter Reinholdtsen
>Priority: Major
>  Labels: Debian
>
> When using docbook to create a document with a SVG figure, the figure left 
> and right edges are clipped.  The following script demonstrate the problem.  
> This problem was first reported to the docbook xslt project as issue #212.
>  ```
>  #!/bin/sh
> cat > circles.svg <  
>  
>  http://www.w3.org/2000/svg; width="12cm" height="12cm">
>  
>transform="translate(0,50)" />
>transform="translate(70,150)" />
>transform="translate(-70,150)"/>
>  
>  
>  EOF
> cat > test.xml <  
>"http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;>
>  
>  ...
>  
>  ...
>  ...
>  
>  A set of circles, should be perfectly round
>  
>  
>  
>  
>  
>  With fop the left and right edges are flat
>  
>  
>  
>  
>  
>  EOF
> xsltproc --output test.fo 
> /usr/share/xml/docbook/stylesheet/docbook-xsl/fo/docbook.xsl test.xml
>  fop -fo test.fo -pdf test.pdf
>  ```
>   
> See the docbook bug report above for an example rendering with the flat edges 
> of the circles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FOP-2972) Trim edges of svg figure when using 'auto'

2020-10-03 Thread Petter Reinholdtsen (Jira)
Petter Reinholdtsen created FOP-2972:


 Summary: Trim edges of svg figure when using 'auto'
 Key: FOP-2972
 URL: https://issues.apache.org/jira/browse/FOP-2972
 Project: FOP
  Issue Type: Bug
  Components: image/svg
Affects Versions: 2.3
 Environment: Debian Buster
Reporter: Petter Reinholdtsen


When using docbook to create a document with a SVG figure, the figure left and 
right edges are clipped.  The following script demonstrate the problem.  This 
problem was first reported to the docbook xslt project as issue #212.

 ```
 #!/bin/sh

cat > circles.svg <
 
 http://www.w3.org/2000/svg; width="12cm" height="12cm">
 
 
 
 
 
 
 EOF

cat > test.xml <
 http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;>
 
 ...
 
 ...
 ...
 
 A set of circles, should be perfectly round
 
 
 
 
 
 With fop the left and right edges are flat
 
 
 
 
 
 EOF

xsltproc --output test.fo 
/usr/share/xml/docbook/stylesheet/docbook-xsl/fo/docbook.xsl test.xml
 fop -fo test.fo -pdf test.pdf
 ```
  

See the docbook bug report above for an example rendering with the flat edges 
of the circles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)