Re: [GitHub] [xmlgraphics-fop-pdf-images] skynavga opened a new pull request, #9: Ignore testFloatCache() temporarily
Also, I would note that the underlying exception was there before updating junit to 4.13.1; however, it appeared that junit 4.10 was ignoring the exception rather than counting it as an error. On Fri, Mar 10, 2023 at 6:58 AM Glenn Adams wrote: > Yes. Note the term *temporarily*. > > On Fri, Mar 10, 2023 at 3:04 AM Simon Steiner > wrote: > >> Hi, >> >> Glenn can we fix these issues rather than skip tests. >> >> Thanks >> >> -Original Message- >> From: skynavga (via GitHub) >> Sent: 10 March 2023 04:45 >> To: fop-dev@xmlgraphics.apache.org >> Subject: [GitHub] [xmlgraphics-fop-pdf-images] skynavga opened a new pull >> request, #9: Ignore testFloatCache() temporarily >> >> >> skynavga opened a new pull request, #9: >> URL: https://github.com/apache/xmlgraphics-fop-pdf-images/pull/9 >> >>PDFWriterTestCase#testFloatCache is now recorded as error in junit >> 4.13.1; ignore (skip) temporarily. >> >> >> -- >> This is an automated message from the Apache Git Service. >> To respond to the message, please log on to GitHub and use the URL above >> to go to the specific comment. >> >> To unsubscribe, e-mail: fop-dev-unsubscr...@xmlgraphics.apache.org >> >> For queries about this service, please contact Infrastructure at: >> us...@infra.apache.org >> >> >>
Re: [GitHub] [xmlgraphics-fop-pdf-images] skynavga opened a new pull request, #9: Ignore testFloatCache() temporarily
Yes. Note the term *temporarily*. On Fri, Mar 10, 2023 at 3:04 AM Simon Steiner wrote: > Hi, > > Glenn can we fix these issues rather than skip tests. > > Thanks > > -Original Message- > From: skynavga (via GitHub) > Sent: 10 March 2023 04:45 > To: fop-dev@xmlgraphics.apache.org > Subject: [GitHub] [xmlgraphics-fop-pdf-images] skynavga opened a new pull > request, #9: Ignore testFloatCache() temporarily > > > skynavga opened a new pull request, #9: > URL: https://github.com/apache/xmlgraphics-fop-pdf-images/pull/9 > >PDFWriterTestCase#testFloatCache is now recorded as error in junit > 4.13.1; ignore (skip) temporarily. > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the URL above > to go to the specific comment. > > To unsubscribe, e-mail: fop-dev-unsubscr...@xmlgraphics.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > >
RE: [GitHub] [xmlgraphics-fop-pdf-images] skynavga opened a new pull request, #9: Ignore testFloatCache() temporarily
Hi, Glenn can we fix these issues rather than skip tests. Thanks -Original Message- From: skynavga (via GitHub) Sent: 10 March 2023 04:45 To: fop-dev@xmlgraphics.apache.org Subject: [GitHub] [xmlgraphics-fop-pdf-images] skynavga opened a new pull request, #9: Ignore testFloatCache() temporarily skynavga opened a new pull request, #9: URL: https://github.com/apache/xmlgraphics-fop-pdf-images/pull/9 PDFWriterTestCase#testFloatCache is now recorded as error in junit 4.13.1; ignore (skip) temporarily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: fop-dev-unsubscr...@xmlgraphics.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FOP-3098) [PATCH] Nullpointer Exception in LMiter.next depending on text
[ https://issues.apache.org/jira/browse/FOP-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698818#comment-17698818 ] Chris Bowditch commented on FOP-3098: - [~jeremias] long time no speak. Good to see you here :) Thanks for the patch and Unit test As others mentioned we recently moved FOP to Github, so you'll need to get setup there if you plan on still working with FOP. Might be idea to get it setup and commit this patch yourself. If you don't get the chance, I'll do it later if I get time > [PATCH] Nullpointer Exception in LMiter.next depending on text > -- > > Key: FOP-3098 > URL: https://issues.apache.org/jira/browse/FOP-3098 > Project: FOP > Issue Type: Bug > Components: fo/unqualified >Affects Versions: 2.7 > Environment: Windows 10 >Reporter: Michael Heitkamp >Assignee: Chris Bowditch >Priority: Major > Fix For: main > > Attachments: Post-FOP-3098-NPE-Bugfix.diff, patch.txt, > patch_cached.txt, stacktrace.txt, x-fop-error.xml, x-fop-error.xsl > > > Doing a FOP translation with the given XSL and XML input files lead to a > Nullpointer Exception. > If the text block is shortened by one character ("dataX" -> "data") then the > translation succeeds. > If the text block is replaced by "lore ipsum" of the same length then the > translation succeeds also. -- This message was sent by Atlassian Jira (v8.20.10#820010)