[jira] [Commented] (FOP-1722) [PATCH] Values in PDF Number Trees must be indirect references

2023-03-17 Thread Glenn Adams (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701798#comment-17701798
 ] 

Glenn Adams commented on FOP-1722:
--

LGTM [patch3.txt].

> [PATCH] Values in PDF Number Trees must be indirect references
> --
>
> Key: FOP-1722
> URL: https://issues.apache.org/jira/browse/FOP-1722
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: 2.5
> Environment: Operating System: All
> Platform: All
>Reporter: Vincent Hennebert
> Attachments: patch3.txt, text.fo, text.pdf
>
>
> See PDF Reference, Third Edition, Section 3.8.5, "Number Trees": the Nums 
> entry
> must be an array of key-value pairs where value is an indirect reference to 
> the
> object associated with the key.
> However, the o.a.f.pdf.PDFNumsArray class does nothing to ensure that elements
> added to the array are actually indirectly referenced. So generated PDFs are
> strictly speaking invalid.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FOP-1722) [PATCH] Values in PDF Number Trees must be indirect references

2023-03-17 Thread Simon Steiner (Jira)


 [ 
https://issues.apache.org/jira/browse/FOP-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Steiner updated FOP-1722:
---
Summary: [PATCH] Values in PDF Number Trees must be indirect references  
(was: Values in PDF Number Trees must be indirect references)

> [PATCH] Values in PDF Number Trees must be indirect references
> --
>
> Key: FOP-1722
> URL: https://issues.apache.org/jira/browse/FOP-1722
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: 2.5
> Environment: Operating System: All
> Platform: All
>Reporter: Vincent Hennebert
> Attachments: patch3.txt, text.fo, text.pdf
>
>
> See PDF Reference, Third Edition, Section 3.8.5, "Number Trees": the Nums 
> entry
> must be an array of key-value pairs where value is an indirect reference to 
> the
> object associated with the key.
> However, the o.a.f.pdf.PDFNumsArray class does nothing to ensure that elements
> added to the array are actually indirectly referenced. So generated PDFs are
> strictly speaking invalid.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FOP-1722) Values in PDF Number Trees must be indirect references

2023-03-17 Thread Dave Roxburgh (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701761#comment-17701761
 ] 

Dave Roxburgh commented on FOP-1722:


Attached patch resolves.

[^patch3.txt]

> Values in PDF Number Trees must be indirect references
> --
>
> Key: FOP-1722
> URL: https://issues.apache.org/jira/browse/FOP-1722
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: 2.5
> Environment: Operating System: All
> Platform: All
>Reporter: Vincent Hennebert
> Attachments: patch3.txt, text.fo, text.pdf
>
>
> See PDF Reference, Third Edition, Section 3.8.5, "Number Trees": the Nums 
> entry
> must be an array of key-value pairs where value is an indirect reference to 
> the
> object associated with the key.
> However, the o.a.f.pdf.PDFNumsArray class does nothing to ensure that elements
> added to the array are actually indirectly referenced. So generated PDFs are
> strictly speaking invalid.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FOP-1722) Values in PDF Number Trees must be indirect references

2023-03-17 Thread Dave Roxburgh (Jira)


 [ 
https://issues.apache.org/jira/browse/FOP-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Roxburgh updated FOP-1722:
---
Attachment: patch3.txt

> Values in PDF Number Trees must be indirect references
> --
>
> Key: FOP-1722
> URL: https://issues.apache.org/jira/browse/FOP-1722
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: 2.5
> Environment: Operating System: All
> Platform: All
>Reporter: Vincent Hennebert
> Attachments: patch3.txt, text.fo, text.pdf
>
>
> See PDF Reference, Third Edition, Section 3.8.5, "Number Trees": the Nums 
> entry
> must be an array of key-value pairs where value is an indirect reference to 
> the
> object associated with the key.
> However, the o.a.f.pdf.PDFNumsArray class does nothing to ensure that elements
> added to the array are actually indirectly referenced. So generated PDFs are
> strictly speaking invalid.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)