Re: rtf ignoring TableBody et al
> The warning is an indicator that there are still a few things in RTF > support that need fixing. So is there someone who owns this class? How long has it been out-of-sync - that is, is it in the same condition as TXTRenderer? Also, while this is probably not the correct forum for this question, what has been the reference tool for checking the RTF output? OpenOffice.org 2.0 beta won't even correctly render the SimpleTable from jfor. Since Word Viewer 2003 does, I'm inclined to think it's an OOo bug more than a jfor bug. However, I hope this he-said-she-said illustrates my correctness concern for the RTF output. -- /v\atthew
Re: rtf ignoring TableBody et al
> The least this would do is avoid a number of unnecessary calls to > instanceof. You're on the right track, and maybe that "switch" impl would be an 80/20 win over the cost of the Right Way. But that huge if-instance case is exactly what the Visitor pattern was created to solve. I haven't spent enough time with the Fop codebase to speak to the gains of such a thing, but I'd bet RTFHandler isn't the only one that does this. A braindead `grep instanceof | wc -l` search shows 122 classes out of the 640 classes use instanceof, which in my world makes them at least worth examination. Another "implied" win to the Visitor interface is if a new FONode type gets added, it forces the change to ripple (unless the impl is using the DefaultVisitor) to all those who would need to handle the new functionality. -- /v\atthew
rtf ignoring TableBody et al
I am using trunk code and with an input FO that produces excellent PDF output, I am seeing the following messages about lots of ignored instances. After checking RTFHandler.java, it seems they are omitted from the very large instance-switch in "invokeDeferredEvent". My question is if this is "in progress" code or if RTFHandler has been broken like this for a while? I tried to be clever and hack support for them back in, but it went very poorly. Thanks for your time, -- /v\atthew > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > Ignored deferred event for [EMAIL PROTECTED] > ... this continues for quite a while ...
