[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

--- Comment #5 from Mehdi Houshmand med1...@gmail.com ---
So I've been playing around with this this morning and with the junit-4.11
snapshot, it seems like all we need to do is change the @Parameters to
@Parameters(name = Test file = {0}). That seems to do the trick and
expresses the file name when a failure occurs.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

--- Comment #6 from Mehdi Houshmand med1...@gmail.com ---
Ohh and I did some perusing and my sleuthing skills suggest we shouldn't have
to wait to long for the 4.11 release. Looking at the 4.x release dates, they
seem to be releasing annually (or there abouts) and 4.10 was released 10months
ago... Watch out Columbo, there's a new kid in town.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

--- Comment #4 from Vincent Hennebert vhenneb...@gmail.com ---
(In reply to comment #3)
 Hmm...  I swear I replied to this this morning... Anyways, I have been
 looking into this periodically and hadn't found anything 'til today:
 
 https://github.com/KentBeck/junit/issues/44
 
 I don't have time to look into this at the moment, but I will look into it
 in the next week or so so watch this space.

It looks like a patch fixing the issue has been committed recently:
https://github.com/KentBeck/junit/commit/3a5c9f2731462e36dd1c173ea8840d7b9b34b0ab

IIC it should make it in JUnit 4.11. So we just have to wait.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

Vincent Hennebert vhenneb...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Vincent Hennebert vhenneb...@gmail.com ---
This is a known issue of JUnit 4. However, rev. 1360665 contains a change to
LayoutEngineTestUtils that will display the list of correspondences between
test number and test files by switching the DEBUG boolean to true.

I believe this provides a reasonable solution to this issue, feel free to
re-open if not.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

Glenn Adams gad...@apache.org changed:

   What|Removed |Added

   Priority|P2  |P3
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #2 from Glenn Adams gad...@apache.org ---
I agree with Jeremias on this, and further, that something else needs to be
done to better report the failing test without having to do something special
(i.e., switching a DEBUG boolean).

I reported this problem just after JUnit 4 was adopted, and I seem to recall
that Mehdi was going to look into a better solution. FWIW, when I encounter
this problem, I've been using Eclipse to catch the assert, which then allows
one to discover the culprit by walking up the stack a few levels.

In any case, I'm reopening this (as P3) as I'd like to see a better, long-term
solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53558] All but impossible to find the failing layout test in case of a regression

2012-07-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53558

--- Comment #3 from Mehdi Houshmand med1...@gmail.com ---
Hmm...  I swear I replied to this this morning... Anyways, I have been looking
into this periodically and hadn't found anything 'til today:

https://github.com/KentBeck/junit/issues/44

I don't have time to look into this at the moment, but I will look into it in
the next week or so so watch this space.

-- 
You are receiving this mail because:
You are the assignee for the bug.