[jira] [Comment Edited] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2020-12-29 Thread Simon Steiner (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255997#comment-17255997
 ] 

Simon Steiner edited comment on FOP-2536 at 12/29/20, 1:34 PM:
---

Changes can be now enabled using fop.xconf:
 
 true
 

 

[http://svn.apache.org/viewvc?view=revision&revision=1884907]


was (Author: ssteiner1):
Changed can be now enabled using fop.xconf:

 true


 

http://svn.apache.org/viewvc?view=revision&revision=1884907

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Assignee: Simon Steiner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536-new.patch, 
> extended-patch-FOP-2536.patch, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, table-border-overpaint.pdf, table-border-standard.pdf, 
> table-border.fo, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2019-03-14 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792668#comment-16792668
 ] 

simon steiner edited comment on FOP-2536 at 3/14/19 1:54 PM:
-

I am seeing compile and checkstyle errors when trying your patch (make sure you 
run findbugs also)

    
[javac]fop-core/src/main/java/org/apache/fop/layoutmgr/table/TableLayoutManager.java:660:
 error: cannot find symbol
     [javac] && bpsPrev.getMode() == bpsPrev.getMode()


was (Author: ssteiner1):
I am seeing compile and checkstyle errors when trying your patch

    
[javac]fop-core/src/main/java/org/apache/fop/layoutmgr/table/TableLayoutManager.java:660:
 error: cannot find symbol
    [javac] && bpsPrev.getMode() == bpsPrev.getMode()

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536.patch, 
> fop-2434-alternative.patch, patch-FOP-2434.diff, table-border-overpaint.pdf, 
> table-border-standard.pdf, table-border.fo, tableBorders.fo, 
> tableBorders_fop_2.0.pdf, tableBorders_fop_2.1.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2019-03-14 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792668#comment-16792668
 ] 

simon steiner edited comment on FOP-2536 at 3/14/19 1:53 PM:
-

I am seeing compile and checkstyle errors when trying your patch

    
[javac]fop-core/src/main/java/org/apache/fop/layoutmgr/table/TableLayoutManager.java:660:
 error: cannot find symbol
    [javac] && bpsPrev.getMode() == bpsPrev.getMode()


was (Author: ssteiner1):
I am seeing compile and checkstyle errors when trying your patch

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536.patch, 
> fop-2434-alternative.patch, patch-FOP-2434.diff, table-border-overpaint.pdf, 
> table-border-standard.pdf, table-border.fo, tableBorders.fo, 
> tableBorders_fop_2.0.pdf, tableBorders_fop_2.1.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2017-04-24 Thread Matthias Reischenbacher (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980964#comment-15980964
 ] 

Matthias Reischenbacher edited comment on FOP-2536 at 4/24/17 10:14 AM:


[~segadora] I'll commit the fix. I still haven't found enough time to create 
some unit tests, but hope to be able to do that soon.


was (Author: matthias8283):
~segadora I'll commit the fix. I still haven't found enough time to create some 
unit tests, but hope to be able to do that soon.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (FOP-2536) [PATCH] Varying table border thickness in PDF output

2016-06-09 Thread Matthias Reischenbacher (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322787#comment-15322787
 ] 

Matthias Reischenbacher edited comment on FOP-2536 at 6/9/16 5:23 PM:
--

Martin: I tried the attached patch but didn't see a visual difference when 
viewing the generated PDF file with Adobe Acrobat. Perhaps you can attach a 
test case and a before/after PDF file.

I attached an alternative patch which takes a different approach: during the 
layout phase the border traits are analyzed and additional layout blocks are 
created, that span over multiple cells and will paint over the existing table 
borders. This over painting can be activated by setting the following renderer 
option:
userAgent.getRendererOptions().put("overpaint-table-borders", Boolean.TRUE);
The visual output is close to optimal (for my use case), but I'm not too happy 
about having duplicate borders (also PDF file size increases a bit). So I'm 
still thinking about how this could be fixed in a more optimal way.


was (Author: matthias8283):
Alternative patch that "overpaints" table borders

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)