[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402706#comment-15402706 ] Jan Tošovský commented on FOP-1760: --- The current patch produces invalid intermediate format. All changebars are rendered as absolute positioned blocks even if the parent areas are inline objects. Without improvements of IF (a new element?) there is no way to compile FOP because of failing tests. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: Bug > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412295#comment-15412295 ] Jan Tošovský commented on FOP-1760: --- The current patch implements fix for FOP-2640. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: Bug > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, > patch_against_rev_1755460_2016-08-07.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422619#comment-16422619 ] William Eliot Kimber commented on FOP-1760: --- Is there a plan to incorporate this fix to FOP 2.x? If not, what would be required to make this patch approved for inclusion? > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: Bug > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, > patch_against_rev_1755460_2016-08-07.patch, > patch_against_rev_1776640_2016-12-30.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[
https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446489#comment-16446489
]
William Eliot Kimber commented on FOP-1760:
---
I'm trying to use this patch against the 2.2.0 version the patch was made for.
To make it work I had to add fo:change-bar-begin and fo:change-bar-end to
isInlineItem() in FObj.java:
```
&& ("bidi-override".equals(lName)
|| "change-bar-begin".equals(lName)
|| "change-bar-end".equals(lName)
|| "character".equals(lName)
```
Otherwise I got a validation failure.
Since the last patch is behind dev I'm not sure how best to prepare an updated
patch (I've forgotten what little SVN fu I once had and I've never really had
to deal with patches in my career as a developer).
Assuming the code works as it should, I'd really like to see this make it into
the next appropriate FOP release. I'm in a position to do whatever development
work is required, such as bringing tests up to date, adding more tests, etc.
> [PATCH] FOP doesn't support change bar generation
> -
>
> Key: FOP-1760
> URL: https://issues.apache.org/jira/browse/FOP-1760
> Project: FOP
> Issue Type: New Feature
> Components: unqualified
>Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
>Reporter: Stephan Thesing
>Priority: Blocker
> Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff,
> changebar_20110308.diff, changebars.fo, changebars.pdf,
> changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt,
> fop_20120507.diff, fop_changebars_20120506.diff,
> patch_against_rev_1686494_2015-06-19.patch,
> patch_against_rev_1690781_2015-07-19.patch,
> patch_against_rev_1755460_2016-08-07.patch,
> patch_against_rev_1776640_2016-12-30.patch, test.fo, test.pdf
>
>
> In order to produce change bars along the columns for changed contents,
> FO supports the fo:change-bar-begin and fo:change-bar-end elements.
> These are not supported by FOP.
> Support for change bars should be added.
> Effort needed
> - add parsing and validation of fo: elements
> - determine fo elements under influence of one or more change bars
> - when creating areas from such affected fo elements, create additional areas
> representing the change bars as defined in the FO standard.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446942#comment-16446942 ] Jan Tošovský commented on FOP-1760: --- Patches can be created using the description at [https://xmlgraphics.apache.org/fop/dev/tools.html#patches |https://xmlgraphics.apache.org/fop/dev/tools.html#patches] - I personally use Tortoise SVN and all my patches here were created this way. Once uploaded, I can test it on my updated local SVN copy. If everything works, we can ask again some commiter to include it. From my POV it is better to discuss these things on public DEV mailing list. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, > patch_against_rev_1755460_2016-08-07.patch, > patch_against_rev_1776640_2016-12-30.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502430#comment-16502430 ] Jan Tošovský commented on FOP-1760: --- I am attaching the updated patch (including Eliot's change) tested against the current trunk version. Let's incorporate this and turn several rows in [https://xmlgraphics.apache.org/fop/compliance.html] into green :) > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527127#comment-16527127 ] David Jiang commented on FOP-1760: -- Where can i find the change list, I don't seem to be able to pull from svn repo. e.g. rev. 1832958 or any related change bar changes. thanks. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527238#comment-16527238 ] Jan Tošovský commented on FOP-1760: --- David, this patch has not been integrated yet, see the 'Open' status of this issue. Users have to apply this patch to the trunk themselves. That revision number just tells which trunk revision this patch is based on (and successfully tested). > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529632#comment-16529632 ] David Jiang commented on FOP-1760: -- Thanks [~jan.tosovsky.cz], we'll try the patch in our project, in case anything found, we'll report here. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533522#comment-16533522 ] simon steiner commented on FOP-1760: changeBarList is static is that correct? > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533546#comment-16533546 ] simon steiner commented on FOP-1760: Added http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_ChangeBars2/ > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Assignee: simon steiner >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
