[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Matthias Reischenbacher (Jira)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256000#comment-17256000
 ] 

Matthias Reischenbacher commented on FOP-2536:
--

Thanks [~ssteiner]!

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Assignee: Simon Steiner
>Priority: Major
> Fix For: trunk
>
> Attachments: Polygon.java, extended-patch-FOP-2536-new.patch, 
> extended-patch-FOP-2536.patch, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, table-border-overpaint.pdf, table-border-standard.pdf, 
> table-border.fo, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Simon Steiner (Jira)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255997#comment-17255997
 ] 

Simon Steiner commented on FOP-2536:


Changed can be now enabled using fop.xconf:

 true


 

http://svn.apache.org/viewvc?view=revision=1884907

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Assignee: Simon Steiner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536-new.patch, 
> extended-patch-FOP-2536.patch, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, table-border-overpaint.pdf, table-border-standard.pdf, 
> table-border.fo, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[JIRA]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793083#comment-16793083
 ] 

Jan Tošovský commented on FOP-2536:
---

Updated patch now includes one forgotten file. It also passes both checkstyle 
and findbugs checks.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536-new.patch, 
> extended-patch-FOP-2536.patch, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, table-border-overpaint.pdf, table-border-standard.pdf, 
> table-border.fo, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[simon steiner (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792668#comment-16792668
 ] 

simon steiner commented on FOP-2536:


I am seeing compile and checkstyle errors when trying your patch

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536.patch, 
> fop-2434-alternative.patch, patch-FOP-2434.diff, table-border-overpaint.pdf, 
> table-border-standard.pdf, table-border.fo, tableBorders.fo, 
> tableBorders_fop_2.0.pdf, tableBorders_fop_2.1.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[JIRA]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792164#comment-16792164
 ] 

Jan Tošovský commented on FOP-2536:
---

I've attached FO file ( [^table-border.fo] ) used in the test case generated 
without the new option ( [^table-border-standard.pdf] ) and with this option ( 
[^table-border-overpaint.pdf])
{code:xml}

  overpaint

{code}
If this patch is accepted, the new option should be documented on the 
configuration page (PDF Renderer section):
 [https://xmlgraphics.apache.org/fop/trunk/configuration.html]

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536.patch, 
> fop-2434-alternative.patch, patch-FOP-2434.diff, table-border-overpaint.pdf, 
> table-border-standard.pdf, table-border.fo, tableBorders.fo, 
> tableBorders_fop_2.0.pdf, tableBorders_fop_2.1.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[JIRA]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792140#comment-16792140
 ] 

Jan Tošovský commented on FOP-2536:
---

Updated patch extends the original patch in these areas:
* reading the table border rendering mode from the FOP config and passing it as 
the renderer option to the layout manager
* changing the mode type from boolean to enum with two supported values: 
standard (default) and overpaint
* adding support for selecting the specific FOP config for the given standard 
layout engine test
* adding support for selecting the specific target MIME for the given standard 
layout engine test
* adding two layout tests utilizing new features

The core merging functionality is kept intact.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536.patch, 
> fop-2434-alternative.patch, patch-FOP-2434.diff, tableBorders.fo, 
> tableBorders_fop_2.0.pdf, tableBorders_fop_2.1.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Christoffer Nielsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502912#comment-16502912
 ] 

Christoffer Nielsen commented on FOP-2536:
--

I dont think the fop team has interest in getting this fixed since its a bug in 
pdf and not the implementation. This implementation is simply a workaround.

This said, we have implemented a patched apache fop in our organisation to 
workaround this issue. I would love to see this fixed.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[simon steiner (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502902#comment-16502902
 ] 

simon steiner commented on FOP-2536:


Maybe layout test fop/test/layoutengine/standard-testcases

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[JIRA]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502539#comment-16502539
 ] 

Jan Tošovský commented on FOP-2536:
---

Can anybody clarify what kind of unit tests is expected here? I'd like to move 
this forward.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
>Priority: Major
> Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Christoffer Nielsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980968#comment-15980968
 ] 

Christoffer Nielsen commented on FOP-2536:
--

[~matthias8283] yeah sorry, I messed around, I thought that, I created a PR for 
our own git repo.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Matthias Reischenbacher (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980964#comment-15980964
 ] 

Matthias Reischenbacher commented on FOP-2536:
--

~segadora I'll commit the fix. I still haven't found enough time to create some 
unit tests, but hope to be able to do that soon.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980963#comment-15980963
 ] 

ASF GitHub Bot commented on FOP-2536:
-

Github user segadora closed the pull request at:

https://github.com/apache/fop/pull/4


> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980952#comment-15980952
 ] 

ASF GitHub Bot commented on FOP-2536:
-

GitHub user segadora opened a pull request:

https://github.com/apache/fop/pull/4

Fixes problem with various border thickness

More info on:

https://issues.apache.org/jira/browse/FOP-2536
https://issues.apache.org/jira/browse/FOP-2434

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Casalogic/fop patch/border

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fop/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit e45f14e94ddb3209e570d95b40e392ee9175bcf9
Author: asf-sync-process 
Date:   2016-01-15T09:46:40Z

Add tag


git-svn-id: 
https://svn.apache.org/repos/asf/xmlgraphics/fop/tags/fop-2_1@1724753 
13f79535-47bb-0310-9956-ffa450edef68

commit 063c888933a42a102619a74f9bb8e5c3b85ec5b5
Author: Christoffer Nielsen 
Date:   2017-04-24T09:57:28Z

Add border patch

commit c5429cc16fe5042c461d659550a1aa55c79e4651
Author: Christoffer Nielsen 
Date:   2017-04-24T09:57:49Z

Disable config option

Disabled due that it only can be set in java (so it seems)




> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Christoffer Nielsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980933#comment-15980933
 ] 

Christoffer Nielsen commented on FOP-2536:
--

[~matthias8283] I have tested your patch now, and I can confirm it fixes the 
issue perfectly. I have tested in multiple viewers and it renderes it correctly 
each time.
[~cbowditch] would it be possible for you to consider implementing such a fix, 
now that it is configurable by the user, if it should be enabled or not?

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Chris Bowditch (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958655#comment-15958655
 ] 

Chris Bowditch commented on FOP-2536:
-

Thanks [~matthias8283] Since you're a committer now I'm wondering why you 
have't committed this patch yet? Although I note there are no unit tests which 
should be added before doing so. I also find it odd that the name of the patch 
file is 2434, which its attached to 2536???

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Christoffer Nielsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958552#comment-15958552
 ] 

Christoffer Nielsen commented on FOP-2536:
--

[~matthias8283] I will do it as a last solution, for now it looks fine by 
seperating the table into 3 tables (header, body, footer).
I want to avoid maintaining fop myself.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Matthias Reischenbacher (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957197#comment-15957197
 ] 

Matthias Reischenbacher commented on FOP-2536:
--

[~segadora], you might try the other patch: fop-2434-alternative.patch and set 
the following config option:
userAgent.getRendererOptions().put("overpaint-table-borders", Boolean.TRUE);

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Christoffer Nielsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956555#comment-15956555
 ] 

Christoffer Nielsen commented on FOP-2536:
--

[~martin.leit...@infinica.com] I tried the patch for fop 2.1, but the border is 
still varying in thickness and color with a black border at 1px.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: fop-2434-alternative.patch, patch-FOP-2434.diff, 
> Polygon.java, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_fop_2.1.pdf, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Jan Tosovsky (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331273#comment-15331273
 ] 

Jan Tosovsky commented on FOP-2536:
---

Btw, you can star this Chrome issue 
https://bugs.chromium.org/p/chromium/issues/detail?id=500023
That referenced table can be found in 
https://issues.apache.org/jira/browse/FOP-2477
I've also reported it to Adobe, but there is no issue tracker available for 
Acrobat Reader. But I believe more people will ask for that, the more attention 
it will gain.
http://www.adobe.com/products/wishform.html


> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Martin Leitner (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327009#comment-15327009
 ] 

Martin Leitner commented on FOP-2536:
-

Matthias: I attached a sample fo file, together with the pdfs as generated by 
FOP 2.0, FOP 2.1, and my patched version.

Note that technically they are identical, since FOP generated the borders 
correctly all the time. It is only the (broken) readers that have problems. The 
pdfs look all the same to me in Foxit Reader. In Adobe Reader (version 11.0.2) 
however, the top border of the spanned cell appears broken even without any 
zoom. I attached a screenshot.
It appears that the problem only shows with borders of spanned cells that have 
non-spanned neighbouring cells, at least in this version of Adobe Reader.

I understand that every attempt to fix this issue in the renderer can at best 
be incomplete, since it is close to impossible to test the behaviour of all 
readers in all cases. Therefor it is perfectly possible and even likely that 
there are better approaches than mine. What I don't understand is why there is 
no reaction to this topic. There is not even any acknowledgement that the 
problem exists, even though it exists for years, much less any comment on the 
offered solution. How hard can it be to check if the proposed patch passes the 
existing unit tests, for a start?

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: Polygon.java, fop-2434-alternative.patch, 
> patch-FOP-2434.diff, tableBorders.fo, tableBorders_fop_2.0.pdf, 
> tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, 
> tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Martin Leitner (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998493#comment-14998493
 ] 

Martin Leitner commented on FOP-2536:
-

Hi Chris, I have just sent the CLAs (personal and corporate) to 
secret...@apache.org.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: Polygon.java, patch-FOP-2434.diff
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Chris Bowditch (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974038#comment-14974038
 ] 

Chris Bowditch commented on FOP-2536:
-

Hi Martin, many thanks for submitting an improvement for the border painting. 
I've not studied your code yet, but since you are adding new files to the 
repository you will need to complete an ICLA as described at [1] before this 
patch could be accepted.

Thanks,

Chris

[1] http://www.apache.org/licenses/#clas

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: Polygon.java, patch-FOP-2434.diff
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FOP-2536) [PATCH] Varying table border thickness in PDF output

[Martin Leitner (JIRA)]

[ 
https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966386#comment-14966386
 ] 

Martin Leitner commented on FOP-2536:
-

svn diff did not include the new class in the diff, so I added the file 
separately.

> [PATCH] Varying table border thickness in PDF output
> 
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
>  Issue Type: Improvement
>  Components: renderer/pdf
>Reporter: Martin Leitner
> Attachments: Polygon.java, patch-FOP-2434.diff
>
>
> As already pointed out in a comment to the original issue, this is a problem 
> with the PDF viewers. FOP generates the borders correctly. The viewers render 
> border segments correctly when they are rectangles, but they make mistakes 
> when the segments are more general polygons. In my patch, I am splitting the 
> polygons into rectangles, covering as much of the polygon as possible, write 
> the rectangles to the PDF, then write the remaining triangles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)