[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2019-07-12 Thread Matthias Pigulla (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883830#comment-16883830
 ] 

Matthias Pigulla commented on FOP-2704:
---

I have applied the patch suggested by Neil to the FOP 2.3 release branch – it 
_works for me_™️.

If you want to give it a try, you can see the changes at 
https://github.com/webfactory/fop/pull/1. Also, at 
https://jitpack.io/#webfactory/fop/da392ffca you'll find instructions how to 
easily try this change with your preferred build system.


> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2019-07-15 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885206#comment-16885206
 ] 

simon steiner commented on FOP-2704:


Ignoring exceptions would make it harder to catch future problems as they occur

> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2019-10-07 Thread Matthias Pigulla (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946546#comment-16946546
 ] 

Matthias Pigulla commented on FOP-2704:
---

Can anybody here help me understand why the 
https://github.com/apache/xmlgraphics-fop/pull/59 PR was closed? It seems to me 
that `asfgit`, the relevant GitHub account, is some automatic process by ASF?

In particular, why did it *force push* to a release branch, seemingly replacing 
over 200 commits?


> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2019-10-08 Thread Simon Steiner (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946579#comment-16946579
 ] 

Simon Steiner commented on FOP-2704:


Due to https://issues.apache.org/jira/browse/INFRA-19236

> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2019-12-30 Thread John (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005331#comment-17005331
 ] 

John commented on FOP-2704:
---

[https://github.com/apache/xmlgraphics-fop/pull/60] (repost of #59) solved all 
my Roboto issues. Thanks for the work on this.

Does anyone know when/if this change will be released?

> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2019-12-30 Thread Simon Steiner (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005336#comment-17005336
 ] 

Simon Steiner commented on FOP-2704:


See my comment in july above

> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2020-01-02 Thread Matthias Pigulla (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007075#comment-17007075
 ] 

Matthias Pigulla commented on FOP-2704:
---

[~ssteiner] Maybe you could point us into the right direction – what do you 
think should a suitable fix look like?


> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2020-04-15 Thread Matthias Pigulla (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083925#comment-17083925
 ] 

Matthias Pigulla commented on FOP-2704:
---

[~ssteiner] Thank you for working on this!

As a JIRA user, will I get another notification once this makes it into a 
release, or should I watch releases separately?


> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Assignee: Simon Steiner
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported

2020-04-15 Thread Simon Steiner (Jira)


[ 
https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083941#comment-17083941
 ] 

Simon Steiner commented on FOP-2704:


The release notification goes to the fop mailing lists, I added but not sure if 
you can watch this:

https://issues.apache.org/jira/projects/FOP/versions/12348082

> [PATCH] Google fonts Roboto font (updated 2017) 
> UnsupportedOperationException: coverage set class table not yet supported
> -
>
> Key: FOP-2704
> URL: https://issues.apache.org/jira/browse/FOP-2704
> Project: FOP
>  Issue Type: Bug
>  Components: font/opentype
>Affects Versions: 2.1, 2.2
>Reporter: Dan Caprioara
>Assignee: Simon Steiner
>Priority: Major
> Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, 
> font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" 
> or "roboto-thin" TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet 
> supported
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.(GlyphClassTable.java:262)
>   at 
> org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
>   at 
> org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
>   at 
> org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
>   at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
>   at 
> org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
>   at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the 
> {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} 
> parameter is null.
> After these changes, the PDF is produced and it looks good. I am not sure 
> what are the side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)