[jira] [Commented] (FOP-2784) [PATCH] FOP-2738: correct array offset when string span interator is used

2018-05-10 Thread Matthias Reischenbacher (JIRA) 

[ 
https://issues.apache.org/jira/browse/FOP-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470370#comment-16470370
 ] 

Matthias Reischenbacher commented on FOP-2784:
--

[~vladislav]: a proper fix for this issue is attached as patch in FOP-2572.

> [PATCH] FOP-2738: correct array offset when string span interator is used
> -
>
> Key: FOP-2784
> URL: https://issues.apache.org/jira/browse/FOP-2784
> Project: FOP
>  Issue Type: Improvement
>  Components: font/unqualified
>Affects Versions: 2.2
>Reporter: Vlad Ivanov
>Priority: Major
> Attachments: 
> 0001-FOP-2738-correct-array-offset-when-string-span-inter.patch, fop.conf, 
> fop1.fo, image.svg
>
>
> This patch fixes FOP-2738.
> The issue occurred when code in GlyphMapping.java was used with string span 
> iterator. This kind of iterator points somewhere in the string, not 
> necessarily the start; however, iterator indexes were used to index into an 
> array, which caused an exception in some cases. Fix removes iterator index 
> offset in addLetterAdjust.
> Reproducing:
> {code}
> fop -c fop.conf fop1.fo fop1.pdf
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2784) [PATCH] FOP-2738: correct array offset when string span interator is used

2018-05-10 Thread Vlad Ivanov (JIRA) 

[ 
https://issues.apache.org/jira/browse/FOP-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470195#comment-16470195
 ] 

Vlad Ivanov commented on FOP-2784:
--

I can't see any visual differences when converting to PDF, I'll see what to do 
with testcase

> [PATCH] FOP-2738: correct array offset when string span interator is used
> -
>
> Key: FOP-2784
> URL: https://issues.apache.org/jira/browse/FOP-2784
> Project: FOP
>  Issue Type: Improvement
>  Components: font/unqualified
>Affects Versions: 2.2
>Reporter: Vlad Ivanov
>Priority: Major
> Attachments: 
> 0001-FOP-2738-correct-array-offset-when-string-span-inter.patch, fop.conf, 
> fop1.fo, image.svg
>
>
> This patch fixes FOP-2738.
> The issue occurred when code in GlyphMapping.java was used with string span 
> iterator. This kind of iterator points somewhere in the string, not 
> necessarily the start; however, iterator indexes were used to index into an 
> array, which caused an exception in some cases. Fix removes iterator index 
> offset in addLetterAdjust.
> Reproducing:
> {code}
> fop -c fop.conf fop1.fo fop1.pdf
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2784) [PATCH] FOP-2738: correct array offset when string span interator is used

2018-05-10 Thread simon steiner (JIRA) 

[ 
https://issues.apache.org/jira/browse/FOP-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470068#comment-16470068
 ] 

simon steiner commented on FOP-2784:


Can you add a unit test?

> [PATCH] FOP-2738: correct array offset when string span interator is used
> -
>
> Key: FOP-2784
> URL: https://issues.apache.org/jira/browse/FOP-2784
> Project: FOP
>  Issue Type: Improvement
>  Components: font/unqualified
>Affects Versions: 2.2
>Reporter: Vlad Ivanov
>Priority: Major
> Attachments: 
> 0001-FOP-2738-correct-array-offset-when-string-span-inter.patch, fop.conf, 
> fop1.fo, image.svg
>
>
> This patch fixes FOP-2738.
> The issue occurred when code in GlyphMapping.java was used with string span 
> iterator. This kind of iterator points somewhere in the string, not 
> necessarily the start; however, iterator indexes were used to index into an 
> array, which caused an exception in some cases. Fix removes iterator index 
> offset in addLetterAdjust.
> Reproducing:
> {code}
> fop -c fop.conf fop1.fo fop1.pdf
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FOP-2784) [PATCH] FOP-2738: correct array offset when string span interator is used

2018-05-10 Thread Vlad Ivanov (JIRA) 

[ 
https://issues.apache.org/jira/browse/FOP-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470063#comment-16470063
 ] 

Vlad Ivanov commented on FOP-2784:
--

Any updates?

> [PATCH] FOP-2738: correct array offset when string span interator is used
> -
>
> Key: FOP-2784
> URL: https://issues.apache.org/jira/browse/FOP-2784
> Project: FOP
>  Issue Type: Improvement
>  Components: font/unqualified
>Affects Versions: 2.2
>Reporter: Vlad Ivanov
>Priority: Major
> Attachments: 
> 0001-FOP-2738-correct-array-offset-when-string-span-inter.patch, fop.conf, 
> fop1.fo, image.svg
>
>
> This patch fixes FOP-2738.
> The issue occurred when code in GlyphMapping.java was used with string span 
> iterator. This kind of iterator points somewhere in the string, not 
> necessarily the start; however, iterator indexes were used to index into an 
> array, which caused an exception in some cases. Fix removes iterator index 
> offset in addLetterAdjust.
> Reproducing:
> {code}
> fop -c fop.conf fop1.fo fop1.pdf
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)