[jira] [Commented] (FOP-2818) PDF color spaces are lost when embedding PDF image

2018-10-10 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644621#comment-16644621
 ] 

simon steiner commented on FOP-2818:


Would be good to see a unit test

> PDF color spaces are lost when embedding PDF image
> --
>
> Key: FOP-2818
> URL: https://issues.apache.org/jira/browse/FOP-2818
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Reporter: Matthias Reischenbacher
>Priority: Critical
> Attachments: image.pdf, kun_muutat_suomeenEN.pdf.pdf, 
> output_broken.pdf, output_fixed.pdf, test.fo, test_case.xml
>
>
> When embedding a PDF image (via the fop pdf image plugin) into a page, that 
> also contains a color definition with a custom color space (e.g. a Pantone 
> full tone color), the color space definition is lost and the PDF can't be 
> displayed correctly.
> After analyzing the generated PDF file I detected, that the "ColorSpace" 
> entry for the Pantone color space was missing in the "Resources" dictionary. 
> This bug was caused by FOP-2337, that introduced a "parent" resource 
> directory. I adapted the populateDictionary method of the PDFResources class, 
> so that the color space entries of the "parent" dictionary are not lost. 
> @ssteiner: please check, if this is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2818) PDF color spaces are lost when embedding PDF image

2018-10-09 Thread Matthias Reischenbacher (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643665#comment-16643665
 ] 

Matthias Reischenbacher commented on FOP-2818:
--

Fixed as part of http://svn.apache.org/viewvc?view=revision=1843302

> PDF color spaces are lost when embedding PDF image
> --
>
> Key: FOP-2818
> URL: https://issues.apache.org/jira/browse/FOP-2818
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Reporter: Matthias Reischenbacher
>Priority: Critical
> Attachments: image.pdf, kun_muutat_suomeenEN.pdf.pdf, 
> output_broken.pdf, output_fixed.pdf, test.fo, test_case.xml
>
>
> When embedding a PDF image (via the fop pdf image plugin) into a page, that 
> also contains a color definition with a custom color space (e.g. a Pantone 
> full tone color), the color space definition is lost and the PDF can't be 
> displayed correctly.
> After analyzing the generated PDF file I detected, that the "ColorSpace" 
> entry for the Pantone color space was missing in the "Resources" dictionary. 
> This bug was caused by FOP-2337, that introduced a "parent" resource 
> directory. I adapted the populateDictionary method of the PDFResources class, 
> so that the color space entries of the "parent" dictionary are not lost. 
> @ssteiner: please check, if this is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2818) PDF color spaces are lost when embedding PDF image

2018-10-09 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643580#comment-16643580
 ] 

simon steiner commented on FOP-2818:


This commit breaks some pdf to pdf examples

> PDF color spaces are lost when embedding PDF image
> --
>
> Key: FOP-2818
> URL: https://issues.apache.org/jira/browse/FOP-2818
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Reporter: Matthias Reischenbacher
>Priority: Critical
> Attachments: image.pdf, kun_muutat_suomeenEN.pdf.pdf, 
> output_broken.pdf, output_fixed.pdf, test.fo, test_case.xml
>
>
> When embedding a PDF image (via the fop pdf image plugin) into a page, that 
> also contains a color definition with a custom color space (e.g. a Pantone 
> full tone color), the color space definition is lost and the PDF can't be 
> displayed correctly.
> After analyzing the generated PDF file I detected, that the "ColorSpace" 
> entry for the Pantone color space was missing in the "Resources" dictionary. 
> This bug was caused by FOP-2337, that introduced a "parent" resource 
> directory. I adapted the populateDictionary method of the PDFResources class, 
> so that the color space entries of the "parent" dictionary are not lost. 
> @ssteiner: please check, if this is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)