[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregor Berg updated FOP-2469: - Attachment: 2015-05-13-auto-table-layout.patch > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: Fop > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregor Berg updated FOP-2469: - Attachment: FOP2469-auto-table-layout.xml > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: Fop > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > FOP2469-auto-table-layout.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregor Berg updated FOP-2469: - Attachment: 2015-05-27-LM-to-LC-refactoring.patch illustration of how a switch from LM bottom-up (O(n)) to LC top-down (O(1)) might look like > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, FOP2469-auto-table-layout.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregor Berg updated FOP-2469: - Attachment: 2015-06-09-LM-to-LC-refactoring-update.patch The older LM-to-LC patch (2015-05-27) was incomplete concerning the correct propagation of the new LayoutContext properties - now, the newest LC version (2015-06-09) should produce the exact same results as the LayoutManager version (2015-05-13). > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP2469-auto-table-layout.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas L. Delmelle updated FOP-2469: - Attachment: LayoutContext_Tweak.diff Good stuff, so far... Added a small patch for you to play with as well. Had an idea for improvement of handling the propagation of the related flags to child contexts. It should normally work on your end as is, too, since I kept the same method names. Only changes are that: a) the flags have now been aligned with the flag mechanism already present b) the offspringOf() method uses a more generic propagateFlagsFrom() to extend on the already propagated treatAsArtifact() Not included yet: The latter would allow replacing the newInstance() calls that are followed by setting both flags with offspringOff() calls. The cases where we do still need the explicit setter are those where we *don't* want the flag value propagated to the child context. > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP2469-auto-table-layout.xml, > LayoutContext_Tweak.diff > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregor Berg updated FOP-2469: - Attachment: resize-spanned-columns.xml resize-all-but-static-spanned-columns.xml warning-only-static-columns-are-spanned.xml > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP2469-auto-table-layout.xml, > LayoutContext_Tweak.diff, resize-all-but-static-spanned-columns.xml, > resize-spanned-columns.xml, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas L. Delmelle updated FOP-2469: - Attachment: FOP-2469_20150618.patch Added new version of the patch. No real invasive changes, so far, just minor cleanups -- also some unrelated changes in the same classes, sorry ;) -- and integration of the LayoutContext tweak. Also added the initially added test case to the layout engine test suite. More detailed checks section still TBD, but currently, just adding the test already fails the build on the mentioned assertion error. > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469_20150618.patch, > FOP2469-auto-table-layout.xml, LayoutContext_Tweak.diff, > resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, > warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas L. Delmelle updated FOP-2469: - Attachment: (was: LayoutContext_Tweak.diff) > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469_20150618.patch, > FOP2469-auto-table-layout.xml, resize-all-but-static-spanned-columns.xml, > resize-spanned-columns.xml, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas L. Delmelle updated FOP-2469: - Attachment: FOP-2469_20150621.patch New patch, with some further minor changes here and there, and the three additional test cases added to the layout engine test suite. Removed the isAutoLayout() method from AbstractBaseLM and LayoutManager, and made the implementations package private in TableLM and TableCellLM. I experimented with having the default implementation in AbstractBaseLM return false, which ultimately produces the exact same output, so I was left wondering what purpose the isAutoLayout() calls in BlockStackingLM and LineLM have other than avoiding some warning messages in the log, which seems to be the only difference ( ? ) That could also be avoided by passing the LayoutContext to the updateContentArea...() method, which is what I did instead. > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469_20150621.patch, > FOP2469-auto-table-layout.xml, resize-all-but-static-spanned-columns.xml, > resize-spanned-columns.xml, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas L. Delmelle updated FOP-2469: - Attachment: (was: FOP-2469_20150618.patch) > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle > Fix For: trunk > > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469_20150621.patch, > FOP2469-auto-table-layout.xml, resize-all-but-static-spanned-columns.xml, > resize-spanned-columns.xml, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Lim updated FOP-2469: -- Attachment: FOP-2469-2018-07-17.patch > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle >Priority: Major > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, > FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, > resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, > warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-2469) [PATCH] auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] simon steiner updated FOP-2469: --- Attachment: test.fo > [PATCH] auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle >Priority: Major > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, > FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, > resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, > test.fo, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-2469) [PATCH] Auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] simon steiner updated FOP-2469: --- Summary: [PATCH] Auto table layout (was: [PATCH] auto table layout) > [PATCH] Auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle >Priority: Major > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, > FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, > resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, > test.fo, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-2469) [PATCH] Auto table layout
[ https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Lim updated FOP-2469: -- Attachment: test2.fo > [PATCH] Auto table layout > - > > Key: FOP-2469 > URL: https://issues.apache.org/jira/browse/FOP-2469 > Project: FOP > Issue Type: Bug > Components: layout/unqualified >Affects Versions: trunk > Environment: Windows 7, JDK 7 >Reporter: Gregor Berg >Assignee: Andreas L. Delmelle >Priority: Major > Attachments: 2015-05-13-auto-table-layout.patch, > 2015-05-27-LM-to-LC-refactoring.patch, > 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, > FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, > resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, > test.fo, test2.fo, warning-only-static-columns-are-spanned.xml > > > Hi, > this is a patch which enables table-layout=auto. It is quite robust, it can > not only handle linebreaks and pagebreaks, but it also copes with auto tables > in fixed tables in auto tables. > Essentially, it is the patch of issue FOP-2450 adapted to the trunk version > of FOP. > Best regards, > Gregor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [jira] [Updated] (FOP-2469) [PATCH] auto table layout
Hi Gregor Just a heads-up, if you're reading this: We (I) have not forgotten. :) Will probably have more time next week to have a closer look at your work. Thanks for updating the Wiki, BTW. That stuff is very valuable info! KR Andreas > On 27 May 2015, at 15:51, Gregor Berg (JIRA) wrote: > > > [ > https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Gregor Berg updated FOP-2469: > - >Attachment: 2015-05-27-LM-to-LC-refactoring.patch > > illustration of how a switch from LM bottom-up (O(n)) to LC top-down (O(1)) > might look like > >> [PATCH] auto table layout >> - >> >>Key: FOP-2469 >>URL: https://issues.apache.org/jira/browse/FOP-2469 >>Project: FOP >> Issue Type: Bug >> Components: layout/unqualified >> Affects Versions: trunk >>Environment: Windows 7, JDK 7 >> Reporter: Gregor Berg >>Fix For: trunk >> >>Attachments: 2015-05-13-auto-table-layout.patch, >> 2015-05-27-LM-to-LC-refactoring.patch, FOP2469-auto-table-layout.xml >> >> >> Hi, >> this is a patch which enables table-layout=auto. It is quite robust, it can >> not only handle linebreaks and pagebreaks, but it also copes with auto >> tables in fixed tables in auto tables. >> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version >> of FOP. >> Best regards, >> Gregor > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332)
