DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 Mehdi Houshmand changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 --- Comment #7 from Mehdi Houshmand 2012-03-16 11:46:40 UTC --- Oops, forgot to say, thanks for the good work! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 Mehdi Houshmand changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #6 from Mehdi Houshmand 2012-03-16 11:45:45 UTC --- This has been commited in r1301445. I made a few changes fixing checkstyle issues concerning javadocs and line lengths. I also made the Set in the LoggingEventListener "final", there doesn't seem much point in lazy loading this member. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 Luis Bernardo changed: What|Removed |Added Attachment #28432|0 |1 is obsolete|| --- Comment #5 from Luis Bernardo 2012-03-14 16:16:29 UTC --- Created attachment 28466 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28466 updated patch I put some more thought into this and I think it is OK to remove the log.warn() from FontInfo (from the notify* methods) and just rely on the event listener. The decision whether to output the log messages was then moved to the LogginEventListener. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 --- Comment #4 from Luis Bernardo 2012-03-07 23:14:22 UTC --- I confess I did not put a lot of thought into that and instead used the same pattern that was already present in the that class in the notifyFontReplacement() method. But the remark is a good one. In a more general event framework the listener could even indicate at the time of registration of interest in a particular class of events whether to receive repeated events or just unique events. In the current event framework, yes, I think that letting the listener decide whether to notify or not the user makes sense. However, the problem I see is with the logging. If there is no listener the code falls back to log.warn() calls and I think we do not want repeated messages to clutter the logs. Maybe that is the reason it was done like this originally? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 --- Comment #3 from Mehdi Houshmand 2012-03-07 15:07:51 UTC --- Hi Luis, Just thinking about this, I think maybe the FontInfo class shouldn't really be responsible for remembering that which notifications it has sent. It just just notify the FontEventListener, then the FontEventListener should decide whether to notify the user or not. Just a thought, maybe I'm missing something... I see that there's a loggedFontKeys that does something similar, maybe there's a reason for that? If anyone else has thoughts, please do chime in. Mehdi -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52849] [PATCH] SVG font being painted as shapes when font present in the system
https://issues.apache.org/bugzilla/show_bug.cgi?id=52849 Luis Bernardo changed: What|Removed |Added Summary|SVG font being painted as |[PATCH] SVG font being |shapes when font present in |painted as shapes when font |the system |present in the system --- Comment #2 from Luis Bernardo 2012-03-07 14:56:11 UTC --- title updated. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
