[foreman-dev] Re: Revert removal of @host.params for host_param

[Daniel Lobato]

Sorry to relive the topic but 
https://github.com/theforeman/foreman/pull/4219 didn't get in, 
and it's time to update the documentation for 1.15 including deprecations. 

Since reverting the change is probably something not to be done during RC, 
I wonder what to do. 
The options are:

1. Keep the code as-is - which forces people to change their templates for 
1.17 for little benefit imo
2. Support both options - this would just require to remove the 
deprecations for the next RC which is not a problem
3. Support both options and reconsider to remove the helpers?

Let me know what you think, I lean towards 2 or 3 as I explained in here 
previously.

2017年1月11日水曜日 17時05分42秒 UTC+1 Daniel Lobato:
>
> Hi foreman devs, 
>
> Just noticed today https://github.com/theforeman/foreman/pull/3983/files 
> after some comments on IRC. What's the background behind this change? 
>
> As far as I can see, this merely moves 
>
> @host.param to host_param 
> @host.param_true? to host_param_true? 
> @host.param_false? to host_param_false? 
> @host.info to host_enc 
>
> without gaining anything from the change. This will force people to 
> change their templates (including our community templates) when the 
> deprecation is removed, and there's nothing to gain. 
>
> Does someone know what's the rationale behind this change? As it stands 
> right now, I propose reverting that commit entirely to avoid inflicting 
> that pain on users - which include many devs who maintain templates. 
>
> Best, 
>
> -- 
> Daniel Lobato Garcia 
>
> @dLobatog 
> blog.daniellobato.me 
> daniellobato.me 
>
> GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 
> Keybase: https://keybase.io/elobato 
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Re: Heads up: Use ApplicationRecord base for your models

[Daniel Lobato Garcia]

On 04/12, Lukas Zapletal wrote:
> > Heads up!
> >
> > PG::UndefinedTable: ERROR:  relation "application_records" does not exist
>
> This error appears to show up when Rails devel environment is reloaded
> on change. We are tracking this down, but be careful until we find
> this.

https://github.com/theforeman/foreman/pull/4454 is merged, I take it
this is now fixed on develop

>
> --
> Later,
>   Lukas @lzap Zapletal
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

--
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

[foreman-dev] Weekly Dev/Design Meeting: Management of Repositories

[Roxanne Hoover]

https://docs.google.com/document/d/1IoF--pWXXqjrAXSgBLVY3dRC-PeDcPZZxhCnl0wlaP8/edit

Management of Repositories

Presented by Brad Buckingham



For Sync Selected button - I think we were discussing buttons changing to 
Actions with drop down. 

Create Sync Plan - Button is not stylized to standard, and sync plan is not 
in line.

Day and time switcher is not patternfly 
(http://www.patternfly.org/pattern-library/forms-and-controls/timepicker/#/api)

Once sync plan is created you are left at the product page -- not at Create 
Product Page.. suggest putting in modal since the process is not multi-step 
and short.


Error messaging is not standard.



No products, should not be in a messaging box.

Action Button only has two options. Either change to “Action” with 
remaining to options or breakout into two buttons.

Remove dividing line after search


Upload vs. Save… original create GPG Key has different buttons than edit 
mode. Make the same to reduce confusion. I would recommend removing the 
upload button and sticking with Save since that pattern is also found in 
product creation.


Move help text to help icon/tooltip.

Form field label should be to the left of form.

Additional thought: If the form wasn’t limited to this area the text could 
be expanded more and this would reduce the length of this form.

On highlight text is not visible in Content column.

Blue Upload button vs. Sync now?

Fix layout here.  I can provide a layout for this.


Add Repository Column instead of drop down. 



Help icon should be moved to Upgradeable and be visible all the time.

Application help icon doesn’t follow the help icon for other tooltips.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Weekly Design/Dev MeetingL Content Views

[Walden Raines]

Thanks for compiling this list.  I have either filed issues, linked to
issues, or asked clarifying questions below.

Thanks,
Walden


> Create New Version button should be blue.

http://projects.theforeman.org/issues/19282

> Sync Status should be icon - When blue hover is active you cannot see
status

What icon would you suggest here?

> List/Remove/Add -- Can these be added together? Will work on some design
concepts.

I would love to see these pages combined.

> Also - second row tabs are usually line style, not box style. (
http://www.patternfly.org/pattern-library/widgets/#tabs)

Even when there is spacing between them?  In this case there is an 
between the tabs.

> Reduce redundancy of always use latest and specific version. Filtering
for use latest?

What if we added "use latest" as its own column?

> Space between tabs… too crowded.


But even on http://www.patternfly.org/pattern-library/widgets/#tabs there
is no space.  I think we need PF to address this use case rather than me
adding custom styling into katello.


> Security icon should be red with capitalized S

Not sure what you are talking about here.  I don't see the word security in
the screenshot.

> Can Affected Repositories be included into building a filter?

As in part of a wizard or something?  Maybe but the user will still need
the ability to edit these post filter creation.

> Use PF Calendar. (http://www.patternfly.org/pattern-library/forms-and-
controls/datepicker/)

http://projects.theforeman.org/issues/17667

> Success item should have icon

What icon should be used for this?

> If Publish New Version is main item, make blue and break out other items.
Otherwise relabel actions with drop down (I believe this is what we are
moving forward with in other parts of the UI).

http://projects.theforeman.org/issues/19287

> “De” and “dev-2” are serif typeface. Change to match other step typefaces

http://projects.theforeman.org/issues/19139
> User Help icon for help text on Composite View.

Instead of using the bs3 standard help text that appears under form fields?

> Edit view is the same as previous content view?
> Can we use this same “Always Use Latest” drop down on the previous
content views

http://projects.theforeman.org/issues/19286

> If there is no data, put statement that there is no content, do not use
inline message box.

Is there a pattern for this?  What styling should this comment use?

> Grey box should be error and appear on checkbox click. Change button to
Cancel or Submit

This was handled as part of http://projects.theforeman.org/issues/19166

> Organization dropdown doesn’t match patternfly

http://projects.theforeman.org/issues/19285

>  New layout that communicates changes better. This is too generic.

What do you mean by this?

> Placement of buttons poor

http://projects.theforeman.org/issues/19166

> This wizard doesn’t have steps, introduce new wizard.

http://projects.theforeman.org/issues/17345

> Table scrolls which is unusual instead of pagination or longer page scroll

This is fixed now in master, all tables now use pagination.

> Date is not handled consistently in tables (I know this is being
addressed)

I am unaware of and date consistency work, maybe in Foreman?

> Add additional information to bar, lets see the numbers especially on
failure. Do we want to keep mimicking dynaflow?

What additional information should we add here?

> Number of column headers and columns do not match.

http://projects.theforeman.org/issues/19283

On Wed, Apr 12, 2017 at 2:39 PM, Roxanne Hoover  wrote:

> https://docs.google.com/document/d/1Oqh0o676iS6ME9gGBPGCs-
> ToL8yDM882bIJZNNYcfOo/edit
>
>
>
> Dev/Design Weekly Review - Content Views
>
> Presented by Brad Buckingham
>
>
>
>
>
>
> Create New Version button should be blue.
>
> Sync Status should be icon - When blue hover is active you cannot see
> status
>
>
>
>
> List/Remove/Add -- Can these be added together? Will work on some design
> concepts.
>
> Also - second row tabs are usually line style, not box style. (
> http://www.patternfly.org/pattern-library/widgets/#tabs)
>
>
> Reduce redundancy of always use latest and specific version. Filtering for
> use latest?
>
> Space between tabs… too crowded.
>
> Security icon should be red with capitalized S
>
> Can Affected Repositories be included into building a filter?
>
>
>
> Use PF Calendar. (http://www.patternfly.org/pattern-library/forms-and-
> controls/datepicker/)
>
> Success item should have icon
>
> If Publish New Version is main item, make blue and break out other items.
> Otherwise relabel actions with drop down (I believe this is what we are
> moving forward with in other parts of the UI).
>
>
> “De” and “dev-2” are serif typeface. Change to match other step typefaces
>
> This life cycle graphic breaks frequently… I will work on an alternate
> design.
>
>
> User Help icon for help text on Composite View.
>
>
> Can we use this same “Always Use Latest” drop down on the previous content
> views
>
> -Edit view is 

Re: [foreman-dev] Weekly Design/Dev MeetingL Content Views

[Roxanne Hoover]

On Monday, April 17, 2017 at 12:57:50 PM UTC-4, Walden Raines wrote:
>
> Thanks for compiling this list.  I have either filed issues, linked to 
> issues, or asked clarifying questions below.
>
> Thanks,
> Walden
>
>
> > Create New Version button should be blue.
>
> http://projects.theforeman.org/issues/19282
>
> > Sync Status should be icon - When blue hover is active you cannot see 
> status
>
> What icon would you suggest here?
> Depends on the status... but usually we're using the green/yellow/grey 
> colors with either dots or checks, errors or warning icons.
>
 

> > List/Remove/Add -- Can these be added together? Will work on some 
> design concepts.
>
> I would love to see these pages combined.
> I've got it on my list to work on this component. I'll be sure to send any 
> ideas over to you for feasibility and feedback.
>
 

> > Also - second row tabs are usually line style, not box style. (
> http://www.patternfly.org/pattern-library/widgets/#tabs 
> 
> )
>
> Even when there is spacing between them?  In this case there is an  
> between the tabs.
>
I think the pattern calls for the line style when they are secondary to the 
main tab (which I think is the case here). As a side note, I'm seeing 
instances where main tabs are going onto second rows, that is not ideal. No 
comment on solution, just observation.

>
> > Reduce redundancy of always use latest and specific version. Filtering 
> for use latest?
>
> What if we added "use latest" as its own column?
>
+1 

>
>
> > Space between tabs… too crowded. 
>
>
> But even on http://www.patternfly.org/pattern-library/widgets/#tabs there 
> is no space.  I think we need PF to address this use case rather than me 
> adding custom styling into katello.
>
I don't disagree. I also think the issue I mentioned before of tabs flowing 
to second row contribute to this spacing issue. 

>
> > Security icon should be red with capitalized S
>
> Not sure what you are talking about here.  I don't see the word security 
> in the screenshot.
>
Sorry - my mistake, I try to take notes while taking screenshots at the 
same time. Looks like I may have misplaced something. 

>
> > Can Affected Repositories be included into building a filter?
>
> As in part of a wizard or something?  Maybe but the user will still need 
> the ability to edit these post filter creation.
>
> > Use PF Calendar. (
> http://www.patternfly.org/pattern-library/forms-and-controls/datepicker/)
>
> http://projects.theforeman.org/issues/17667
>
> > Success item should have icon
>
> What icon should be used for this?
>
See previous icon answer. I think the bigger issue is being consistent on 
how we handle status and having good reason when we deviate. Sometimes now 
I see icons, words, etc.  

>
> > If Publish New Version is main item, make blue and break out other 
> items. Otherwise relabel actions with drop down (I believe this is what we 
> are moving forward with in other parts of the UI).
>
> http://projects.theforeman.org/issues/19287
>
> > “De” and “dev-2” are serif typeface. Change to match other step 
> typefaces
>
> http://projects.theforeman.org/issues/19139
> > User Help icon for help text on Composite View.
>
> Instead of using the bs3 standard help text that appears under form fields?
>
I've been going with our field level help 
(http://www.patternfly.org/pattern-library/forms-and-controls/field-level-help/).
 
BTW - that icon is not updated... 

>  
>

>
> > Edit view is the same as previous content view?
> > Can we use this same “Always Use Latest” drop down on the previous 
> content views
>
> http://projects.theforeman.org/issues/19286
>
> > If there is no data, put statement that there is no content, do not use 
> inline message box.
>
> Is there a pattern for this?  What styling should this comment use?
>
I don't think PatternFly has a pattern. I can mock something up if you'd 
like. I don't like using the messaging box because it starts diluting the 
purpose of that box.

>
> > Grey box should be error and appear on checkbox click. Change button to 
> Cancel or Submit
>
> This was handled as part of http://projects.theforeman.org/issues/19166
>
> > Organization dropdown doesn’t match patternfly
>
> http://projects.theforeman.org/issues/19285
>
> >  New layout that communicates changes better. This is too generic.
>
> What do you mean by this?
>
I can do a layout. I think the page information lacks visual hierarchy.  

>
>
> > Placement of buttons poor
>
> http://projects.theforeman.org/issues/19166
>
> > This wizard doesn’t have steps, introduce new wizard.
>
> http://projects.theforeman.org/issues/17345
>
> > Table scrolls which is unusual instead of pagination or longer page 
> scroll
>
> This is fixed now in master, all tables now use pagination.
>
> > Date is not handled consistently in tables (I know this is being 
> addressed)