[foreman-dev] Katello CI red due to recent foreman-tasks release

2017-09-12 Thread Ivan Necas
Hi,

We've pushed new version of foreman-tasks, that included the last
piece of transition of Dynfow into the core. Unfortunately (or rather
fortunately
- better in CI than in production:) the Katello tests discovered one
issue in the
way the transition of the Dynflow initialization was made.

It caused the Katello tests to fail on

ActiveRecord::StatementInvalid: PG::ObjectInUse: ERROR:  database
"test_develop_pr_katello-2-test" is being accessed by other users

For more details, see http://projects.theforeman.org/issues/20908

The proposed fix to the foreman repo is here:
https://github.com/theforeman/foreman/pull/4826/files

Reviews more than welcome

-- Ivan

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Plugin gems with a single author

2017-09-12 Thread Marek Hulán
On pondělí 11. září 2017 14:02:06 CEST Greg Sutcliffe wrote:
> On Sun, 2017-08-20 at 16:33 +0200, Timo Goebel wrote:
> > I'd also be interested in helping with foreman_bootdisk. Although
> > it's sad to see, it looks like Dominic isn't maintaining this at all
> > anymore.
> 
> On Mon, 2017-08-21 at 09:19 +0200, Lukas Zapletal wrote:
> > I also have some knowledge of bootdisk and hooks.
> 
> With no response here, or on various pull requests [1,2] in some
> months, would anyone object if I add Lukas and Timo to the bootdisk
> plugin on GitHub? They could then review each others work as we
> normally do.
> 
> [1] https://github.com/theforeman/foreman_bootdisk/pull/42#issuecomment
> -314787206
> [2] https://github.com/theforeman/foreman_bootdisk/pull/43#issuecomment
> -316937459
> 
> Greg

Makes sense to me

--
Marek

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Permissions cleanup

2017-09-12 Thread Marek Hulán
On pondělí 11. září 2017 13:41:02 CEST Greg Sutcliffe wrote:
> Hi all,
> 
> In the context of the plugins-bus-factor discussion, etc, it occurred
> to me that we still have a lot of people with access who aren't really
> active any more - this can make it hard to see where action is needed.
> 
> We've never really done a permissions cleanup before, so I thought it
> might be time. Here's a list of people / things I found that I'd like
> to fix. I've tried to keep this to core and related stuff, as plugins
> are free to handle their own affairs, to a large extent (also the list
> would be huge). In vaguely alphabetical order then:
> 
> * Amos Benari:
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - rfcs
> - smart-proxy
> - theforeman.org
> * Brian Gupta:
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - hammer_cli
> - rfcs
> - smart-proxy
>   * Remove Admin level on Redmine, last login, Apr 2015
>   * Brandorr (Brian's org) also has an SSH key for the infra. Since we
> still host some stuff with them, let's leave that for now.
> * Dominic Cleal:
>   * GitHub - Owner status:
>   While commit access lasts for a year, Dom has not been seen on
>   the mailing lists, Redmine, or Github since May/June (with the
>   exception of a single commit in July). In the context of having
>   active owners that we discussed previously, I propose we demote
>   him from owner level.
> * Joseph Magen (istratrade):
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - rfcs
> - smart-proxy
> * Corey Osman (logicminds):
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - rfcs
> - smart-proxy
> * Sam Kottler:
>   * Github: no commits in over a year, remove commit on
> - foreman-installer
> - foreman-packaging
> - foreman-infra
> - community-templates
> - kafo
> - foreman-bats
> - redmine (our fork)
> - prprocessor
> - jenkins-job-builder (our fork)
>   * Remove SSH key on infra
> 
> There's probably more, but that's a first pass. Thoughts?
> 
> Greg

+1, thanks for doing this! At some point we should review plugins too, maybe 
just suggest changes to de facto maintainers.

--
Marek


-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Problems with Katello Bastion UI when changing Foreman base URL

2017-09-12 Thread Ewoud Kohl van Wijngaarden

That's good to know. Added a comment about the JQuery ajax calls.

On Tue, Sep 12, 2017 at 09:57:43AM -0400, Walden Raines wrote:

See also issue #20313 [1] which has an open PR [2].

Cheers,
Walden

[1] http://projects.theforeman.org/issues/20313
[2] https://github.com/Katello/bastion/pull/206

On Tue, Sep 12, 2017 at 8:18 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:


Hello Gerrit,

You're right that a lot assumes a static location. Katello has much more
assumptions in this area than vanilla Foreman and while there is an effort
to at least be able to split services onto different hosts where we might
tackle some assumptions in the process there is a long way to go.

For now I'd advise you to use a separate vhost and use DNS, separate IP
and/or port for your own application because it sounds like that's more
relocatable.

On Tue, Sep 12, 2017 at 05:07:13AM -0700, gerrit.schwerth...@avid.com
wrote:


Hello Ewoud,

thanks for your informative and quick answer. As it looks to me that the
required changes are touching quite a lot of sensitive points (from which
many are not yet identified?), I think it's better for me not to continue
with my undertaking and not to touch the sources.

For now, I will the just redirect ^/$ with httpd to point to an alias of
where my own service sits. This way, only the dashboard of Foreman cannot
be reached anymore, but the rest of Foreman and Katello is still intact
and
seems to work for everything I need.

I also already tried running Foreman in production on non-default ports,
but it seems like this is even causing more issues as there seem to be
some
hard coded ports for the communication with Pulp in the sources (like
https://github.com/Katello/katello/blob/6aca54157e579d6312a9
e4a49609df0ffa1685b1/app/services/katello/proxy_status/pulp.rb#L45).

If you have any other ideas I could try out, I would be very grateful if
you share them with me.

Many thanks and regards,

--Gerrit


On Tuesday, September 12, 2017 at 12:29:05 PM UTC+2, Ewoud Kohl van
Wijngaarden wrote:



On Tue, Sep 12, 2017 at 02:56:06AM -0700, gerrit.sc...@avid.com
 wrote:
>I am having a setup where I use Foreman as a complete backend service.
>Another service works on the document root of the HTTPD server. In order
to
>have all pages of Foreman still reachable, I tried altering the base URL
of
>Foreman by changing the value for the foreman_url in the
foreman-installer.
>This is working great so far, all pages of Foreman now changed to
>https:///foreman, all API calls are working fine.
>
>However, when I try to visit a Katello page like content views or
products,
>the page cannot load and it ends up in an endless loop. I can provide
more
>detailed logging output if required, but as far as I can see, there is
not
>much information that can be found in the logs.
>
>Did anyone ever try changing the base URL and ran into this issue? Is
there
>a possibility to configure Katello such that the pages work with an
altered
>base? Is there maybe a setting in the foreman-installer that I need to
>change to make it work?
>
>Thanks for reading and all the best,

https://github.com/Katello/puppet-katello/pull/211 was merged just last
week so I'm guessing few people do. There may be other dragons hiding
because deployment_url is considered relative in post_sync_url now but
in candlepin it might have been considered absolute so I dug in deeper
(as I should have when I merged 211) and it looks like the whole
deployment_url is unused in puppet-candlepin and we should just remove
that part. https://github.com/Katello/puppet-candlepin/pull/82 together
with https://github.com/Katello/puppet-katello/pull/214 should take care
of that.

Looking through the source then I see some examples that should work but
many that do not. What should work is using the foreman_url helper like

https://github.com/Katello/katello/blob/b02526bea7026560b2d6
d66fac9038cfeb74bab9/app/assets/javascripts/katello/
hosts/activation_key_edit.js#L22

What doesn't work is plain URLs like

https://github.com/Katello/katello/blob/b02526bea7026560b2d6
d66fac9038cfeb74bab9/app/assets/javascripts/katello/
hosts/host_and_hostgroup_edit.js#L28

In short: I think you're entering uncharted/unsupported territory.



--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send 

Re: [foreman-dev] Problems with Katello Bastion UI when changing Foreman base URL

2017-09-12 Thread Walden Raines
See also issue #20313 [1] which has an open PR [2].

Cheers,
Walden

[1] http://projects.theforeman.org/issues/20313
[2] https://github.com/Katello/bastion/pull/206

On Tue, Sep 12, 2017 at 8:18 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:

> Hello Gerrit,
>
> You're right that a lot assumes a static location. Katello has much more
> assumptions in this area than vanilla Foreman and while there is an effort
> to at least be able to split services onto different hosts where we might
> tackle some assumptions in the process there is a long way to go.
>
> For now I'd advise you to use a separate vhost and use DNS, separate IP
> and/or port for your own application because it sounds like that's more
> relocatable.
>
> On Tue, Sep 12, 2017 at 05:07:13AM -0700, gerrit.schwerth...@avid.com
> wrote:
>
>> Hello Ewoud,
>>
>> thanks for your informative and quick answer. As it looks to me that the
>> required changes are touching quite a lot of sensitive points (from which
>> many are not yet identified?), I think it's better for me not to continue
>> with my undertaking and not to touch the sources.
>>
>> For now, I will the just redirect ^/$ with httpd to point to an alias of
>> where my own service sits. This way, only the dashboard of Foreman cannot
>> be reached anymore, but the rest of Foreman and Katello is still intact
>> and
>> seems to work for everything I need.
>>
>> I also already tried running Foreman in production on non-default ports,
>> but it seems like this is even causing more issues as there seem to be
>> some
>> hard coded ports for the communication with Pulp in the sources (like
>> https://github.com/Katello/katello/blob/6aca54157e579d6312a9
>> e4a49609df0ffa1685b1/app/services/katello/proxy_status/pulp.rb#L45).
>>
>> If you have any other ideas I could try out, I would be very grateful if
>> you share them with me.
>>
>> Many thanks and regards,
>>
>> --Gerrit
>>
>>
>> On Tuesday, September 12, 2017 at 12:29:05 PM UTC+2, Ewoud Kohl van
>> Wijngaarden wrote:
>>
>>>
>>> On Tue, Sep 12, 2017 at 02:56:06AM -0700, gerrit.sc...@avid.com
>>>  wrote:
>>> >I am having a setup where I use Foreman as a complete backend service.
>>> >Another service works on the document root of the HTTPD server. In order
>>> to
>>> >have all pages of Foreman still reachable, I tried altering the base URL
>>> of
>>> >Foreman by changing the value for the foreman_url in the
>>> foreman-installer.
>>> >This is working great so far, all pages of Foreman now changed to
>>> >https:///foreman, all API calls are working fine.
>>> >
>>> >However, when I try to visit a Katello page like content views or
>>> products,
>>> >the page cannot load and it ends up in an endless loop. I can provide
>>> more
>>> >detailed logging output if required, but as far as I can see, there is
>>> not
>>> >much information that can be found in the logs.
>>> >
>>> >Did anyone ever try changing the base URL and ran into this issue? Is
>>> there
>>> >a possibility to configure Katello such that the pages work with an
>>> altered
>>> >base? Is there maybe a setting in the foreman-installer that I need to
>>> >change to make it work?
>>> >
>>> >Thanks for reading and all the best,
>>>
>>> https://github.com/Katello/puppet-katello/pull/211 was merged just last
>>> week so I'm guessing few people do. There may be other dragons hiding
>>> because deployment_url is considered relative in post_sync_url now but
>>> in candlepin it might have been considered absolute so I dug in deeper
>>> (as I should have when I merged 211) and it looks like the whole
>>> deployment_url is unused in puppet-candlepin and we should just remove
>>> that part. https://github.com/Katello/puppet-candlepin/pull/82 together
>>> with https://github.com/Katello/puppet-katello/pull/214 should take care
>>> of that.
>>>
>>> Looking through the source then I see some examples that should work but
>>> many that do not. What should work is using the foreman_url helper like
>>>
>>> https://github.com/Katello/katello/blob/b02526bea7026560b2d6
>>> d66fac9038cfeb74bab9/app/assets/javascripts/katello/
>>> hosts/activation_key_edit.js#L22
>>>
>>> What doesn't work is plain URLs like
>>>
>>> https://github.com/Katello/katello/blob/b02526bea7026560b2d6
>>> d66fac9038cfeb74bab9/app/assets/javascripts/katello/
>>> hosts/host_and_hostgroup_edit.js#L28
>>>
>>> In short: I think you're entering uncharted/unsupported territory.
>>>
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more 

Re: [foreman-dev] Permissions cleanup

2017-09-12 Thread Daniel Lobato Garcia
On 09/11, Greg Sutcliffe wrote:
> Hi all,
>
> In the context of the plugins-bus-factor discussion, etc, it occurred
> to me that we still have a lot of people with access who aren't really
> active any more - this can make it hard to see where action is needed.
>
> We've never really done a permissions cleanup before, so I thought it
> might be time. Here's a list of people / things I found that I'd like
> to fix. I've tried to keep this to core and related stuff, as plugins
> are free to handle their own affairs, to a large extent (also the list
> would be huge). In vaguely alphabetical order then:
>
> * Amos Benari:
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - rfcs
> - smart-proxy
> - theforeman.org
> * Brian Gupta:
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - hammer_cli
> - rfcs
> - smart-proxy
>   * Remove Admin level on Redmine, last login, Apr 2015
>   * Brandorr (Brian's org) also has an SSH key for the infra. Since we
> still host some stuff with them, let's leave that for now.
> * Dominic Cleal:
>   * GitHub - Owner status:
>   While commit access lasts for a year, Dom has not been seen on
>   the mailing lists, Redmine, or Github since May/June (with the
>   exception of a single commit in July). In the context of having
>   active owners that we discussed previously, I propose we demote
>   him from owner level.
> * Joseph Magen (istratrade):
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - rfcs
> - smart-proxy
> * Corey Osman (logicminds):
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - rfcs
> - smart-proxy
> * Sam Kottler:
>   * Github: no commits in over a year, remove commit on
> - foreman-installer
> - foreman-packaging
> - foreman-infra
> - community-templates
> - kafo
> - foreman-bats
> - redmine (our fork)
> - prprocessor
> - jenkins-job-builder (our fork)
>   * Remove SSH key on infra
>
> There's probably more, but that's a first pass. Thoughts?

+1 to all

--
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature


Re: [foreman-dev] Problems with Katello Bastion UI when changing Foreman base URL

2017-09-12 Thread Ewoud Kohl van Wijngaarden

Hello Gerrit,

You're right that a lot assumes a static location. Katello has much more 
assumptions in this area than vanilla Foreman and while there is an 
effort to at least be able to split services onto different hosts where 
we might tackle some assumptions in the process there is a long way to 
go.


For now I'd advise you to use a separate vhost and use DNS, separate 
IP and/or port for your own application because it sounds like that's 
more relocatable.


On Tue, Sep 12, 2017 at 05:07:13AM -0700, gerrit.schwerth...@avid.com wrote:

Hello Ewoud,

thanks for your informative and quick answer. As it looks to me that the
required changes are touching quite a lot of sensitive points (from which
many are not yet identified?), I think it's better for me not to continue
with my undertaking and not to touch the sources.

For now, I will the just redirect ^/$ with httpd to point to an alias of
where my own service sits. This way, only the dashboard of Foreman cannot
be reached anymore, but the rest of Foreman and Katello is still intact and
seems to work for everything I need.

I also already tried running Foreman in production on non-default ports,
but it seems like this is even causing more issues as there seem to be some
hard coded ports for the communication with Pulp in the sources (like
https://github.com/Katello/katello/blob/6aca54157e579d6312a9e4a49609df0ffa1685b1/app/services/katello/proxy_status/pulp.rb#L45).

If you have any other ideas I could try out, I would be very grateful if
you share them with me.

Many thanks and regards,

--Gerrit


On Tuesday, September 12, 2017 at 12:29:05 PM UTC+2, Ewoud Kohl van
Wijngaarden wrote:


On Tue, Sep 12, 2017 at 02:56:06AM -0700, gerrit.sc...@avid.com
 wrote:
>I am having a setup where I use Foreman as a complete backend service.
>Another service works on the document root of the HTTPD server. In order
to
>have all pages of Foreman still reachable, I tried altering the base URL
of
>Foreman by changing the value for the foreman_url in the
foreman-installer.
>This is working great so far, all pages of Foreman now changed to
>https:///foreman, all API calls are working fine.
>
>However, when I try to visit a Katello page like content views or
products,
>the page cannot load and it ends up in an endless loop. I can provide
more
>detailed logging output if required, but as far as I can see, there is
not
>much information that can be found in the logs.
>
>Did anyone ever try changing the base URL and ran into this issue? Is
there
>a possibility to configure Katello such that the pages work with an
altered
>base? Is there maybe a setting in the foreman-installer that I need to
>change to make it work?
>
>Thanks for reading and all the best,

https://github.com/Katello/puppet-katello/pull/211 was merged just last
week so I'm guessing few people do. There may be other dragons hiding
because deployment_url is considered relative in post_sync_url now but
in candlepin it might have been considered absolute so I dug in deeper
(as I should have when I merged 211) and it looks like the whole
deployment_url is unused in puppet-candlepin and we should just remove
that part. https://github.com/Katello/puppet-candlepin/pull/82 together
with https://github.com/Katello/puppet-katello/pull/214 should take care
of that.

Looking through the source then I see some examples that should work but
many that do not. What should work is using the foreman_url helper like

https://github.com/Katello/katello/blob/b02526bea7026560b2d6d66fac9038cfeb74bab9/app/assets/javascripts/katello/hosts/activation_key_edit.js#L22

What doesn't work is plain URLs like

https://github.com/Katello/katello/blob/b02526bea7026560b2d6d66fac9038cfeb74bab9/app/assets/javascripts/katello/hosts/host_and_hostgroup_edit.js#L28

In short: I think you're entering uncharted/unsupported territory.



--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Permissions cleanup

2017-09-12 Thread Tomer Brisker
+1.

However, should any of them decide to return to activity, I believe that
their previous rights should be reinstated.

On Tue, Sep 12, 2017 at 2:50 PM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:

> On Mon, Sep 11, 2017 at 12:41:02PM +0100, Greg Sutcliffe wrote:
>
>> In the context of the plugins-bus-factor discussion, etc, it occurred
>> to me that we still have a lot of people with access who aren't really
>> active any more - this can make it hard to see where action is needed.
>>
>> We've never really done a permissions cleanup before, so I thought it
>> might be time. Here's a list of people / things I found that I'd like
>> to fix. I've tried to keep this to core and related stuff, as plugins
>> are free to handle their own affairs, to a large extent (also the list
>> would be huge). In vaguely alphabetical order then:
>>
>> * Amos Benari:
>>  * Github: no commits in over a year, remove commit on
>>- community-templates
>>- foreman
>>- rfcs
>>- smart-proxy
>>- theforeman.org
>> * Brian Gupta:
>>  * Github: no commits in over a year, remove commit on
>>- community-templates
>>- foreman
>>- foreman-selinux
>>- hammer_cli
>>- rfcs
>>- smart-proxy
>>  * Remove Admin level on Redmine, last login, Apr 2015
>>  * Brandorr (Brian's org) also has an SSH key for the infra. Since we
>>still host some stuff with them, let's leave that for now.
>> * Dominic Cleal:
>>  * GitHub - Owner status:
>>  While commit access lasts for a year, Dom has not been seen on
>>  the mailing lists, Redmine, or Github since May/June (with the
>>  exception of a single commit in July). In the context of having
>>  active owners that we discussed previously, I propose we demote
>>  him from owner level.
>> * Joseph Magen (istratrade):
>>  * Github: no commits in over a year, remove commit on
>>- community-templates
>>- foreman
>>- foreman-selinux
>>- rfcs
>>- smart-proxy
>> * Corey Osman (logicminds):
>>  * Github: no commits in over a year, remove commit on
>>- community-templates
>>- foreman
>>- foreman-selinux
>>- rfcs
>>- smart-proxy
>> * Sam Kottler:
>>  * Github: no commits in over a year, remove commit on
>>- foreman-installer
>>- foreman-packaging
>>- foreman-infra
>>- community-templates
>>- kafo
>>- foreman-bats
>>- redmine (our fork)
>>- prprocessor
>>- jenkins-job-builder (our fork)
>>  * Remove SSH key on infra
>>
>> There's probably more, but that's a first pass. Thoughts?
>>
>
> +1
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Permissions cleanup

2017-09-12 Thread Ewoud Kohl van Wijngaarden

On Mon, Sep 11, 2017 at 12:41:02PM +0100, Greg Sutcliffe wrote:

In the context of the plugins-bus-factor discussion, etc, it occurred
to me that we still have a lot of people with access who aren't really
active any more - this can make it hard to see where action is needed.

We've never really done a permissions cleanup before, so I thought it
might be time. Here's a list of people / things I found that I'd like
to fix. I've tried to keep this to core and related stuff, as plugins
are free to handle their own affairs, to a large extent (also the list
would be huge). In vaguely alphabetical order then:

* Amos Benari:
 * Github: no commits in over a year, remove commit on
   - community-templates
   - foreman
   - rfcs
   - smart-proxy
   - theforeman.org
* Brian Gupta:
 * Github: no commits in over a year, remove commit on
   - community-templates
   - foreman
   - foreman-selinux
   - hammer_cli
   - rfcs
   - smart-proxy
 * Remove Admin level on Redmine, last login, Apr 2015
 * Brandorr (Brian's org) also has an SSH key for the infra. Since we
   still host some stuff with them, let's leave that for now.
* Dominic Cleal:
 * GitHub - Owner status:
 While commit access lasts for a year, Dom has not been seen on
 the mailing lists, Redmine, or Github since May/June (with the
 exception of a single commit in July). In the context of having
 active owners that we discussed previously, I propose we demote
 him from owner level.
* Joseph Magen (istratrade):
 * Github: no commits in over a year, remove commit on
   - community-templates
   - foreman
   - foreman-selinux
   - rfcs
   - smart-proxy
* Corey Osman (logicminds):
 * Github: no commits in over a year, remove commit on
   - community-templates
   - foreman
   - foreman-selinux
   - rfcs
   - smart-proxy
* Sam Kottler:
 * Github: no commits in over a year, remove commit on
   - foreman-installer
   - foreman-packaging
   - foreman-infra
   - community-templates
   - kafo
   - foreman-bats
   - redmine (our fork)
   - prprocessor
   - jenkins-job-builder (our fork)
 * Remove SSH key on infra

There's probably more, but that's a first pass. Thoughts?


+1

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Problems with Katello Bastion UI when changing Foreman base URL

2017-09-12 Thread Ewoud Kohl van Wijngaarden

On Tue, Sep 12, 2017 at 02:56:06AM -0700, gerrit.schwerth...@avid.com wrote:

I am having a setup where I use Foreman as a complete backend service.
Another service works on the document root of the HTTPD server. In order to
have all pages of Foreman still reachable, I tried altering the base URL of
Foreman by changing the value for the foreman_url in the foreman-installer.
This is working great so far, all pages of Foreman now changed to
https:///foreman, all API calls are working fine.

However, when I try to visit a Katello page like content views or products,
the page cannot load and it ends up in an endless loop. I can provide more
detailed logging output if required, but as far as I can see, there is not
much information that can be found in the logs.

Did anyone ever try changing the base URL and ran into this issue? Is there
a possibility to configure Katello such that the pages work with an altered
base? Is there maybe a setting in the foreman-installer that I need to
change to make it work?

Thanks for reading and all the best,


https://github.com/Katello/puppet-katello/pull/211 was merged just last 
week so I'm guessing few people do. There may be other dragons hiding 
because deployment_url is considered relative in post_sync_url now but 
in candlepin it might have been considered absolute so I dug in deeper 
(as I should have when I merged 211) and it looks like the whole 
deployment_url is unused in puppet-candlepin and we should just remove 
that part. https://github.com/Katello/puppet-candlepin/pull/82 together 
with https://github.com/Katello/puppet-katello/pull/214 should take care 
of that.


Looking through the source then I see some examples that should work but 
many that do not. What should work is using the foreman_url helper like 
https://github.com/Katello/katello/blob/b02526bea7026560b2d6d66fac9038cfeb74bab9/app/assets/javascripts/katello/hosts/activation_key_edit.js#L22


What doesn't work is plain URLs like
https://github.com/Katello/katello/blob/b02526bea7026560b2d6d66fac9038cfeb74bab9/app/assets/javascripts/katello/hosts/host_and_hostgroup_edit.js#L28

In short: I think you're entering uncharted/unsupported territory.

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Permissions cleanup

2017-09-12 Thread Ohad Levy
On Mon, Sep 11, 2017 at 2:41 PM, Greg Sutcliffe 
wrote:

> Hi all,
>
> In the context of the plugins-bus-factor discussion, etc, it occurred
> to me that we still have a lot of people with access who aren't really
> active any more - this can make it hard to see where action is needed.
>
> We've never really done a permissions cleanup before, so I thought it
> might be time. Here's a list of people / things I found that I'd like
> to fix. I've tried to keep this to core and related stuff, as plugins
> are free to handle their own affairs, to a large extent (also the list
> would be huge). In vaguely alphabetical order then:
>

> * Amos Benari:
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - rfcs
> - smart-proxy
> - theforeman.org
> * Brian Gupta:
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - hammer_cli
> - rfcs
> - smart-proxy
>   * Remove Admin level on Redmine, last login, Apr 2015
>   * Brandorr (Brian's org) also has an SSH key for the infra. Since we
> still host some stuff with them, let's leave that for now.
> * Dominic Cleal:
>   * GitHub - Owner status:
>   While commit access lasts for a year, Dom has not been seen on
>   the mailing lists, Redmine, or Github since May/June (with the
>   exception of a single commit in July). In the context of having
>   active owners that we discussed previously, I propose we demote
>   him from owner level.
> * Joseph Magen (istratrade):
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - rfcs
> - smart-proxy
> * Corey Osman (logicminds):
>   * Github: no commits in over a year, remove commit on
> - community-templates
> - foreman
> - foreman-selinux
> - rfcs
> - smart-proxy
> * Sam Kottler:
>   * Github: no commits in over a year, remove commit on
> - foreman-installer
> - foreman-packaging
> - foreman-infra
> - community-templates
> - kafo
> - foreman-bats
> - redmine (our fork)
> - prprocessor
> - jenkins-job-builder (our fork)
>   * Remove SSH key on infra
>
> There's probably more, but that's a first pass. Thoughts?
>

Thanks, this effort make sense to me +1 to all of the above.

Ohad

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Problems with Katello Bastion UI when changing Foreman base URL

2017-09-12 Thread gerrit . schwerthelm
Hey all,

I am having a setup where I use Foreman as a complete backend service. 
Another service works on the document root of the HTTPD server. In order to 
have all pages of Foreman still reachable, I tried altering the base URL of 
Foreman by changing the value for the foreman_url in the foreman-installer. 
This is working great so far, all pages of Foreman now changed to 
https:///foreman, all API calls are working fine. 

However, when I try to visit a Katello page like content views or products, 
the page cannot load and it ends up in an endless loop. I can provide more 
detailed logging output if required, but as far as I can see, there is not 
much information that can be found in the logs.

Did anyone ever try changing the base URL and ran into this issue? Is there 
a possibility to configure Katello such that the pages work with an altered 
base? Is there maybe a setting in the foreman-installer that I need to 
change to make it work?

Thanks for reading and all the best,

--Gerrit

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.