Re: [foreman-dev] request for write-access to katello-packaging

2017-09-21 Thread John Mitsch
+1 from me, you've been a great help at reviewing the katello scripts!

-John

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Thu, Sep 21, 2017 at 12:00 PM, Evgeni Golov  wrote:

> Ohai,
>
> I would like to request write access to katello-packaging.
>
> I have 14 merged PRs [1] resulting in 14 commits [2].
> If I count it right, I also somehow reviewed 19 PRs [3].
>
> TIA
> Evgeni
>
> [1] https://github.com/Katello/katello-packaging/pulls?page=
> 1&q=is%3Apr+author%3Aevgeni&utf8=%E2%9C%93
> [2] https://github.com/Katello/katello-packaging/commits?author=evgeni
> [3] https://github.com/Katello/katello-packaging/pulls?utf8=%
> E2%9C%93&q=involves%3Aevgeni%20is%3Apr%20
>
>
> --
> Beste Grüße/Kind regards,
>
> Evgeni Golov
> Software Engineer
> 
> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Charles Cachera, Michael Cunningham, Michael
> O'Neill, Eric Shander
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Help needed: Discovery develop broken (Rails 5)

2017-09-21 Thread Lukas Zapletal
Tests are green, let's merge this, big thanks for help.

LZ

On Thu, Sep 21, 2017 at 12:13 PM, Ivan Necas  wrote:
> That was exacly the reason I was sending the pr Marek referenced: will get
> to fixing the broken tests later today. Reviews welcome
>
> -- Ivan
>
> On Thu, 21 Sep 2017 at 10:19, Marek Hulán  wrote:
>>
>> On čtvrtek 21. září 2017 9:46:59 CEST Lukas Zapletal wrote:
>> > Hello,
>> >
>> > we are getting errors in discovery develop due to Rails 5 update:
>> >
>> > ActiveRecord::SubclassNotFound: Invalid single-table inheritance type:
>> > Host::Discovered is not a subclass of Host::Managed
>> >
>> >
>> > http://ci.theforeman.org/job/test_plugin_matrix/3760/database=mysql,ruby=2.4
>> >
>> > ,slave=fast/testReport/junit/(root)/DiscoveredHostsControllerTest/test_updat
>> > e_inheritance/
>> >
>> > If anyone have ideas, please help me to resolve this. There are couple
>> > of PRs pending review but I need to get tests green before. We do some
>> > weird magic in Host and some STI changes in Rails5 regressed. I have
>> > no idea.
>>
>> Have you tried Ivan's PR? [1]
>>
>> [1] https://github.com/theforeman/foreman/pull/4864
>>
>> --
>> Marek
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] request for write-access to katello-packaging

2017-09-21 Thread Evgeni Golov
Ohai,

I would like to request write access to katello-packaging.

I have 14 merged PRs [1] resulting in 14 commits [2].
If I count it right, I also somehow reviewed 19 PRs [3].

TIA
Evgeni

[1] 
https://github.com/Katello/katello-packaging/pulls?page=1&q=is%3Apr+author%3Aevgeni&utf8=%E2%9C%93
[2] https://github.com/Katello/katello-packaging/commits?author=evgeni
[3] 
https://github.com/Katello/katello-packaging/pulls?utf8=%E2%9C%93&q=involves%3Aevgeni%20is%3Apr%20


-- 
Beste Grüße/Kind regards,

Evgeni Golov
Software Engineer

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Removing old Jenkins jobs

2017-09-21 Thread Ewoud Kohl van Wijngaarden

It appears I don't have permission to delete these jobs.

On Thu, Sep 21, 2017 at 08:39:15AM -0400, Eric D Helms wrote:

+1

On Thu, Sep 21, 2017 at 8:22 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:


Hello all,

We have many old jobs in Jenkins that are no longer relevant. To make a
start I'm proposing to the delete 'installer lint and *' jobs. You can see
them at http://ci.theforeman.org/view/Installer/

As you can see they haven't been used for 3 years and it all happens on
Travis these days.

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.





--
Eric D. Helms
Red Hat Engineering

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Re: [foreman-dev] Re: Bundler is unable to solve deps for fresh checkout

2017-09-21 Thread Daniel Lobato Garcia
Eventually I changed the release_tarballs to Ruby 2.4 and it went
through.

On 09/21, Lukas Zapletal wrote:
> I just upgraded, but I think putting Gemfile.lock (even an older one
> from 1.14 stable branch) could work. Weird really.
>
> On Wed, Sep 20, 2017 at 6:57 PM, Daniel Lobato  wrote:
> > http://ci.theforeman.org/view/Release%20pipeline/job/release_tarballs
> >
> > seems to have suffered from this today (Monday 1.15.4 tarballs were built
> > just fine)
> >
> > Did you find any other way to fix this? Switching to 2.4 could be an option,
> > probably
> > putting a  Gemfile.lock on every tagged release isn't a bad idea either.
> >
> > On Thursday, September 14, 2017 at 3:13:29 PM UTC+2, Lukas Zapletal wrote:
> >>
> >> Hey,
> >>
> >> when I do fresh foreman clone with clean Ruby version (tried 2.0.0 and
> >> 2.4.1), bundle install is not able to resolve dependencies and loops
> >> forever. I am using latest stable bundler, tried also pre1 version.
> >>
> >> Can someone confirm and provide a workaround? I think copying
> >> Gemfile.lock from someone else should do it. Can someone attach a
> >> pastebin me one? I currently have my workstation down (CPU in RMA) and
> >> got clean setup.
> >>
> >> If this is confirmed, it is quite an issue for newcomers. The second
> >> command new developer is asked to execute fails hard. Any suggestions?
> >>
> >> LZ
> >>
> >> --
> >> Later,
> >>   Lukas @lzap Zapletal
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to foreman-dev+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Later,
>   Lukas @lzap Zapletal
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

--
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature


Re: [foreman-dev] Removing old Jenkins jobs

2017-09-21 Thread Eric D Helms
+1

On Thu, Sep 21, 2017 at 8:22 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:

> Hello all,
>
> We have many old jobs in Jenkins that are no longer relevant. To make a
> start I'm proposing to the delete 'installer lint and *' jobs. You can see
> them at http://ci.theforeman.org/view/Installer/
>
> As you can see they haven't been used for 3 years and it all happens on
> Travis these days.
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Removing old Jenkins jobs

2017-09-21 Thread Ewoud Kohl van Wijngaarden

Hello all,

We have many old jobs in Jenkins that are no longer relevant. To make a 
start I'm proposing to the delete 'installer lint and *' jobs. You can 
see them at http://ci.theforeman.org/view/Installer/


As you can see they haven't been used for 3 years and it all happens on 
Travis these days.


--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Help needed: Discovery develop broken (Rails 5)

2017-09-21 Thread Ivan Necas
That was exacly the reason I was sending the pr Marek referenced: will get
to fixing the broken tests later today. Reviews welcome

-- Ivan

On Thu, 21 Sep 2017 at 10:19, Marek Hulán  wrote:

> On čtvrtek 21. září 2017 9:46:59 CEST Lukas Zapletal wrote:
> > Hello,
> >
> > we are getting errors in discovery develop due to Rails 5 update:
> >
> > ActiveRecord::SubclassNotFound: Invalid single-table inheritance type:
> > Host::Discovered is not a subclass of Host::Managed
> >
> >
> http://ci.theforeman.org/job/test_plugin_matrix/3760/database=mysql,ruby=2.4
> >
> ,slave=fast/testReport/junit/(root)/DiscoveredHostsControllerTest/test_updat
> > e_inheritance/
> >
> > If anyone have ideas, please help me to resolve this. There are couple
> > of PRs pending review but I need to get tests green before. We do some
> > weird magic in Host and some STI changes in Rails5 regressed. I have
> > no idea.
>
> Have you tried Ivan's PR? [1]
>
> [1] https://github.com/theforeman/foreman/pull/4864
>
> --
> Marek
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Help needed: Discovery develop broken (Rails 5)

2017-09-21 Thread Marek Hulán
On čtvrtek 21. září 2017 9:46:59 CEST Lukas Zapletal wrote:
> Hello,
> 
> we are getting errors in discovery develop due to Rails 5 update:
> 
> ActiveRecord::SubclassNotFound: Invalid single-table inheritance type:
> Host::Discovered is not a subclass of Host::Managed
> 
> http://ci.theforeman.org/job/test_plugin_matrix/3760/database=mysql,ruby=2.4
> ,slave=fast/testReport/junit/(root)/DiscoveredHostsControllerTest/test_updat
> e_inheritance/
> 
> If anyone have ideas, please help me to resolve this. There are couple
> of PRs pending review but I need to get tests green before. We do some
> weird magic in Host and some STI changes in Rails5 regressed. I have
> no idea.

Have you tried Ivan's PR? [1]

[1] https://github.com/theforeman/foreman/pull/4864

--
Marek

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[foreman-dev] Help needed: Discovery develop broken (Rails 5)

2017-09-21 Thread Lukas Zapletal
Hello,

we are getting errors in discovery develop due to Rails 5 update:

ActiveRecord::SubclassNotFound: Invalid single-table inheritance type:
Host::Discovered is not a subclass of Host::Managed

http://ci.theforeman.org/job/test_plugin_matrix/3760/database=mysql,ruby=2.4,slave=fast/testReport/junit/(root)/DiscoveredHostsControllerTest/test_update_inheritance/

If anyone have ideas, please help me to resolve this. There are couple
of PRs pending review but I need to get tests green before. We do some
weird magic in Host and some STI changes in Rails5 regressed. I have
no idea.


-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Re: Bundler is unable to solve deps for fresh checkout

2017-09-21 Thread Lukas Zapletal
I just upgraded, but I think putting Gemfile.lock (even an older one
from 1.14 stable branch) could work. Weird really.

On Wed, Sep 20, 2017 at 6:57 PM, Daniel Lobato  wrote:
> http://ci.theforeman.org/view/Release%20pipeline/job/release_tarballs
>
> seems to have suffered from this today (Monday 1.15.4 tarballs were built
> just fine)
>
> Did you find any other way to fix this? Switching to 2.4 could be an option,
> probably
> putting a  Gemfile.lock on every tagged release isn't a bad idea either.
>
> On Thursday, September 14, 2017 at 3:13:29 PM UTC+2, Lukas Zapletal wrote:
>>
>> Hey,
>>
>> when I do fresh foreman clone with clean Ruby version (tried 2.0.0 and
>> 2.4.1), bundle install is not able to resolve dependencies and loops
>> forever. I am using latest stable bundler, tried also pre1 version.
>>
>> Can someone confirm and provide a workaround? I think copying
>> Gemfile.lock from someone else should do it. Can someone attach a
>> pastebin me one? I currently have my workstation down (CPU in RMA) and
>> got clean setup.
>>
>> If this is confirmed, it is quite an issue for newcomers. The second
>> command new developer is asked to execute fails hard. Any suggestions?
>>
>> LZ
>>
>> --
>> Later,
>>   Lukas @lzap Zapletal
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.