Re: [foreman-dev] Issue with foreman tests

[Evgeni Golov]

Ugh, sorry for making such a mess. Seems I did not test the final
version of that PR well enough.

Thanks Ewoud for fixing this!

On Mon, Oct 23, 2017 at 6:04 PM, Eric D Helms  wrote:
> In hindsight, I should caught this on the PR. This scratched an itch in the
> back of mind and there was the reminder:
>
> https://github.com/Katello/katello/blob/master/lib/katello/tasks/reset.rake#L52
>
> On Mon, Oct 23, 2017 at 11:59 AM, Ewoud Kohl van Wijngaarden
>  wrote:
>>
>> Hello all,
>>
>> On Friday a PR was merged[1] that was intended to verify seeding worked.
>> It turns out that you can't run rake db:migrate db:seed in one command which
>> resulted in failing tests. An issue has been created[2] and a workaround
>> implemented[3]. Please rerun tests that failed on
>>
>> NOT NULL constraint failed: architectures.name: INSERT INTO
>> "architectures" ("created_at", "updated_at") VALUES (?, ?)
>>
>> If tests are still broken after that please do report back.
>>
>> [1]:
>> https://github.com/theforeman/foreman-infra/commit/b275d94f88e2a60306a13154a7727e638bb4a874
>> [2]: https://projects.theforeman.org/issues/21431
>> [3]:
>> https://github.com/theforeman/foreman-infra/commit/5099902d71e79ce7a0b2ec80239d942b92373ecf
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Beste Grüße/Kind regards,

Evgeni Golov
Software Engineer

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Heads up - hound rubocop version updated

[Andrew Kofink]

I created an issue in Katello [1] to track the changes there. We may assign
someone [who isn't there] during today's triage.

[1] http://projects.theforeman.org/issues/21468

On Wed, Oct 25, 2017 at 7:32 AM, Tomer Brisker  wrote:

> Hi,
>
> Hound have updated their version of rubocop to 0.51 which includes some
> rule name changes. I have opened a PR [1] to foreman-core to upgrade to the
> latest version and updated the todo file.
> All plugins using rubocop should make sure their .rubocop.yaml is
> compatible with the new version.
>
> Hound ignores the rubocop version specified in the gemfile, which means
> that it will start barking on every PR in repos that use it if the settings
> are incompatible, and once the PR is merged into foreman core, those
> plugins depending on core and running rubocop on jenkins will start failing.
>
> ​The changes to rubocop's rule names can be foun in their changelog [2],
> or by manually running rubocop version 0.51 with your current configuration
> and looking out for errors.​ In case the errors are in the
> .rubocop_todo.yaml file, it can be automatically regenerated by running
> `rubucop --auto-gen-config` (but keep in mind this will disable any
> currently failing cops).​
>
>
> ​[1] https://github.com/theforeman/foreman/pull/4949
> [2] ​https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md
>
> --
> Have a nice day,
> Tomer Brisker
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Compute resource plugin: Network compute attributes not passed

[jbm]

On 24/10/17 17:42, Ivan Necas wrote:
> On Tue, Oct 24, 2017 at 3:16 PM, jbm  wrote:
>> On 24/10/17 13:20, Ivan Necas wrote:
>>> Hi,
>>>
>>> I was hitting this issue recently in the rex plugin, I needed to
>>> change the way the param is whitelisted,
>>> from using an array, to pass it via a block like this:
>>>
>>>https://github.com/theforeman/foreman_remote_execution/pull/276
>> I changed the portion to
>>
>> parameter_filter Nic::Interface do |ctx|
>>   ctx.permit compute_attributes: [:my_param]
>> end
>>
>> but it still doesn't work. I also tried `ctx.permit :my_param', which worked 
>> neither.
>>
>> I'm not sure if I transfered your solution correctly to my usecase, as you 
>> seem to be passing the NIC parameters differently than I do (I do it in 
>> app/views/compute_resources_vms/form/powervm/_network.html.erb, you in 
>> app/views/overrides/nics/_execution_interface.html.erb).
>>> Also, make sure you're testing it with the version of Foreman that has
>>> this patch
>>> https://github.com/theforeman/foreman/pull/4886, as it needs it to
>>> work properly.
>> I'm using the latest develop branch, so this is included
> Oh, I haven't realized you need to put it under the
> `compute_attributes`. In that case, I think
> you would need to convert the `compute_attributes` in
> (https://github.com/theforeman/foreman/blob/c6760930cf08a4b584b75df8a621092dd787da01/app/controllers/concerns/foreman/controller/parameters/host_base.rb#L42)
> to use filter
> (such as Nic::ComputeAttribute), similarly as we have in
> the host 
> (https://github.com/theforeman/foreman/blob/c6760930cf08a4b584b75df8a621092dd787da01/app/controllers/concerns/foreman/controller/parameters/host_base.rb#L42)
> and then, define the parameter_filter on `Nic::ComputeAttribute`)
Just so I understand you right: Are you saying that it is a missing feature in 
foreman that one can not add custom parameters in the `compute_attributes'? If 
so, did I understand the "How to Create a Plugin" guide wrong? Is 
`compute_attributes' *not* the correct way to add custom provider specific 
parameters to the NIC creation (by adding them to 
`app/views/compute_resources_vms/form/foreman_powervm/_network.html.erb')? What 
is the correct way?

If the only way to do this is to implement your suggested change in foreman, I 
will do that, but since I don't know how fast I could get this patch to the 
production system I want to run my plugin on I'd prefer a solution that works 
without altering foreman and would be happy for a suggestion.

--
jbm
> - Ivan
>
>>> -- Ivan
>>>
>>> On Thu, Oct 12, 2017 at 7:24 PM, jbm  wrote:
 Hi,

 I'm currently working on a Foreman plugin to use IBM PowerVM instances as
 compute resources, and have run into the following problem when 
 implementing
 the network interface form:

 Following the guide at [1], I put my additional network parameters in
 `foreman_powervm/app/views/compute_resources_vms/form/foreman_powervm/_network.html.erb',
 like this:

   <%= number_f f, :my_param
   :label => _("Foo") %>

 I now expected :my_param to be available in
 ForemanPowerVM::PowerVM#create_vm (which is my subclass of 
 ComputeResource),
 in the form of args['interfaces_attributes'][i]['my_param'], but it is not
 there (even though the foreman log shows that my_param was in fact recieved
 as a POST parameter).

 So, as described in [2], I added

   parameter_filter Nic::Interface, compute_attributes: [:my_param]

 to the Plugin.register block in my Engine class, but to no avail.


 After a bit of digging around in the foreman code I managed to "fix" this 
 by
 adding :my_param to the :compute_attributes entry in
 Foreman::Controller::Parameters::NicBase#add_nic_base_params_filter (file
 `foreman_app/controllers/concerns/foreman/controller/parameters/nic_base.rb:27').


 How do I keep my parameter from being filtered without altering foreman
 code? What is the correct way to register parameters, as parameter_filter
 doesnt seem to work?


 Thanks for reading and hopefully your help!


 [1]:
 http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Required-views
 [2]: http://projects.theforeman.org/projects/foreman/wiki/Strong_parameters

 --
 jbm

 --
 You received this message because you are subscribed to the Google Groups
 "foreman-dev" group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to foreman-dev+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to foreman-dev+unsubscr...@googlegroups.com.

Re: [foreman-dev] Place to put slide decks

[Lukas Zapletal]

Oh sorry I pushed into graphics directly. Feel free to review and if
you want I can update our main presentation on our site.

LZ

On Fri, Oct 20, 2017 at 11:25 AM, Greg Sutcliffe
 wrote:
> On Fri, 2017-10-20 at 09:32 +0200, Lukas Zapletal wrote:
>> Well the site Evgeni refers to is more of a consuming endpoint (PDF).
>> What I am looking for is a place to put OOo files.
>>
>> I can do both.
>
> Pick one and we'll review. If it looks a better fit somewhere else we
> can always discuss on the PR.
>
> Thanks!
> Greg
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] FactoryGirl renamed to FactoryBot - plugin maintainer action needed

[Marek Hulan]

Thanks for sending out the heads up. Please also note that such PRs will 
get out of date very quickly so make sure you have them up to date just 
before merge :-)


--
Marek


On October 25, 2017 3:23:29 PM Andrew Kofink  wrote:


I went ahead and made an issue for Katello [1]. I'll submit a PR today with
the changes.

[1] http://projects.theforeman.org/issues/21458

On Wed, Oct 25, 2017 at 9:12 AM, Tomer Brisker  wrote:


Hello,

The Thoughtbot team have decided to rename the factory_girl gem, which we
depend on for tests, to factory_bot [1]. This led to our CI breaking due to
the name change. For now, we have pinned factory_girl to the last working
version to unblock CI, but we should prepare to change to the new name.

This requires, basically, changing every occurrence of `FactoryGirl` to
`FactoryBot`, and every `factory_girl` to `factory_bot`. Other then the
name change, no other changes were made to the API.

Marek has opened a PR[2] for fixing this in foreman-core, however once
this is merged it will break tests for all plugins depending on the core
factory_girl. To prevent prolonged breakage, all plugin maintainers should
work to prepare a PR making the above mentioned change, so that it can be
merged once core PR is merged.

To give you some time to fix this and prevent breakage, the core PR will
be merged one week from today, on November 1st. Please make sure you are
prepared to correctly handle this change in your plugin. If needed, feel
free to reach out to me, Marek, or any of the other core maintainers.

?[1] https://github.com/thoughtbot/factory_bot/issues/921?
?[2] https://github.com/theforeman/foreman/pull/4935?

--
Have a nice day,
Tomer Brisker
Red Hat Engineering

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.





--
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to foreman-dev+unsubscr...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge permissions to foreman-packaging

[Lukas Zapletal]

+1

On Wed, Oct 25, 2017 at 3:25 PM, Eric D Helms  wrote:
> +1 from me as well. I'll look to add you to the team come Monday if no
> objections are raised.
>
> On Tue, Oct 24, 2017 at 5:53 AM, Ohad Levy  wrote:
>>
>>
>>
>> On Mon, Oct 23, 2017 at 7:16 PM, Ewoud Kohl van Wijngaarden
>>  wrote:
>>>
>>> Hello all,
>>>
>>> To get more involved in packaging I'd like to request merge access to
>>> foreman-packaging. I've already been monitoring PRs and submitted various
>>> patches[1][2].
>>
>>
>> +1
>>>
>>>
>>> Regards,
>>> Ewoud Kohl van Wijngaarden
>>>
>>> [1]:
>>> https://github.com/theforeman/foreman-packaging/commits/rpm/develop?author=ekohl
>>> [2]:
>>> https://github.com/theforeman/foreman-packaging/commits/deb/develop?author=ekohl
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge permissions to foreman-packaging

[Eric D Helms]

+1 from me as well. I'll look to add you to the team come Monday if no
objections are raised.

On Tue, Oct 24, 2017 at 5:53 AM, Ohad Levy  wrote:

>
>
> On Mon, Oct 23, 2017 at 7:16 PM, Ewoud Kohl van Wijngaarden <
> ew...@kohlvanwijngaarden.nl> wrote:
>
>> Hello all,
>>
>> To get more involved in packaging I'd like to request merge access to
>> foreman-packaging. I've already been monitoring PRs and submitted various
>> patches[1][2].
>>
>
> +1
>
>>
>> Regards,
>> Ewoud Kohl van Wijngaarden
>>
>> [1]: https://github.com/theforeman/foreman-packaging/commits/rpm/
>> develop?author=ekohl
>> [2]: https://github.com/theforeman/foreman-packaging/commits/deb/
>> develop?author=ekohl
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] FactoryGirl renamed to FactoryBot - plugin maintainer action needed

[Andrew Kofink]

I went ahead and made an issue for Katello [1]. I'll submit a PR today with
the changes.

[1] http://projects.theforeman.org/issues/21458

On Wed, Oct 25, 2017 at 9:12 AM, Tomer Brisker  wrote:

> Hello,
>
> The Thoughtbot team have decided to rename the factory_girl gem, which we
> depend on for tests, to factory_bot [1]. This led to our CI breaking due to
> the name change. For now, we have pinned factory_girl to the last working
> version to unblock CI, but we should prepare to change to the new name.
>
> This requires, basically, changing every occurrence of `FactoryGirl` to
> `FactoryBot`, and every `factory_girl` to `factory_bot`. Other then the
> name change, no other changes were made to the API.
>
> Marek has opened a PR[2] for fixing this in foreman-core, however once
> this is merged it will break tests for all plugins depending on the core
> factory_girl. To prevent prolonged breakage, all plugin maintainers should
> work to prepare a PR making the above mentioned change, so that it can be
> merged once core PR is merged.
>
> To give you some time to fix this and prevent breakage, the core PR will
> be merged one week from today, on November 1st. Please make sure you are
> prepared to correctly handle this change in your plugin. If needed, feel
> free to reach out to me, Marek, or any of the other core maintainers.
>
> ​[1] https://github.com/thoughtbot/factory_bot/issues/921​
> ​[2] https://github.com/theforeman/foreman/pull/4935​
>
> --
> Have a nice day,
> Tomer Brisker
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] FactoryGirl renamed to FactoryBot - plugin maintainer action needed

[Tomer Brisker]

Hello,

The Thoughtbot team have decided to rename the factory_girl gem, which we
depend on for tests, to factory_bot [1]. This led to our CI breaking due to
the name change. For now, we have pinned factory_girl to the last working
version to unblock CI, but we should prepare to change to the new name.

This requires, basically, changing every occurrence of `FactoryGirl` to
`FactoryBot`, and every `factory_girl` to `factory_bot`. Other then the
name change, no other changes were made to the API.

Marek has opened a PR[2] for fixing this in foreman-core, however once this
is merged it will break tests for all plugins depending on the core
factory_girl. To prevent prolonged breakage, all plugin maintainers should
work to prepare a PR making the above mentioned change, so that it can be
merged once core PR is merged.

To give you some time to fix this and prevent breakage, the core PR will be
merged one week from today, on November 1st. Please make sure you are
prepared to correctly handle this change in your plugin. If needed, feel
free to reach out to me, Marek, or any of the other core maintainers.

​[1] https://github.com/thoughtbot/factory_bot/issues/921​
​[2] https://github.com/theforeman/foreman/pull/4935​

-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] OSS Europe 2017 Prague slide deck and demo video

[Lukas Zapletal]

Hey,

I visited Prague on Monday and Tuesday to give talk about Foreman. I
gave the standard talk, updated the standard slide deck a bit and gave
it a small refresh. I pre-recorded DEMO showing PXE booting Debian 9
system with Puppet installing ntpd daemon in Foreman 1.15.

The talk was not recorded unfortunately, only the main tracks were.

https://www.slideshare.net/secret/vkNxGDAIw5gJdC
https://www.youtube.com/watch?v=XsJvKdQOHV8

Slides are available in OpenOffice.org format in our graphics assets git now:

https://github.com/theforeman/foreman-graphics/tree/master/slides/2017-oss-europe-foreman

-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Community-developed Ansible modules for Foreman API objects

[Andrew Kofink]

Nailgun is used for Satellite's QA for testing the API. It's not
purpose-built for Ansible, but it is generally written as a Python library
for Satellite's API. We get 'free' maintenance/features with Nailgun
because the QA team contributes to it (we have access as well). Nailgun
seems to have similar dependencies to python-foreman (i.e. requests).


> - I would overwrite the nailgun using modules like foreman_ptable.py etc.


We still need to discuss what we will do with duplicate modules (whether to
use python-foreman or nailgun). If there are modules that don't exist in
foreman-ansible-modules, we would appreciate PRs for those.

- there is no place to put Ansible module documentation fragments into like
> utils/module_docs_fragments/foreman.py


I would say just create utils/module_docs_fragments in your PR.

If given a choice, I would vote for Nailgun, a more mature project with
more contributors and guaranteed future contribution from Satellite QA.
There is a bit of a gap between foreman-ansible-modules and Nailgun, given
that it is not purpose built; for this, we do include
ansible_nailgun_cement.py [1].

I appreciate the support and interest from the community.

[1]
https://github.com/theforeman/foreman-ansible-modules/blob/master/module_utils/ansible_nailgun_cement.py

Andrew


On Tue, Oct 24, 2017 at 3:47 PM, Thomas Krahn 
wrote:

> Hi all,
>
> as the maintainer of the Ansible Foreman modules
>  i would like to share
> my thoughts with you.
>
> First of all i really like the idea to bring Foreman modules into Ansible.
> The complete configuration of Foreman is much easier if you can use
> Infrastructure as Code.
> That was the reason why i started the implementation in March 2015. At
> this time Ansible didn't have the module_utils folder and modules had to be
> "self contained".
> So the only way to use shared code was to create a Python library and use
> it. My result of that constraint is the Python Foreman library
> .
> It was and still is a challenge to always sync the modules and the library
> functionality.
>
> As far as i can see Nailgun is the library to work with Satellite 6 API.
>
> In regards to the future used library i see three different options so far:
> 1. nailgun
> 2. python-foreman
> 3. Ansible's module_utils.
>
> I don't want to talk about functionality here, but more about constraints
> and dependencies.
> If either nailgun or python-foreman is used people would have to install
> the library to use the Ansible modules and could have the same sync issue
> like i had in the past.
> Besides that i believe the library would have even more dependencies
> (python-requests for example) which could make things even more worst.
> On the other hand people would have a Python library that could even be
> used outside of Ansible for other tasks.
>
> If all that stuff is put into Ansible's module_utils folder we wouldn't
> have any sync issue nor external dependencies, but the usage would be
> limited to Ansible.
> And Ansible provides a great framework that abstracts a lot of things
> (methods like fetch_url() and open_url()) that otherwise would have to be
> reimplemented.
>
> Long term speaking i believe a common Python library would be the winner
> as it provides a standardized and well tested Foreman/Satellite interface
> to the world.
>
> I'm not sure how far the nailgun development is, but python-foreman is
> open source and i'm happy to hand out the ownership of that repository.
>
>
>
> Next topic: Ansible modules
>
> I've already done a lot of work to move the modules from python-foreman +
> modules into "everything in Ansible".
> Means all the library stuff goes into module_utils/foreman.py plus all the
> modules in modules/cloud/foreman/*.py.
> Nearly 75% of that work is done so i could open a PR for each module that
> is already finished.
> If that's something the community would like to see...let's do it :-)
>
> I wanted to commit that code into https://github.com/theforeman/
> foreman-ansible-modules but had some issue.
> - I would overwrite the nailgun using modules like foreman_ptable.py etc.
> - there is no place to put Ansible module documentation fragments into
> like utils/module_docs_fragments/foreman.py
>
> If anyone has an idea how to fix that let me know ;)
>
>
> Happy to see how it's going on
> Nosmoht
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman

[foreman-dev] Heads up - hound rubocop version updated

[Tomer Brisker]

Hi,

Hound have updated their version of rubocop to 0.51 which includes some
rule name changes. I have opened a PR [1] to foreman-core to upgrade to the
latest version and updated the todo file.
All plugins using rubocop should make sure their .rubocop.yaml is
compatible with the new version.

Hound ignores the rubocop version specified in the gemfile, which means
that it will start barking on every PR in repos that use it if the settings
are incompatible, and once the PR is merged into foreman core, those
plugins depending on core and running rubocop on jenkins will start failing.

​The changes to rubocop's rule names can be foun in their changelog [2], or
by manually running rubocop version 0.51 with your current configuration
and looking out for errors.​ In case the errors are in the
.rubocop_todo.yaml file, it can be automatically regenerated by running
`rubucop --auto-gen-config` (but keep in mind this will disable any
currently failing cops).​


​[1] https://github.com/theforeman/foreman/pull/4949
[2] ​https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md

-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.