Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ohad Levy 
On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines  wrote:

> > Oh yeah, especially notifications. Why can't they just update when the
> page updates?
>
> I think it would be good to move the notifications to a websocket approach
> instead of polling.  I know, I know, PRs welcome :)
>

We can consider using SSE for sending notifications too, but I'm uncertain
how it would play with passenger. a more reliable approach would probably
be to start using redis + websockets additional service proxied by apache
(and webpack in development)

Ohad

>
> On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy  wrote:
>
>>
>>
>> On Dec 6, 2017 12:19 PM, "Ivan Necas"  wrote:
>>
>> The only concern, as the users are used to the auto-refresh, once we turn
>> that off, they can start thinking the thing got stuck.
>>
>>
>> In that case let's keep updating the talk progress without replacing the
>> entire tab?
>>
>>
>> -- Ivan
>>
>> On Wed, 6 Dec 2017 at 17:50, Ohad Levy  wrote:
>>
>>> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink 
>>> wrote:
>>>
 As part of this I would love to see *all* auto reloads default to off
>

>>> +1 - PR are welcomes ;)
>>>
>>>
 Oh yeah, especially notifications. Why can't they just update when the
 page updates?

 On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines 
 wrote:

> > I think the refresh should still be off by default.
>
> As part of this I would love to see *all* auto reloads default to
> off.  The dashboard, for example, constantly reloading by default is
> annoying to me.
>
> Cheers,
> Walden
>
> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink 
> wrote:
>
>> Hello,
>>
>> We have the option of toggling auto-refresh on individual tasks, but
>> I often find myself at the foreman_tasks#tasks page intermittently 
>> clicking
>> the search button to monitor the state of automated tasks (in my case,
>> usually bats content/proxy tests). I'm proposing a button or an option
>> under the search drop down button to enable/disable auto refresh. I think
>> the refresh should still be off by default.
>>
>> Any comments?
>>
>> - Andrew
>>
>> --
>> Andrew Kofink
>> akof...@redhat.com
>> IRC: akofink
>> Software Engineer
>> Red Hat Satellite
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google
> Groups "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



 --
 Andrew Kofink
 akof...@redhat.com
 IRC: akofink
 Software Engineer
 Red Hat Satellite

 --
 You received this message because you are subscribed to the Google
 Groups "foreman-dev" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to foreman-dev+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Walden Raines 
> Oh yeah, especially notifications. Why can't they just update when the
page updates?

I think it would be good to move the notifications to a websocket approach
instead of polling.  I know, I know, PRs welcome :)

On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy  wrote:

>
>
> On Dec 6, 2017 12:19 PM, "Ivan Necas"  wrote:
>
> The only concern, as the users are used to the auto-refresh, once we turn
> that off, they can start thinking the thing got stuck.
>
>
> In that case let's keep updating the talk progress without replacing the
> entire tab?
>
>
> -- Ivan
>
> On Wed, 6 Dec 2017 at 17:50, Ohad Levy  wrote:
>
>> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink  wrote:
>>
>>> As part of this I would love to see *all* auto reloads default to off

>>>
>> +1 - PR are welcomes ;)
>>
>>
>>> Oh yeah, especially notifications. Why can't they just update when the
>>> page updates?
>>>
>>> On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines 
>>> wrote:
>>>
 > I think the refresh should still be off by default.

 As part of this I would love to see *all* auto reloads default to off.
 The dashboard, for example, constantly reloading by default is annoying to
 me.

 Cheers,
 Walden

 On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink 
 wrote:

> Hello,
>
> We have the option of toggling auto-refresh on individual tasks, but I
> often find myself at the foreman_tasks#tasks page intermittently clicking
> the search button to monitor the state of automated tasks (in my case,
> usually bats content/proxy tests). I'm proposing a button or an option
> under the search drop down button to enable/disable auto refresh. I think
> the refresh should still be off by default.
>
> Any comments?
>
> - Andrew
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google
> Groups "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

 --
 You received this message because you are subscribed to the Google
 Groups "foreman-dev" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to foreman-dev+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>>
>>> --
>>> Andrew Kofink
>>> akof...@redhat.com
>>> IRC: akofink
>>> Software Engineer
>>> Red Hat Satellite
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ohad Levy 
On Dec 6, 2017 12:19 PM, "Ivan Necas"  wrote:

The only concern, as the users are used to the auto-refresh, once we turn
that off, they can start thinking the thing got stuck.


In that case let's keep updating the talk progress without replacing the
entire tab?


-- Ivan

On Wed, 6 Dec 2017 at 17:50, Ohad Levy  wrote:

> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink  wrote:
>
>> As part of this I would love to see *all* auto reloads default to off
>>>
>>
> +1 - PR are welcomes ;)
>
>
>> Oh yeah, especially notifications. Why can't they just update when the
>> page updates?
>>
>> On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines 
>> wrote:
>>
>>> > I think the refresh should still be off by default.
>>>
>>> As part of this I would love to see *all* auto reloads default to off.
>>> The dashboard, for example, constantly reloading by default is annoying to
>>> me.
>>>
>>> Cheers,
>>> Walden
>>>
>>> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink 
>>> wrote:
>>>
 Hello,

 We have the option of toggling auto-refresh on individual tasks, but I
 often find myself at the foreman_tasks#tasks page intermittently clicking
 the search button to monitor the state of automated tasks (in my case,
 usually bats content/proxy tests). I'm proposing a button or an option
 under the search drop down button to enable/disable auto refresh. I think
 the refresh should still be off by default.

 Any comments?

 - Andrew

 --
 Andrew Kofink
 akof...@redhat.com
 IRC: akofink
 Software Engineer
 Red Hat Satellite

 --
 You received this message because you are subscribed to the Google
 Groups "foreman-dev" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to foreman-dev+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Andrew Kofink
>> akof...@redhat.com
>> IRC: akofink
>> Software Engineer
>> Red Hat Satellite
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ivan Necas 
The only concern, as the users are used to the auto-refresh, once we turn
that off, they can start thinking the thing got stuck.

-- Ivan

On Wed, 6 Dec 2017 at 17:50, Ohad Levy  wrote:

> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink  wrote:
>
>> As part of this I would love to see *all* auto reloads default to off
>>>
>>
> +1 - PR are welcomes ;)
>
>
>> Oh yeah, especially notifications. Why can't they just update when the
>> page updates?
>>
>> On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines 
>> wrote:
>>
>>> > I think the refresh should still be off by default.
>>>
>>> As part of this I would love to see *all* auto reloads default to off.
>>> The dashboard, for example, constantly reloading by default is annoying to
>>> me.
>>>
>>> Cheers,
>>> Walden
>>>
>>> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink 
>>> wrote:
>>>
 Hello,

 We have the option of toggling auto-refresh on individual tasks, but I
 often find myself at the foreman_tasks#tasks page intermittently clicking
 the search button to monitor the state of automated tasks (in my case,
 usually bats content/proxy tests). I'm proposing a button or an option
 under the search drop down button to enable/disable auto refresh. I think
 the refresh should still be off by default.

 Any comments?

 - Andrew

 --
 Andrew Kofink
 akof...@redhat.com
 IRC: akofink
 Software Engineer
 Red Hat Satellite

 --
 You received this message because you are subscribed to the Google
 Groups "foreman-dev" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to foreman-dev+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Andrew Kofink
>> akof...@redhat.com
>> IRC: akofink
>> Software Engineer
>> Red Hat Satellite
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ohad Levy 
On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink  wrote:

> As part of this I would love to see *all* auto reloads default to off
>>
>
+1 - PR are welcomes ;)


> Oh yeah, especially notifications. Why can't they just update when the
> page updates?
>
> On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines  wrote:
>
>> > I think the refresh should still be off by default.
>>
>> As part of this I would love to see *all* auto reloads default to off.
>> The dashboard, for example, constantly reloading by default is annoying to
>> me.
>>
>> Cheers,
>> Walden
>>
>> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink 
>> wrote:
>>
>>> Hello,
>>>
>>> We have the option of toggling auto-refresh on individual tasks, but I
>>> often find myself at the foreman_tasks#tasks page intermittently clicking
>>> the search button to monitor the state of automated tasks (in my case,
>>> usually bats content/proxy tests). I'm proposing a button or an option
>>> under the search drop down button to enable/disable auto refresh. I think
>>> the refresh should still be off by default.
>>>
>>> Any comments?
>>>
>>> - Andrew
>>>
>>> --
>>> Andrew Kofink
>>> akof...@redhat.com
>>> IRC: akofink
>>> Software Engineer
>>> Red Hat Satellite
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Andrew Kofink 
>
> As part of this I would love to see *all* auto reloads default to off


Oh yeah, especially notifications. Why can't they just update when the page
updates?

On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines  wrote:

> > I think the refresh should still be off by default.
>
> As part of this I would love to see *all* auto reloads default to off.
> The dashboard, for example, constantly reloading by default is annoying to
> me.
>
> Cheers,
> Walden
>
> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink  wrote:
>
>> Hello,
>>
>> We have the option of toggling auto-refresh on individual tasks, but I
>> often find myself at the foreman_tasks#tasks page intermittently clicking
>> the search button to monitor the state of automated tasks (in my case,
>> usually bats content/proxy tests). I'm proposing a button or an option
>> under the search drop down button to enable/disable auto refresh. I think
>> the refresh should still be off by default.
>>
>> Any comments?
>>
>> - Andrew
>>
>> --
>> Andrew Kofink
>> akof...@redhat.com
>> IRC: akofink
>> Software Engineer
>> Red Hat Satellite
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Is it time to remove turbolinks?

2017-12-06 Thread Ohad Levy 
On Wed, Dec 6, 2017 at 5:10 PM, Walden Raines  wrote:

> I am seeing more and more issues [1][2] around turbolinks and I'm
> wondering if it's time to remove it from foreman.  I have seen it
> recommended that one shouldn't use the back button in foreman; I thought
> that request was reserved for poorly written php sites that resubmit forms
> when the back button is pressed, we're better than that! :)
>
> Are the benefits of turbolinks worth the cost?  Does anyone have any
> metrics on the difference in page load times with and without
> "turbo"links?
>
> Any additional thoughts on its removal?
>
>
I welcome the proposal to remove turbolinks,  having said that, there are a
few things that we must take into account.

1. we should not just remove turbo links and loose all functionaitly - this
will greatly impact current ui performance.
2. we should come up with an alternative plan - which is a roadmap to a SPA
or semi SPA which will render the usage cases of tubolinks today not
required.

IMHO - I would suggest we look into converting the vertical nav into a
react component (some work already done at [1]), than using that as a base
for a SPA, we should default to fetching content, either via api and using
react to render it, or (which is the very common case) to let the server
render html and replace a content div, this will mimic the current way
turbolinks more or less works and will surely speed up the page load times.

We would need to move things like session / login / permissions etc into
the browser if we go that path

Ohad



[1] https://github.com/patternfly/patternfly-react/pull/88

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Walden Raines 
> I think the refresh should still be off by default.

As part of this I would love to see *all* auto reloads default to off.  The
dashboard, for example, constantly reloading by default is annoying to me.

Cheers,
Walden

On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink  wrote:

> Hello,
>
> We have the option of toggling auto-refresh on individual tasks, but I
> often find myself at the foreman_tasks#tasks page intermittently clicking
> the search button to monitor the state of automated tasks (in my case,
> usually bats content/proxy tests). I'm proposing a button or an option
> under the search drop down button to enable/disable auto refresh. I think
> the refresh should still be off by default.
>
> Any comments?
>
> - Andrew
>
> --
> Andrew Kofink
> akof...@redhat.com
> IRC: akofink
> Software Engineer
> Red Hat Satellite
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Ivan Necas 
+2

-- Ivan

On Wed, 6 Dec 2017 at 16:51, Lukas Zapletal  wrote:

> +1 +1 beer time!
>
> LZ
>
> On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker  wrote:
> > Hello,
> > As many of you may have noticed, foreman-core open PR count has been in
> the
> > area of 100-110 for most of the last few months. There are only a few
> people
> > with merge access that actively review PRs, so that the time it takes for
> > changes to be accepted can take long. I would like to propose granting
> merge
> > access to two more members of the community:
> >
> > Shimon Shtein - has 75 merged commits [1] and has taken part in the
> reviews
> > of 64 merged commits[2].
> > Michael Moll - has 71 merged commits [3] and has taken part in the
> reviews
> > of 130 merged commits[4]. He is also already a long time maintainer of
> > several of our other repos and has proven to be a responsible maintainer.
> >
> > Please send +1/-1 either to the list or to me in private if you prefer.
> > Per our process, unless I receive any objections within a week, I will
> > request one of the organization owners to grant them access.
> >
> > [1]
> >
> https://github.com/theforeman/foreman/pulls?q=is%3Apr+author%3Ashimshtein+is%3Aclosed
> > [2]
> >
> https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
> > [3]
> >
> https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Ammoll+is%3Aclosed+
> > [4]
> >
> https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
> >
> > --
> > Have a nice day,
> > Tomer Brisker
> > Red Hat Engineering
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to foreman-dev+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Later,
>   Lukas @lzap Zapletal
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Andrew Kofink 
Hello,

We have the option of toggling auto-refresh on individual tasks, but I
often find myself at the foreman_tasks#tasks page intermittently clicking
the search button to monitor the state of automated tasks (in my case,
usually bats content/proxy tests). I'm proposing a button or an option
under the search drop down button to enable/disable auto refresh. I think
the refresh should still be off by default.

Any comments?

- Andrew

-- 
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Lukas Zapletal 
+1 +1 beer time!

LZ

On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker  wrote:
> Hello,
> As many of you may have noticed, foreman-core open PR count has been in the
> area of 100-110 for most of the last few months. There are only a few people
> with merge access that actively review PRs, so that the time it takes for
> changes to be accepted can take long. I would like to propose granting merge
> access to two more members of the community:
>
> Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
> of 64 merged commits[2].
> Michael Moll - has 71 merged commits [3] and has taken part in the reviews
> of 130 merged commits[4]. He is also already a long time maintainer of
> several of our other repos and has proven to be a responsible maintainer.
>
> Please send +1/-1 either to the list or to me in private if you prefer.
> Per our process, unless I receive any objections within a week, I will
> request one of the organization owners to grant them access.
>
> [1]
> https://github.com/theforeman/foreman/pulls?q=is%3Apr+author%3Ashimshtein+is%3Aclosed
> [2]
> https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
> [3]
> https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Ammoll+is%3Aclosed+
> [4]
> https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>
> --
> Have a nice day,
> Tomer Brisker
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Is it time to remove turbolinks?

2017-12-06 Thread Lukas Zapletal 
The idea behind turbolinks is good in general - it works great when
you have a standard Rails application with its view stack (ERB). When
I saw this talked, I liked it very much:

https://www.youtube.com/watch?v=SWEts0rlezA

Unfortunately, we are not good fit. This works for a clean app which
ERB and maybe little javascript. Foreman (and Katello) is a heavy JS
app with various JS frameworks and perhaps it does not work well. At
least this is my impression, I am very far from being a frontend
developer :-)

LZ

On Wed, Dec 6, 2017 at 4:10 PM, Walden Raines  wrote:
> I am seeing more and more issues [1][2] around turbolinks and I'm wondering
> if it's time to remove it from foreman.  I have seen it recommended that one
> shouldn't use the back button in foreman; I thought that request was
> reserved for poorly written php sites that resubmit forms when the back
> button is pressed, we're better than that! :)
>
> Are the benefits of turbolinks worth the cost?  Does anyone have any metrics
> on the difference in page load times with and without "turbo"links?
>
> Any additional thoughts on its removal?
>
> Cheers,
> Walden
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1522740
> [2] http://projects.theforeman.org/issues/21480
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Is it time to remove turbolinks?

2017-12-06 Thread Walden Raines 
I am seeing more and more issues [1][2] around turbolinks and I'm wondering
if it's time to remove it from foreman.  I have seen it recommended that
one shouldn't use the back button in foreman; I thought that request was
reserved for poorly written php sites that resubmit forms when the back
button is pressed, we're better than that! :)

Are the benefits of turbolinks worth the cost?  Does anyone have any
metrics on the difference in page load times with and without
"turbo"links?

Any additional thoughts on its removal?

Cheers,
Walden

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1522740
[2] http://projects.theforeman.org/issues/21480

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Be sure to import your product content data for Katello 3.6

2017-12-06 Thread Jonathon Turel 
Hi all,

A change 

 
landed in Katello yesterday which introduced a new pattern of importing 
product content information from Candlepin into the Katello DB. This is in 
support of some new feature work and means that Candlepin will no longer be 
consulted for that information until it's time to be refreshed. All areas 
of Katello which use product content data are affected such as the Red Hat 
Repositories page and several APIs.

In order to populate your local cache, please run `rake 
katello:upgrades:3.6:import_product_content`. From that point on the cache 
should be updated through ordinary use of Katello - importing manifests, 
etc. This step is not necessary unless you have a manifest imported and/or 
custom products created.

I'm working on a change for the installer to do the same import and I'll 
update this thread once it's ready for review & test.

Let me know if you have problems, questions, or concerns.

Thanks,

Jonathon

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Marek Hulan 

+1 +1

--
Marek


On December 6, 2017 3:14:28 PM Ohad Levy  wrote:


On Dec 6, 2017 7:41 AM, "Tomer Brisker"  wrote:

Hello,
?As many of you may have noticed, foreman-core open PR? count has been in
the area of 100-110 for most of the last few months. There are only a few
people with merge access that actively review PRs, so that the time it
takes for changes to be accepted can take long. I would like to propose
granting merge access to two more members of the community:

Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].
Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.

Please send +1/-1 either to the list or to me in private if you prefer.
Per our process, unless I receive any objections within a week, I will
request one of the organization owners to grant them access.


+1 to both :)


[1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+
author%3Ashimshtein+is%3Aclosed
[2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
?[3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
q=is%3Apr+author%3Ammoll+is%3Aclosed+
[4]? https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+

--
Have a nice day,
Tomer Brisker
Red Hat Engineering

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to foreman-dev+unsubscr...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Andrew Kofink 
+1 to both!

On Wed, Dec 6, 2017 at 9:14 AM, Ohad Levy  wrote:

>
>
> On Dec 6, 2017 7:41 AM, "Tomer Brisker"  wrote:
>
> Hello,
> ​As many of you may have noticed, foreman-core open PR​ count has been in
> the area of 100-110 for most of the last few months. There are only a few
> people with merge access that actively review PRs, so that the time it
> takes for changes to be accepted can take long. I would like to propose
> granting merge access to two more members of the community:
>
> Shimon Shtein - has 75 merged commits [1] and has taken part in the
> reviews of 64 merged commits[2].
> Michael Moll - has 71 merged commits [3] and has taken part in the reviews
> of 130 merged commits[4]. He is also already a long time maintainer of
> several of our other repos and has proven to be a responsible maintainer.
>
> Please send +1/-1 either to the list or to me in private if you prefer.
> Per our process, unless I receive any objections within a week, I will
> request one of the organization owners to grant them access.
>
>
> +1 to both :)
>
>
> [1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+author
> %3Ashimshtein+is%3Aclosed
> [2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
> =is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
> ​[3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
> =is%3Apr+author%3Ammoll+is%3Aclosed+
> [4]​ https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
> =is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>
> --
> Have a nice day,
> Tomer Brisker
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Andrew Kofink
akof...@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Ohad Levy 
On Dec 6, 2017 7:41 AM, "Tomer Brisker"  wrote:

Hello,
​As many of you may have noticed, foreman-core open PR​ count has been in
the area of 100-110 for most of the last few months. There are only a few
people with merge access that actively review PRs, so that the time it
takes for changes to be accepted can take long. I would like to propose
granting merge access to two more members of the community:

Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].
Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.

Please send +1/-1 either to the list or to me in private if you prefer.
Per our process, unless I receive any objections within a week, I will
request one of the organization owners to grant them access.


+1 to both :)


[1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+
author%3Ashimshtein+is%3Aclosed
[2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
​[3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
q=is%3Apr+author%3Ammoll+is%3Aclosed+
[4]​ https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+

-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Martin Bačovský 
+1 to both

On Wed, Dec 6, 2017 at 1:53 PM, Eric D Helms  wrote:

> +1 to both!
>
> On Wed, Dec 6, 2017 at 7:51 AM, Adam Ruzicka  wrote:
>
>> +1 to both
>>
>> -- Adam
>>
>>
>> On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker 
>> wrote:
>>
>>> Hello,
>>> ​As many of you may have noticed, foreman-core open PR​ count has been
>>> in the area of 100-110 for most of the last few months. There are only a
>>> few people with merge access that actively review PRs, so that the time it
>>> takes for changes to be accepted can take long. I would like to propose
>>> granting merge access to two more members of the community:
>>>
>>> Shimon Shtein - has 75 merged commits [1] and has taken part in the
>>> reviews of 64 merged commits[2].
>>> Michael Moll - has 71 merged commits [3] and has taken part in the
>>> reviews of 130 merged commits[4]. He is also already a long time maintainer
>>> of several of our other repos and has proven to be a responsible maintainer.
>>>
>>> Please send +1/-1 either to the list or to me in private if you prefer.
>>> Per our process, unless I receive any objections within a week, I will
>>> request one of the organization owners to grant them access.
>>>
>>> [1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+author
>>> %3Ashimshtein+is%3Aclosed
>>> [2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
>>> =is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
>>> ​[3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
>>> =is%3Apr+author%3Ammoll+is%3Aclosed+
>>> [4]​ https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
>>> =is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>>>
>>> --
>>> Have a nice day,
>>> Tomer Brisker
>>> Red Hat Engineering
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Eric D Helms 
+1 to both!

On Wed, Dec 6, 2017 at 7:51 AM, Adam Ruzicka  wrote:

> +1 to both
>
> -- Adam
>
>
> On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker  wrote:
>
>> Hello,
>> ​As many of you may have noticed, foreman-core open PR​ count has been in
>> the area of 100-110 for most of the last few months. There are only a few
>> people with merge access that actively review PRs, so that the time it
>> takes for changes to be accepted can take long. I would like to propose
>> granting merge access to two more members of the community:
>>
>> Shimon Shtein - has 75 merged commits [1] and has taken part in the
>> reviews of 64 merged commits[2].
>> Michael Moll - has 71 merged commits [3] and has taken part in the
>> reviews of 130 merged commits[4]. He is also already a long time maintainer
>> of several of our other repos and has proven to be a responsible maintainer.
>>
>> Please send +1/-1 either to the list or to me in private if you prefer.
>> Per our process, unless I receive any objections within a week, I will
>> request one of the organization owners to grant them access.
>>
>> [1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+author
>> %3Ashimshtein+is%3Aclosed
>> [2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
>> =is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
>> ​[3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
>> =is%3Apr+author%3Ammoll+is%3Aclosed+
>> [4]​ https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q
>> =is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>>
>> --
>> Have a nice day,
>> Tomer Brisker
>> Red Hat Engineering
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Adam Ruzicka 
+1 to both

-- Adam

On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker  wrote:

> Hello,
> ​As many of you may have noticed, foreman-core open PR​ count has been in
> the area of 100-110 for most of the last few months. There are only a few
> people with merge access that actively review PRs, so that the time it
> takes for changes to be accepted can take long. I would like to propose
> granting merge access to two more members of the community:
>
> Shimon Shtein - has 75 merged commits [1] and has taken part in the
> reviews of 64 merged commits[2].
> Michael Moll - has 71 merged commits [3] and has taken part in the reviews
> of 130 merged commits[4]. He is also already a long time maintainer of
> several of our other repos and has proven to be a responsible maintainer.
>
> Please send +1/-1 either to the list or to me in private if you prefer.
> Per our process, unless I receive any objections within a week, I will
> request one of the organization owners to grant them access.
>
> [1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+
> author%3Ashimshtein+is%3Aclosed
> [2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
> q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
> ​[3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
> q=is%3Apr+author%3Ammoll+is%3Aclosed+
> [4]​ https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
> q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>
> --
> Have a nice day,
> Tomer Brisker
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Ewoud Kohl van Wijngaarden 

On Wed, Dec 06, 2017 at 02:40:36PM +0200, Tomer Brisker wrote:

Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].


+1


Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.


+1

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Nominating additional maintainers in foreman-core

2017-12-06 Thread Tomer Brisker 
Hello,
​As many of you may have noticed, foreman-core open PR​ count has been in
the area of 100-110 for most of the last few months. There are only a few
people with merge access that actively review PRs, so that the time it
takes for changes to be accepted can take long. I would like to propose
granting merge access to two more members of the community:

Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].
Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.

Please send +1/-1 either to the list or to me in private if you prefer.
Per our process, unless I receive any objections within a week, I will
request one of the organization owners to grant them access.

[1]
https://github.com/theforeman/foreman/pulls?q=is%3Apr+author%3Ashimshtein+is%3Aclosed
[2]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
​[3]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Ammoll+is%3Aclosed+
[4]​
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+

-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] RFC: File audit for template rendering

2017-12-06 Thread Lukas Zapletal 
You are right that in general, this is an anti-pattern, but the data
we will be sending is write only logging data. It's essentially a log
sink, but for arbitrary data (blobs, files, name it you want). In
clustered setup, you simply keep the logs on nodes along with other
logging data. On the other hand, we aim at using syslog for everything
in the future, this could be additional thing to keep in mind.

We also discussed storing this in database schema in a formal way (new
table rendered_template with references to host/template_kind) but
arguments against are this is already quite complex part of our
schema, keeping history could easily grow the database and performance
could be problem for Remote Execution when performing large-scale
script runs. We ended up discussing actually removing audit trail data
from database, but this turned to be problem as we need to keep
reference to taxonomy, users and records.

This brings me to alternative proposal:

I plan to work on full syslog support for Rails and Smart Proxy in
January next year. The goal is to achieve structured logging using
some standard format (CEE/CEF). We would send those rendered templates
to Rails log (syslog) and there could be an optional syslog module to
extract those log entries and put them into similar directory
structure. This could be the default setup for small deployments, but
for large-scale we will recommend to send logs over network to central
logging point anyway, so the module could be installed there or
depending on setup this could be loaded into ELK stack. (*)

In short, let's send the rendered templates to syslog, it deals with
multiple lines just fine, we can simply filter these from
production.log and put them into a separate file or even directory
structure.

(*) http://www.rsyslog.com/writing-rsyslog-plugins-in-2-minutes/

On Tue, Dec 5, 2017 at 6:34 PM, Timo Goebel  wrote:
> I don't think, this is a good idea. Storing files on the local filesystem is
> generally consideres an anti-pattern imho. Both for web applications and
> expecially in a container world.
>
> In a clustered setup, you'd have to attach some kind of shared-storage to
> the foreman hosts to make this work. Possibly via NFS or something. This is
> meant to cause trouble. I generally advise not to have any state on an
> application server.
>
> I think, this can and should be done with a database. I agree, that the
> audit model might not be the best place for this. But a database definitely
> is.
>
> Just my 2 cents.
>
> - Timo
>
> Am 05.12.17 um 18:01 schrieb Lukas Zapletal:
>
>> Hello,
>>
>> Foreman does have a nice audit trail for many operations, what's
>> missing is ability to find how a template (e.g. kickstart) was
>> rendered. Storing whole template text in audit table is probably not
>> the best thing to do, production.log is also not a good fit, so here
>> is a proposal.
>>
>> I want to create a small API called File audit (*) with ability to
>> store arbitrary files into
>> /var/log/foreman/file_audit/id/text-timestamp where "id" is record id
>> (or multiple ids concatenated with dots), "text" is arbitrary alphanum
>> text and "timestamp" is unix epoch number. Example:
>>
>> /var/log/foreman/file_audit/1.33.7/my.host.lan-pxelinux-1512492603
>>
>> That API will be used to store contents of all templates rendered, so
>> users can easily go "back in time" and see how templates are being
>> rendered. The directory would be root-only reading and files will be
>> created with restricted permissions (foreman user rw only). On system
>> with SELinux, security would be more tightened allowing writing only
>> to foreman_t domain and reading to nobody. For the example above, this
>> would mean:
>>
>> 1.33.7/my.host.lan-pxelinux-1512492603
>>
>> 1 - file audit type (static list, 1 stands for "template audit entry")
>> 33 - host id
>> 7 - template id
>> my.host.lan-pxelinux - extra data so users can work and search from
>> command line
>> 1512492603 - UNIX epoch timestamp
>>
>> Everytime new record is added, a log entry is created into
>> production.log containing file path. By default, there will be a cron
>> job deleting all files older than one month. In documentation, we will
>> ask users to rsync the directory to different location if long-term
>> archival is needed.
>>
>> This API could be used for other audit logging, for example when user
>> uploads a manifest ZIP file in katello or new version of RPM/Puppet
>> file. This will be the first step to improve audit around templates,
>> later on we can create a plugin showing the data in audit/host pages
>> if needed. But in the first phase, administrators could easily
>> search/grep/diff those files when necessary.
>>
>> (*) if you have a better name, please do propose
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.

Re: [foreman-dev] Notifications / monitoring for infra

2017-12-06 Thread Lukas Zapletal 
I don't really care as long as you give us an email that we can
configure both our puppet and non-puppet managed servers to send
e-mails to and you add me and Eric into a private list/alias/RSS.

LZ

On Wed, Dec 6, 2017 at 12:40 AM, Greg Sutcliffe  wrote:
> Lukas asked me to raise this after Koji ran out of space, so ... :)
>
> Currently there are two forms of notification from our infra. Firstly
> there is the private infra Google Group, but no-one seems to know who
> maintains is (Dominic?). Secondly, there is a list of email addresses
> written by Puppet to /etc/aliases (current it's me, Ohad and Michael).
>
> While notifications from Koji would have at least reached more people if
> it was in Puppet (which we discussed briefly, but no one had time for),
> I think it makes sense to think about what we want to do more generally
> about this stuff.
>
> My *long term* preference would be proper monitoring - something like
> Icinga or Zabbix, properly deployed with the appropriate checks, and the
> ability to alert the right people if a check fails. That's the right
> thing to do, and is flexibile in who gets a particular alert.
>
> In the short term, though, we could use either *another* mailing list
> (since the existing Google Group seems lost) or a private infra group on
> Discourse (I tested it briefly, you can email in to a group and keep the
> messages private to the group members). Either of these would work in
> the short term. We could also use an alias on the root DNS
> (in...@theforeman.org or something) but I don't think Ohad can set up
> multiple forwards for that very easily... and it's harder to manage when
> the list of forwards changes (only Ohad can do it).
>
> Thoughts? I lean to a temporary solution on Discourse (but not strongly,
> a mailing list is fine here), and proper monitoring to be added to
> Eric's infra roadmap for later on.
>
> Greg
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.