Re: [foreman-dev] Merge rights to Katello installer
+1 nice work thanks. LZ On Thu, Oct 26, 2017 at 11:39 AM, Sean O'Keeffe wrote: > Hi, > > I'd like to request write access to the installer team. > > I've been involved with 38 PRs across what I'd consider to be the 'main' > repos, apparently I created 15 of them and I guess I reviewed the rest. > > https://github.com/Katello/puppet-katello/pulls?q=is%3Apr%20involves%3Asean797%20 > https://github.com/Katello/katello-installer/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 > https://github.com/Katello/puppet-certs/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 > https://github.com/Katello/puppet-candlepin/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 > https://github.com/Katello/puppet-foreman_proxy_content/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 > https://github.com/Katello/puppet-pulp/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 > https://github.com/Katello/puppet-qpid/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 > > Thanks, > Sean > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Later, Lukas @lzap Zapletal -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge rights to Katello installer
On Thu, Oct 26, 2017 at 12:03 PM, Ewoud Kohl van Wijngaarden wrote: > On Thu, Oct 26, 2017 at 10:39:28AM +0100, Sean O'Keeffe wrote: >> >> I'd like to request write access to the installer team. > > > +1 Sean has shown insight in the modules and the overall picture. His PRs > are consistently of a high quality. +1 -- Beste Grüße/Kind regards, Evgeni Golov Software Engineer Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric Shander -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge rights to Katello installer
On Thu, Oct 26, 2017 at 10:39:28AM +0100, Sean O'Keeffe wrote: I'd like to request write access to the installer team. +1 Sean has shown insight in the modules and the overall picture. His PRs are consistently of a high quality. I've been involved with 38 PRs across what I'd consider to be the 'main' repos, apparently I created 15 of them and I guess I reviewed the rest. https://github.com/Katello/puppet-katello/pulls?q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/katello-installer/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 https://github.com/Katello/puppet-certs/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/puppet-candlepin/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/puppet-foreman_proxy_content/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 https://github.com/Katello/puppet-pulp/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/puppet-qpid/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Merge rights to Katello installer
Hi, I'd like to request write access to the installer team. I've been involved with 38 PRs across what I'd consider to be the 'main' repos, apparently I created 15 of them and I guess I reviewed the rest. https://github.com/Katello/puppet-katello/pulls?q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/katello-installer/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 https://github.com/Katello/puppet-certs/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/puppet-candlepin/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/puppet-foreman_proxy_content/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 https://github.com/Katello/puppet-pulp/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797%20 https://github.com/Katello/puppet-qpid/pulls?utf8=%E2%9C%93&q=is%3Apr%20involves%3Asean797 Thanks, Sean -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.