Re: Invalid "dg-do run" in the testsuite (with 2 blanks)

2024-04-02 Thread Jerry D

On 4/1/24 11:46 PM, Andrew Pinski wrote:

On Sun, Mar 24, 2024 at 1:19 PM Harald Anlauf  wrote:


Dear all,

I noticed by chance that we have quite a lot of improperly specified do-do
directives in the testsuite.

% grep "dg-do  run" gcc/testsuite/gfortran.dg/ -rl|wc -l
83

Note that with two blanks instead of just one a testcase does not get executed.

Does anybody want to earn the honors to change the directives and
check for "fallout" in the testsuite?


Note this seems related to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=28032 (or maybe this is
the "workaround" for not doing torture options on the testcases).

If this gets documented to avoid doing the torture options, then the
testsuite should be auditted for dg-options with `-ON` and add the
extra space for dg-do to get the non torture way.

Thanks,
Andrew



Cheers,
Harald



Thanks for this additional info. I have not settled on exactly what to say in 
the documentation.

I noticed that when I specified a specific -ON it still did them all 
regardless.  I did not know if this was expected or a feature.

Jerry -


Re: Invalid "dg-do run" in the testsuite (with 2 blanks)

2024-04-02 Thread Andrew Pinski
On Sun, Mar 24, 2024 at 1:19 PM Harald Anlauf  wrote:
>
> Dear all,
>
> I noticed by chance that we have quite a lot of improperly specified do-do
> directives in the testsuite.
>
> % grep "dg-do  run" gcc/testsuite/gfortran.dg/ -rl|wc -l
> 83
>
> Note that with two blanks instead of just one a testcase does not get 
> executed.
>
> Does anybody want to earn the honors to change the directives and
> check for "fallout" in the testsuite?

Note this seems related to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=28032 (or maybe this is
the "workaround" for not doing torture options on the testcases).

If this gets documented to avoid doing the torture options, then the
testsuite should be auditted for dg-options with `-ON` and add the
extra space for dg-do to get the non torture way.

Thanks,
Andrew

>
> Cheers,
> Harald
>