Re: [fossil-dev] Check-in etiquette

[Richard Hipp]

On 8/27/15, Baruch Burstein  wrote:
> Hi,
>
> I know that when making changes to makemake.tcl, I am expected to run the
> script to generate the new makefiles and check them in as well. However, I
> am on a computer where I cannot easily install TCL (company policy). I
> committed the changes to makemake.tcl without regenerating the makefiles,
> leaving that to someone else. Is this acceptable?
>

It is never acceptable to check-in incomplete or untested changes to trunk.

Incomplete or untested changes are discouraged on any branch.
Exceptions might be made for extraordinary circumstances.  But trunk
check-ins should always be ready for deployment.

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Re: [fossil-dev] Check-in etiquette

[Jan Nijtmans]

2015-08-27 11:03 GMT+02:00 Baruch Burstein :
> I made the change locally in my makefile and used it. I then made the same
> change in the tcl script and committed that one.
> I guess I could have just committed my hand-changed makefile.

Slightly better would have been to commit it to the "pending-review"
branch. Then someone who has Tcl installed can review the change,
re-generate the makefiles, test it and merge everything
to trunk. This way you eliminate any potential risk, while
still providing your improvements to whoever is interested.

In this case, the change was trivial to be understood, no
harm whatsoever was done.

Regards,
Jan Nijtmans
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Re: [fossil-dev] Check-in etiquette

[Baruch Burstein]

On Thu, Aug 27, 2015 at 11:15 AM, Jan Nijtmans 
wrote:

>
> Joe already correct that:
> 
>

I saw that (thanks from me too).I was wondering for future times.

The only potential problem: people might wonder how you tested
> the change.


I made the change locally in my makefile and used it. I then made the same
change in the tcl script and committed that one.
I guess I could have just committed my hand-changed makefile.

-- 
˙uʍop-ǝpısdn sı ɹoʇıuoɯ ɹnoʎ 'sıɥʇ pɐǝɹ uɐɔ noʎ ɟı
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Re: [fossil-dev] Check-in etiquette

[Jan Nijtmans]

2015-08-27 9:33 GMT+02:00 Baruch Burstein :
> Hi,
>
> I know that when making changes to makemake.tcl, I am expected to run the
> script to generate the new makefiles and check them in as well. However, I
> am on a computer where I cannot easily install TCL (company policy). I
> committed the changes to makemake.tcl without regenerating the makefiles,
> leaving that to someone else. Is this acceptable?

Joe already correct that:


Thanks!

The only potential problem: people might wonder how you tested
the change. In this case, your change works fine and looks good to me.
Joe apparently agreed with this change, I agree as well. Well done!

Regards,
   Jan Nijtmans
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

[fossil-dev] Check-in etiquette

[Baruch Burstein]

Hi,

I know that when making changes to makemake.tcl, I am expected to run the
script to generate the new makefiles and check them in as well. However, I
am on a computer where I cannot easily install TCL (company policy). I
committed the changes to makemake.tcl without regenerating the makefiles,
leaving that to someone else. Is this acceptable?

Baruch

-- 
˙uʍop-ǝpısdn sı ɹoʇıuoɯ ɹnoʎ 'sıɥʇ pɐǝɹ uɐɔ noʎ ɟı
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev