[fossil-users] Name of ZIP file for "ZIP archive"
Hi, In fossil I can select a change, click on "ZIP archive" to download a zip. This is nice. I have been using it frequently and I have been asking people who are not using fossil to get a snapshot of the code. However the file is always named "zip" without extension. When extracted it has a folder which has the name of the repository and a short artifact number. Please would the zip be named the same as this and have the zip extension? It makes it easier on Windows because shell extensions will recognise it and the shell will give it a nice icon. It takes away an extra unncessary renaming step. Thanks Kevin ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
On Sat, Nov 28, 2015 at 11:50 AM, arnoldemu < mem...@arnoldemu.freeserve.co.uk> wrote: > Hi, > > In fossil I can select a change, click on "ZIP archive" to download a zip. > > ...It makes it easier on Windows because shell extensions will recognise > it and the shell will give it a nice icon. It takes away an extra > unncessary renaming step. > see: https://www.fossil-scm.org/index.html/help?cmd=/zip https://www.fossil-scm.org/index.html/help?cmd=zip for how to set the file/dir name -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
On Sat, Nov 28, 2015 at 11:50 AM, arnoldemu < mem...@arnoldemu.freeserve.co.uk> wrote: > Hi, > > In fossil I can select a change, click on "ZIP archive" to download a zip. > > This is nice. I have been using it frequently and I have been asking > people who are not using fossil to get a snapshot of the code. > > However the file is always named "zip" without extension. > If that's happening when you click the zip button in the UI, then that's a bug. i cannot reproduce that on the main fossil site. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
Hi Stephen, Can the fossil zip command be used to configure the name for the UI? >If that's happening when you click the zip button in the UI, then that's a >bug. i cannot reproduce that on the main fossil site. Yes it happens via the UI. Click on artifact Click on Download ZIP Login with anonymous user See the display: ZIP Archive named Arnold-97bb1e1236.zip holding the content of check-in 97bb1e12363f3865: Click on the download button. File is named "zip". Happens with firefox. Thanks Kev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
I put Stephen and not Stephan. Sorry. My mistake. Kev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
On Sat, Nov 28, 2015 at 12:02 PM, arnoldemu < mem...@arnoldemu.freeserve.co.uk> wrote: > > Hi Stephen, No worries - that's a very common mistake and i am quite used to it! Can the fossil zip command be used to configure the name for the UI? > No - only URL parameters can do that. > >If that's happening when you click the zip button in the UI, then that's a > >bug. i cannot reproduce that on the main fossil site. > > Yes it happens via the UI. > > Click on artifact > Click on Download ZIP > Login with anonymous user > > See the display: > > ZIP Archive named Arnold-97bb1e1236.zip holding the content of check-in > 97bb1e12363f3865: > Do you have a link we can try this on? This isn't what i am seeing on the main site, e.g.: http://www.fossil-scm.org/fossil/info/52e3d9d845d1d1ad -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
Hi Stephan, The bug doesn't happen if you're logged in. You have to be logged out. Click the download zip link login as anonymous then a page appears with a download button clicking this button gives the wrong name. I have e-mailed you the link to the fossil repository I am using. I didn't post it here because I don't want it to be public. Thanks Kev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
Kev sent me a private link to the repo off-list... A side-effect of the login redirect is causing this. If you visit the page while logged in, instead of logging in as part of a login redirect when clicking on the zip link, it works. i can't fix this because my left arm is (again) tied up in a sling and programming with only 1 hand is exceedingly annoying, but now that the problem has been reproduced, maybe one of the other devs can take a look at it. To reproduce: - make sure downloading zip files requires being logged in (no guest user access). - without being logged in, visit some version link in the timeline. - click the "download zip" option. - land on the login page. Log in as anonymous. - the redirect back to the zip causes (on my system) 'zip.zip' to be downloaded. - Re-visiting the version's page after logging in, and clicking download zip there, works as expected. Thus is seems the redirect is the problem. On Sat, Nov 28, 2015 at 12:07 PM, Stephan Beal wrote: > On Sat, Nov 28, 2015 at 12:02 PM, arnoldemu < > mem...@arnoldemu.freeserve.co.uk> wrote: > >> >> Hi Stephen, > > > No worries - that's a very common mistake and i am quite used to it! > > Can the fossil zip command be used to configure the name for the UI? >> > > No - only URL parameters can do that. > > >> >If that's happening when you click the zip button in the UI, then that's >> a >> >bug. i cannot reproduce that on the main fossil site. >> >> Yes it happens via the UI. >> >> Click on artifact >> Click on Download ZIP >> Login with anonymous user >> >> See the display: >> >> ZIP Archive named Arnold-97bb1e1236.zip holding the content of check-in >> 97bb1e12363f3865: >> > > Do you have a link we can try this on? This isn't what i am seeing on the > main site, e.g.: > > http://www.fossil-scm.org/fossil/info/52e3d9d845d1d1ad > > -- > - stephan beal > http://wanderinghorse.net/home/stephan/ > http://gplus.to/sgbeal > "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of > those who insist on a perfect world, freedom will have to do." -- Bigby Wolf > -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
Thus said Stephan Beal on Sat, 28 Nov 2015 16:56:49 +0100: > i can't fix this because my left arm is (again) tied up in a sling and > programming with only 1 hand is exceedingly annoying, but now that the > problem has been reproduced, maybe one of the other devs can take a > look at it. I looked at it and the problem is that Fossil does not properly respond to the form it generates here: http://www.fossil-scm.org/index.html/artifact/49c6b1327a9aea3b0682b2c55bddd9d54860ff6f?txt=1&ln=478,488 When the user clicks on the Download button that this page generates, the browser sends a request for: /zip?name=abc&uuid=123 When Fossil receives this request, it doesn't properly set Content-disposition to tell the browser what the name of the file should be for the data that it sends back in the response. One potential fix is just to put the filename in the URL: http://www.fossil-scm.org/index.html/info/5f32bf719d7440d3 A larger fix might involve adding code to return a Content-Disposition header (I have such a patch, but if the aforementioned fix is suitable, might as well use it since it is only 1 line change). Should we instead be using Content-disposition to enable clients which don't include the /RID.zip portion of the URL to get a hint as to what they should call the file? Andy -- TAI64 timestamp: 4000565a087a ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
On Sat, Nov 28, 2015 at 9:02 PM, Andy Bradford wrote: > One potential fix is just to put the filename in the URL: > > http://www.fossil-scm.org/index.html/info/5f32bf719d7440d3 > > A larger fix might involve adding code to return a Content-Disposition > header (I have such a patch, but if the aforementioned fix is suitable, > might as well use it since it is only 1 line change). > > Should we instead be using Content-disposition to enable clients which > don't include the /RID.zip portion of the URL to get a hint as to what > they should call the file? > given that this has somehow never come up until today, i'd go for the one-liner. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
Thus said Stephan Beal on Sat, 28 Nov 2015 22:01:42 +0100: > given that this has somehow never come up until today, i'd go for the > one-liner. Sounds fine to me. I'll merge it later if there are no objections expressed by others. Andy -- TAI64 timestamp: 4000565a1c79 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
Thankyou Andy and Stephan! :) Kev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Name of ZIP file for "ZIP archive"
On 11/28/2015 7:56 AM, Stephan Beal wrote: Kev sent me a private link to the repo off-list... A side-effect of the login redirect is causing this. If you visit the page while logged in, instead of logging in as part of a login redirect when clicking on the zip link, it works This just happened to me today as I was going through some old projects and making ZIPs to archive of the final builds. I hadn't logged into the repos in a very long time, and our normal configuration requires some user logged in to use the ZIP and tar links. On my Win7 Pro with Firefox, the effect was a file name just "zip" with no extension at all. Both my server and client are running 1.34. If I had caught up on the long weekend's email traffic before attending to that chore, I would have seen this thread and logged in first. -- Ross Berteig r...@cheshireeng.com Cheshire Engineering Corp. http://www.CheshireEng.com/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
