Re: [fossil-users] Seg fault when doing 'fossil http'

2012-10-10 Thread David Given
Richard Hipp wrote:
[...]
 Worked ok here.  What version of fossil do you have?  What does fossil
 version tell you?

I'm on Debian, and am seeing it both the current release:

This is fossil version 1.22 [ab461f39af] 2012-03-29 08:48:38 UTC

...and from the upcoming release:

This is fossil version 1.23 [d3512db100] 2012-08-19 12:09:31 UTC

...and I've tried tip from the repo and it's there too.

I've tracked it down. From cmd_http():

  if( g.argc!=2  g.argc!=3  g.argc!=6 ){
fossil_fatal(no repository specified);
  }
  g.fullHttpReply = 1;
  if( g.argc==6 ){
g.httpIn = fossil_fopen(g.argv[3], rb);
g.httpOut = fossil_fopen(g.argv[4], wb);
zIpAddr = g.argv[5];
  }else{
g.httpIn = stdin;
g.httpOut = stdout;
zIpAddr = 0;
  }

fossil_fatal() tries to write an error message to g.httpOut, which of
course hasn't been set up yet, and so ends up doing fprintf(NULL, ...).

-- 
┌─── dg@cowlark.com ─ http://www.cowlark.com ─
│ Parents let children ride bicycles on the street. But parents do not
│ allow children to hear vulgar words. Therefore we can deduce that
│ cursing is more dangerous than being hit by a car. --- Scott Adams
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] Seg fault when doing 'fossil http'

2012-10-09 Thread David Given
So I tried this:

fossil http /home/fossil --baseurl http://cowlark.com/fossil

Now, I know now that the version of Fossil I was testing with doesn't
support --baseurl, but I surprised to get this in response:

Segmentation fault

Brief experimentation shows that any unrecognised option after the
repository is treated like this, so it's probably a simple option
parsing bug. Is this known about or would you like a formal bug report?

-- 
┌─── dg@cowlark.com ─ http://www.cowlark.com ─
│ Of course, on a sufficiently small planet, 40 km/hr is, in fact,
│ sufficient to punt the elastic spherical cow into low orbit. ---
│ Brooks Moses on r.a.sf.c



signature.asc
Description: OpenPGP digital signature
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seg fault when doing 'fossil http'

2012-10-09 Thread Richard Hipp
On Tue, Oct 9, 2012 at 6:37 PM, David Given d...@cowlark.com wrote:

 So I tried this:

 fossil http /home/fossil --baseurl http://cowlark.com/fossil

 Now, I know now that the version of Fossil I was testing with doesn't
 support --baseurl, but I surprised to get this in response:

 Segmentation fault

 Brief experimentation shows that any unrecognised option after the
 repository is treated like this, so it's probably a simple option
 parsing bug. Is this known about or would you like a formal bug report?


Worked ok here.  What version of fossil do you have?  What does fossil
version tell you?




 --
 ┌─── dg@cowlark.com ─ http://www.cowlark.com ─
 │ Of course, on a sufficiently small planet, 40 km/hr is, in fact,
 │ sufficient to punt the elastic spherical cow into low orbit. ---
 │ Brooks Moses on r.a.sf.c


 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users