Re: [fossil-users] Stash and local directory

2011-11-03 Thread Richard Hipp
2011/11/3 Lluís Batlle i Rossell 

> Hello,
>
> I noticed that 'fossil stash save' only saves the files that are under the
> subdirectory I run the command. Shouldn't it save all the changed files in
> the
> repository?
>


Fixed as of http://www.fossil-scm.org/fossil/ci/966ae9a942?sbs=1 - the fix
is the first change in the diff.


-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Stash and local directory

2011-11-03 Thread Stephan Beal
And this time to the list...

On Thu, Nov 3, 2011 at 6:11 PM, Konstantin Khomoutov <
flatw...@users.sourceforge.net> wrote:

> Well, possibly it's my Git mindset chiming in, but I can't recall
> that I ever saw anyone using the term "working tree" to refer to the
> current working directory.  The term "tree" in my eyes refers to the
> "repository state in a DVCS system".  That is, each commit refers to a
> tree, and the current checkout is itself a tree--"the working tree".
>

Sorry, yes - i think that's the most intuitive interpretation.

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Stash and local directory

2011-11-03 Thread Konstantin Khomoutov
On Thu, 3 Nov 2011 17:58:47 +0100
Stephan Beal  wrote:

>> "Save the current changes in the working tree as a new stash."
>> So looks like you've found a bug.
> i disagree - the wording there is slightly ambiguous: "working tree"
> could be interpreted as the entire checkout or "tree" ==
> "subdirectory".
Well, possibly it's my Git mindset chiming in, but I can't recall
that I ever saw anyone using the term "working tree" to refer to the
current working directory.  The term "tree" in my eyes refers to the
"repository state in a DVCS system".  That is, each commit refers to a
tree, and the current checkout is itself a tree--"the working tree".
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Stash and local directory

2011-11-03 Thread Stephan Beal
On Thu, Nov 3, 2011 at 5:51 PM, Konstantin Khomoutov <
flatw...@users.sourceforge.net> wrote:

> "Save the current changes in the working tree as a new stash."
>
> So looks like you've found a bug.
>

i disagree - the wording there is slightly ambiguous: "working tree" could
be interpreted as the entire checkout or "tree" == "subdirectory".


>
> And I, for one, also think that stashing should affect the whole
> working tree unless the user explicitly specified what files they want
> to stash.
>

Agreed.

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Stash and local directory

2011-11-03 Thread Konstantin Khomoutov
On Thu, 3 Nov 2011 12:50:02 +0100
Lluís Batlle i Rossell  wrote:

> I noticed that 'fossil stash save' only saves the files that are
> under the subdirectory I run the command. Shouldn't it save all the
> changed files in the repository?

My v1.20 build says in its `fossil help stash` output:

"Save the current changes in the working tree as a new stash."

So looks like you've found a bug.

And I, for one, also think that stashing should affect the whole
working tree unless the user explicitly specified what files they want
to stash.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] Stash and local directory

2011-11-03 Thread Lluís Batlle i Rossell
Hello,

I noticed that 'fossil stash save' only saves the files that are under the
subdirectory I run the command. Shouldn't it save all the changed files in the
repository?

Regards,
Lluís.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users