Re: [fossil-users] State of tkt-hook-change branch
2013/12/16 Jan Nijtmans jan.nijtm...@gmail.com: @Joe/Richard: Any reason to hold back merging this to trunk? If not, I'm happy to do the merge. No-one objected, so merged to trunk now. Happy Christmas days to all! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
2013/12/13 Mark Janssen mpc.jans...@gmail.com: Thanks for the quick fixes :) Everything works great now. @Joe/Richard: Any reason to hold back merging this to trunk? If not, I'm happy to do the merge. Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] State of tkt-hook-change branch
What is the state of the tkt-hool-change branch? I tried using it for my own local repo and I can't get the http ticket hook to trigger. th1-uri-regexp: .* hook command is: http -asynchronous -- http://mpcjanssen.nl/cgi-bin/tkt-hook?uuid=$uuid After adding some debugging statements the hook command seems to fail with: Executing th1 common script Executing 1 th1 specific script http -asynchronous -- http://mpcjanssen.nl/cgi-bin/tkt-hook?uuid=$uuid parsing URL http://mpcjanssen.nl/cgi-bin/tkt-hook?uuid=7f4a275ec1d71597006fa063a57c166033937ca8 url must be http:// or https:// Anyone has any idea what's up? Mark ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
2013/12/13 Mark Janssen mpc.jans...@gmail.com: What is the state of the tkt-hool-change branch? I tried using it for my own local repo and I can't get the http ticket hook to trigger. Looks like an uninitialized variable. Should be fixed now. I think it's ready to be merged to trunk. Thanks! Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
On Fri, Dec 13, 2013 at 12:29 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2013/12/13 Mark Janssen mpc.jans...@gmail.com: What is the state of the tkt-hool-change branch? I tried using it for my own local repo and I can't get the http ticket hook to trigger. Looks like an uninitialized variable. Should be fixed now. I think it's ready to be merged to trunk. Thanks! With the updated version [85528ef507] I still get the same error. xfer_run_script still fails with error: url must be http:// or https:// At xfer.c line 869 Maybe there is something else I am doing wrong? Regards, Mark ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
2013/12/13 Mark Janssen mpc.jans...@gmail.com: With the updated version [85528ef507] I still get the same error. xfer_run_script still fails with error: url must be http:// or https:// At xfer.c line 869 Maybe there is something else I am doing wrong? More likely that I did something wrong, like an incomplete commit. Please try again ;-) Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
On Fri, Dec 13, 2013 at 2:15 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2013/12/13 Mark Janssen mpc.jans...@gmail.com: With the updated version [85528ef507] I still get the same error. xfer_run_script still fails with error: url must be http:// or https:// At xfer.c line 869 Maybe there is something else I am doing wrong? More likely that I did something wrong, like an incomplete commit. Please try again ;-) Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users Hi Jan, Two remarks: 1) I am fairly sure that: memset(urlData, '0', sizeof(urlData)); Should be memset(urlData, 0, sizeof(urlData)); 2) I think url_parse_local should be fixed to properly fill all the urlData fields instead of having to memset the structure before. Mark BTW with memset 0 it works :) ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
On Fri, Dec 13, 2013 at 3:19 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: Thanks for your feedback! One final piece of feedback, concerning the next step in the trigger process. Fossil seems to encode the trigger request as Content-Type: text/plain even in the case of a GET. Unfortunately this will lead to an error when trying to parse the request using tcllib's ncgi. ncgi only supports: - text/xml* - application/x-www-form-urlencoded* - application/x-www-urlencoded* And reading the specs it seems that a GET request should not specify a content-type at all. Mark ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
2013/12/13 Mark Janssen mpc.jans...@gmail.com: One final piece of feedback, concerning the next step in the trigger process. Fossil seems to encode the trigger request as Content-Type: text/plain even in the case of a GET. Unfortunately this will lead to an error when trying to parse the request using tcllib's ncgi. ncgi only supports: - text/xml* - application/x-www-form-urlencoded* - application/x-www-urlencoded* And reading the specs it seems that a GET request should not specify a content-type at all. Neither content-length ;-( http://fossil-scm.org/index.html/info/a60d2976ff Again, Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] State of tkt-hook-change branch
On Fri, Dec 13, 2013 at 4:18 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2013/12/13 Mark Janssen mpc.jans...@gmail.com: One final piece of feedback, concerning the next step in the trigger process. Fossil seems to encode the trigger request as Content-Type: text/plain even in the case of a GET. Unfortunately this will lead to an error when trying to parse the request using tcllib's ncgi. ncgi only supports: - text/xml* - application/x-www-form-urlencoded* - application/x-www-urlencoded* And reading the specs it seems that a GET request should not specify a content-type at all. Neither content-length ;-( http://fossil-scm.org/index.html/info/a60d2976ff Again, Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users Thanks for the quick fixes :) Everything works great now. Mark ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
