Re: [fossil-users] Tickets without title...
On Sun, Aug 18, 2013 at 9:18 AM, Stephan Beal sgb...@googlemail.com wrote: On Sun, Aug 18, 2013 at 3:00 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: Possible solution: - If someone with moderation rights comments on a ticket which is not approved yet: - Either approve the ticket implicitly. - Or make the comment pending approval even though the user has moderation rights i don't have a problem with either, but would argue slightly more for the latter simply because it's more difficult to import junk that way. i remember my first moderation attempts - i commented on the tickets before declining them (just to be polite), and that caused my comments to sync but not the ticket (IIRC), which Richard pointed out to me. i don't remember declining the ticket in this case, but did drop a comment or three. - If someone rejects a ticket submission, all comments should be rejected as well. i think that's only possible if the ticket is rejected first? What happens to approved comments if the ticket goes away? In this case i'm pretty sure i moderated some of the comments first because they appeared first (top) in the timeline. Maybe require that comments on unapproved tickets can't be approved until the ticket is approved? ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tickets without title...
On Mon, Aug 19, 2013 at 8:24 PM, Ron Wilson ronw.m...@gmail.com wrote: On Sun, Aug 18, 2013 at 9:18 AM, Stephan Beal sgb...@googlemail.comwrote: On Sun, Aug 18, 2013 at 3:00 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: Possible solution: - If someone with moderation rights comments on a ticket which is not approved yet: - Either approve the ticket implicitly. - Or make the comment pending approval even though the user has moderation rights Maybe require that comments on unapproved tickets can't be approved until the ticket is approved? They all seem fairly reasonable to me, but i cannot say which would would be easiest/best-fit (don't know those code bits - the library porting hasn't gotten to tickets yet). -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tickets without title...
On Sun, Aug 18, 2013 at 2:40 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: Why do those two tickets don't have a title/status/severity/... any more? http://fossil-scm.org/index.html/tktview?name=6aeda5a5f3 http://fossil-scm.org/index.html/tktview?name=311671db59 I don't remember noting that before. Something happened in the last few days? That was most probably my fault - yesterday i went through the pending moderation requests and i think i made a mess of it with those two tickets, allowing some of the request and rejecting others. i didn't realize i had done so until the 3rd or 4th change on the first ticket. i suspect that when moderating i need to either allow a whole thread or none of the thread to avoid this type of thing. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tickets without title...
2013/8/18 Jan Nijtmans jan.nijtm...@gmail.com: Why do those two tickets don't have a title/status/severity/... any more? http://fossil-scm.org/index.html/tktview?name=6aeda5a5f3 http://fossil-scm.org/index.html/tktview?name=311671db59 I don't remember noting that before. Something happened in the last few days? Just a wild guess what could have happend: - Someone without moderation rights submitted a ticket - Someone else with moderation rights commented on that. - The original ticket was rejected. This way, the original ticket information is gone, but the comments still exist so the ticket cannot be removed completely. I'm not that familiar how ticket moderation works, but this sounds like a bug to me. Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tickets without title...
On Sun, Aug 18, 2013 at 2:52 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: Just a wild guess what could have happend: - Someone without moderation rights submitted a ticket - Someone else with moderation rights commented on that. - The original ticket was rejected. i can't say. This way, the original ticket information is gone, but the comments still exist so the ticket cannot be removed completely. I'm not that familiar how ticket moderation works, but this sounds like a bug to me. The bug was probably in my workflow, but yes, it ideally shouldn't lead to this type of thing. In the future i'll take care to reject comments on rejected tickets. Part of the problem is that i didn't go through the requests in order because i took care of the ones from the top of the timeline before looking at the moderation page for the rest of the list ( http://fossil-scm.org/index.html/modreq). -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tickets without title...
2013/8/18 Stephan Beal sgb...@googlemail.com: That was most probably my fault I'm not convinced on that. If someone with moderation rights comments on a ticket which is not approved yet, this can happen as well. Possible solution: - If someone with moderation rights comments on a ticket which is not approved yet: - Either approve the ticket implicitly. - Or make the comment pending approval even though the user has moderation rights - If someone rejects a ticket submission, all comments should be rejected as well. Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Tickets without title...
On Sun, Aug 18, 2013 at 3:00 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2013/8/18 Stephan Beal sgb...@googlemail.com: That was most probably my fault I'm not convinced on that. i'm the one who moderated that whole chain, i think, so i'm pretty sure it's my fault ;). If someone with moderation rights comments on a ticket which is not approved yet, this can happen as well. That might be - i'm not yet familiar with the inner workings of moderation. Possible solution: - If someone with moderation rights comments on a ticket which is not approved yet: - Either approve the ticket implicitly. - Or make the comment pending approval even though the user has moderation rights i don't have a problem with either, but would argue slightly more for the latter simply because it's more difficult to import junk that way. i remember my first moderation attempts - i commented on the tickets before declining them (just to be polite), and that caused my comments to sync but not the ticket (IIRC), which Richard pointed out to me. i don't remember declining the ticket in this case, but did drop a comment or three. - If someone rejects a ticket submission, all comments should be rejected as well. i think that's only possible if the ticket is rejected first? What happens to approved comments if the ticket goes away? In this case i'm pretty sure i moderated some of the comments first because they appeared first (top) in the timeline. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
