Re: [fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Graeme Geldenhuys
Op 2010-05-30 21:33, Joost van der Sluis het geskryf:
> 
> Sigh: http://www.freepascal.org/~joost/wwwroot/testsuiteweb.cgi


The new one looks very nice Some pointers on things I noted (hope you
don't mind):

* once you view the details of a test run, there is not Back button or Main
  button to get back to the main screen.

* On the main screen I have no idea what date format is used? Maybe use
  the ISO 8601 (international date/time) format to stop any possible
  confusion.

* In your initial post you mentioned that it is tests run each night. Yet
  all the tests listed on the first page you see are (I think - that's if
  I am interpreting the date format correctly) 2003-11 and 2003-10. That's
  rather long ago, and I don't really see the point in keeping such a
  archive for daily tests runs. Surely the daily results is all you want
  to see, or a maximum of say last 7 days.

* Failure details. On the main screen it says the one test run caused 33
  failures. I click on that row which opens the details. Page 1 or 66!
  1) Maybe that could be reduced to some summary/collapsed view first.
  2) How do I get a listing of only the 33 tests that failed? I don't
 want to scroll 66 pages looking for them.

* In the test listed below, which was a test run for 2003-10-31, there is
  a test result dated 2007-01-28?? See attached image. So somewhere your
  details query is pulling wrong data, or the data is corrupt.


http://www.freepascal.org/~joost/wwwroot/testsuiteweb.cgi?action=testrun&TestRunID=103


Regards,
  - Graeme -

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://opensoft.homeip.net/fpgui/

<>___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Graeme Geldenhuys
On 30 May 2010 21:18, Joost van der Sluis wrote:
>
> Maybe you know this site:
> http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi with the
> results of the automatic testruns for each night.

Both look the same (because they are the same link).

More worrying is that not a single test run listed produced 0 errors. :-/


> page. But I'm not a designer, so I thought that maybe someone else had a
> better idea...

I would immediately suggest tagging the various parts of the HTML
output with  tags. This would allow a web designer or
somebody skilled with CSS to easily improve the look with little
effort. Look at the FPCUnit test output which uses XML + CSS. Or you
can transform the XML via XSLT to pre-generate HTML and CSS for the
final result.

Here is an example of pre-generated HTML+CSS from the XML output using
XSLT processing.
  http://opensoft.homeip.net/tiopf/fpcunit/index64.html



-- 
Regards,
  - Graeme -


___
fpGUI - a cross-platform Free Pascal GUI toolkit
http://opensoft.homeip.net/fpgui/
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Joost van der Sluis
On Sun, 2010-05-30 at 13:05 -0700, Leonardo M. Ramé wrote:
> joost, nice work. I love the filters below the header in the grid, what did 
> you use for that? some jQuery component?

Yes, I used jqGrid: http://www.trirand.com/blog/

The webdesign package has a component for it.

Joost.



___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Leonardo M . Ramé
joost, nice work. I love the filters below the header in the grid, what did you 
use for that? some jQuery component?

Leonardo M. Ramé
http://leonardorame.blogspot.com


--- On Sun, 5/30/10, Joost van der Sluis  wrote:

> From: Joost van der Sluis 
> Subject: Re: [fpc-devel] fcl-web example and new testsuite website
> To: "FPC developers' list" 
> Date: Sunday, May 30, 2010, 4:33 PM
> On Sun, 2010-05-30 at 21:22 +0200,
> Florian Klaempfl wrote:
> > Joost van der Sluis schrieb:
> > > Hi all,
> > > 
> > > Maybe you know this site:
> > > http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi
> with the
> > > results of the automatic testruns for each
> night.
> > > 
> > > I've made a new version, using the webdesign
> package. You can see the
> > > result here: http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi
> > 
> > Looks like the old one ;)
> 
> Yeah, I made a perfect copy. ;)
> 
> Sigh: http://www.freepascal.org/~joost/wwwroot/testsuiteweb.cgi
> 
> Joost.
> 
> 
> 
> ___
> fpc-devel maillist  -  fpc-devel@lists.freepascal.org
> http://lists.freepascal.org/mailman/listinfo/fpc-devel
> 



___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Joost van der Sluis
On Sun, 2010-05-30 at 21:22 +0200, Florian Klaempfl wrote:
> Joost van der Sluis schrieb:
> > Hi all,
> > 
> > Maybe you know this site:
> > http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi with the
> > results of the automatic testruns for each night.
> > 
> > I've made a new version, using the webdesign package. You can see the
> > result here: http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi
> 
> Looks like the old one ;)

Yeah, I made a perfect copy. ;)

Sigh: http://www.freepascal.org/~joost/wwwroot/testsuiteweb.cgi

Joost.



___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Florian Klaempfl
Joost van der Sluis schrieb:
> Hi all,
> 
> Maybe you know this site:
> http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi with the
> results of the automatic testruns for each night.
> 
> I've made a new version, using the webdesign package. You can see the
> result here: http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi

Looks like the old one ;)
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


[fpc-devel] fcl-web example and new testsuite website

2010-05-30 Thread Joost van der Sluis
Hi all,

Maybe you know this site:
http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi with the
results of the automatic testruns for each night.

I've made a new version, using the webdesign package. You can see the
result here: http://www.freepascal.org/testsuite/cgi-bin/testsuite.cgi

Source: http://www.freepascal.org/~joost/testsuiteweb_20100530.tgz

I don't like the layout, though. Especially not for the (single) testrun
page. But I'm not a designer, so I thought that maybe someone else had a
better idea...

Joost.

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] var param as property index?

2010-05-30 Thread dmitry boyarintsev
On Sun, May 30, 2010 at 5:29 PM, Martin  wrote:
> I don't think the following is intended? (it compiles with trunc).
>
> Note the property index is a var param
>
>
>  TForm1 = class(TForm)
>  private
>    function GetFoo(var Index: Integer): Boolean;
>  public
>    property Foo[var Index: Integer]: Boolean read GetFoo;
>  end;
>

does FPC compile the following, in this case:

var
  f : TForm1;

writeln(f.Foo[0]);

thanks,
dmitry
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


[fpc-devel] var param as property index?

2010-05-30 Thread Martin

I don't think the following is intended? (it compiles with trunc).

Note the property index is a var param


  TForm1 = class(TForm)
  private
function GetFoo(var Index: Integer): Boolean;
  public
property Foo[var Index: Integer]: Boolean read GetFoo;
  end;

implementation

function TForm1.GetFoo(var Index: Integer): Boolean;
begin
  Result := True;
end;

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel