Re: [fpc-devel] [PATCH] XMLCFG AnsiStringDOMString conversion

2010-11-06 Thread Sergei Gorelkin

Felipe Monteiro de Carvalho пишет:

On Fri, Nov 5, 2010 at 6:15 PM, Dariusz Mazur dar...@emadar.com wrote:

I say wrong: how to change code page used to implicit conversion
ansistring- wide string


Use the appropriate conversion routine instead, and avoid implicit
conversions for they are not reliable.

It is impossible to avoid implicit conversions with xmlcfg, because they occur within unit 
implementation.

I should have marked xmlcfg as deprecated a long time ago. Anyway, done in 
rev.16307.

Regards,
Sergei

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel


Re: [fpc-devel] memleak in fpdoc

2010-11-06 Thread Vincent Snijders
2010/11/5 Michael Van Canneyt mich...@freepascal.org:


 On Fri, 5 Nov 2010, Vincent Snijders wrote:

 Hi,

 I am trying to fix the memleaks in fpdoc. Attached is a patch for
 pascal parser package.

 There are still more leaks, but that is for another time.

I debugged some more. In procedure
ProcessInheritanceStrings(inhInfo:TStringList) the inhclass string
list is created, but not freed. The trivial patch below fixes that.
Another problem is the line:
   if not assigned(CreateAliasType(alname,clname,cls,cls2)) then
The return value of CreateAliasType doesn't seem to be freed/released.
I don't know how to fix that.

Vincent

Index: utils/fpdoc/dglobals.pp
===
--- utils/fpdoc/dglobals.pp (revision 16307)
+++ utils/fpdoc/dglobals.pp (working copy)
@@ -856,7 +856,8 @@
  cls2:=ResolveAndLinkClass(clname,j=0,cls);
  end;
  end;
-end;
+ inhclass.free;
+   end;

   var
 s, Name: String;
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel