Re: [fpc-devel] Compiler message colour scheme

2020-11-23 Thread J. Gareth Moreton via fpc-devel
I'm doing some optimisation development for x86_64 currently, so I can 
give it a test run if you like - got the Raspberry Pi for arm-linux and 
aarch64-linux too, but it might take more then a day.  I'll let you know.


Gareth aka. Kit

On 24/11/2020 01:13, Tomas Hajny via fpc-devel wrote:

On 2020-11-24 01:14, J. Gareth Moreton via fpc-devel wrote:

I'd say thie first port of call is "compiler/comphook.pas", line 258:

procedure WriteColoredOutput(var t: Text;color: TOutputColor;const s :
AnsiString);

It looks like a simple "$if defined".


Yes, and the more platforms are added, the more messy this unit gets. 
:-( I tried to clean it up a bit by moving the platform-specific parts 
to a new unit - see the attachment containing a diff for comphook.pas 
and the new unit. I didn't commit yet because I couldn't test it on 
the other platforms (my new implementation for OS/2 works OK ;-) ). If 
somebody tests is under Linux and WinXX, I'll committ it tomorrow.


Tomas

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel



--
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Compiler message colour scheme

2020-11-23 Thread Tomas Hajny via fpc-devel

On 2020-11-24 01:14, J. Gareth Moreton via fpc-devel wrote:

I'd say thie first port of call is "compiler/comphook.pas", line 258:

procedure WriteColoredOutput(var t: Text;color: TOutputColor;const s :
AnsiString);

It looks like a simple "$if defined".


Yes, and the more platforms are added, the more messy this unit gets. 
:-( I tried to clean it up a bit by moving the platform-specific parts 
to a new unit - see the attachment containing a diff for comphook.pas 
and the new unit. I didn't commit yet because I couldn't test it on the 
other platforms (my new implementation for OS/2 works OK ;-) ). If 
somebody tests is under Linux and WinXX, I'll committ it tomorrow.


Tomas
<>
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Compiler message colour scheme

2020-11-23 Thread J. Gareth Moreton via fpc-devel

I'd say thie first port of call is "compiler/comphook.pas", line 258:

procedure WriteColoredOutput(var t: Text;color: TOutputColor;const s : 
AnsiString);


It looks like a simple "$if defined".

Gareth aka. Kit

On 24/11/2020 00:08, Ryan Joseph via fpc-devel wrote:



On Nov 23, 2020, at 1:33 AM, Michael Van Canneyt via fpc-devel 
 wrote:

I ran the compiler on linux through a ssh session:

The colors display just fine, so I see no reason to disable on darwin except
that the termio unit is not found...

If Florian wants to provide some explanation as to where the colors were added 
I'll enable them on mac and test them myself.

Regards,
Ryan Joseph

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel



--
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Compiler message colour scheme

2020-11-23 Thread Ryan Joseph via fpc-devel


> On Nov 23, 2020, at 1:33 AM, Michael Van Canneyt via fpc-devel 
>  wrote:
> 
> I ran the compiler on linux through a ssh session:
> 
> The colors display just fine, so I see no reason to disable on darwin except
> that the termio unit is not found...

If Florian wants to provide some explanation as to where the colors were added 
I'll enable them on mac and test them myself.

Regards,
Ryan Joseph

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Compiler message colour scheme

2020-11-23 Thread Michael Van Canneyt via fpc-devel



On Sun, 22 Nov 2020, Jonas Maebe via fpc-devel wrote:


On 22/11/2020 17:42, Sven Barth via fpc-devel wrote:

Am 22.11.2020 um 17:40 schrieb J. Gareth Moreton via fpc-devel:

Most modern Macs are Unix-based, so the escape sequences should work,
right? Granted, I think we need someone with a Mac or a Mac virtual
machine to test it for sure.


Considering that Jonas doesn't support the textmode IDE on macOS because
of - if I remember correctly - problems with the terminal


No, the terminal works fine with it (apart from mouse support, which
only works if you use Xterm). I don't support it because the IDE is not
really maintained by anyone, and I don't want to maintain or debug it
either (so if someone would report a bug on macOS with it, it would just
sit there forever).


I ran the compiler on linux through a ssh session:

The colors display just fine, so I see no reason to disable on darwin except
that the termio unit is not found...

Michael.
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel