[fpc-devel] Test, please ignore

2023-12-25 Thread Maxim Ganetsky via fpc-devel

Hello.

Test, please ignore.

--
Best regards,
 Maxim Ganetsky  mailto:gan...@narod.ru

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


[fpc-devel] fpdoc path + system.uitypes problems.

2023-12-25 Thread Marco van de Voort via fpc-devel


(forum thread: 
https://forum.lazarus.freepascal.org/index.php/topic,65629.0.html)


Don noticed that the system.uitypes lemma's in the CHM are empty, both 
with 3.2.x as 3.3.x fpdoc.


I checked the only html snapshot and it is the same: 
https://www.freepascal.org/daily/doc/rtl/system.uitypes/index-5.html


I can remember that I tried to debug this a while back, and that this is 
a fundamental problem of fpdoc because it uses dots to separate the 
parts of a lemma. (e.g. packagename.unitname.recordtype.fieldname).  
Separating a path on dot then breaks the unit name. If unit name is 
system.uitypes.somevariable, it tries to find symbol uitypes in system, 
and then searches for a  field in somevariable  etc.


To fix this either we have to e.g. keep a list of packages and a list of 
units and then try to disambiguate to only pick the longest match. That 
maybe have risks that other corner cases be found or that the list of 
units is not yet complete at any point when this system is inside 
fpdoc.  This requires no changes to the .xmls


A more definitive choice is to change something about the notation and 
somehow replace or escape dots within identifiers. like  
rtl.#system.uitypes#.recordtype.fieldname  or like 
rtl.system#uitypes.recordtype.fieldname or 
rtl.system..uitypes.recordtype.fieldname. (exact characters to be used 
T.b.d.    Only requires changes to the XML for dotted unit names.


Opinions etc ?



___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Failing Lazarus Codetools Pas2JS-related tests

2023-12-25 Thread Michael Van Canneyt via fpc-devel




On Mon, 25 Dec 2023, Maxim Ganetsky via fpc-devel wrote:


||
-Fu$CfgDir../lib/fpc/3.3.1/pas2js/rtl/src
|


I see that there are missing directory separators after $CfgDir, maybe this 
is the reason?


I added it.



Also probably it would be worth to consider removing code duplication between 
createconfig.pp and fpmake.pp in regards of config file generation.


I'd rather not. Preferably, the fpmake.pp file should not depend on anything.

Michael.
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Failing Lazarus Codetools Pas2JS-related tests

2023-12-25 Thread Maxim Ganetsky via fpc-devel

25.12.2023 16:51, Maxim Ganetsky via fpc-devel пишет:

25.12.2023 13:01, Michael Van Canneyt via fpc-devel пишет:



On Sun, 24 Dec 2023, Maxim Ganetsky via fpc-devel wrote:

As far as I know, Mattias is busy with it and has at least fixed 
the tests ?


I see the commit by Mattias now, but it does not affect config 
file created by `make install`, because the following duplicated 
code is used for creating config files when running `make install`:



https://gitlab.com/freepascal.org/fpc/pas2js/-/blob/main/fpmake.pp?ref_type=heads#L20 



I updated the config file writing. 2 files are written now. My 
local tests are all OK.


Please elaborate. I just updated FPC and Pas2Js, nothing changed in 
behavior. Where is the commit?


Sorry, forgot to push. fpmake.pp in pas2js repo. 


OK, now config contents have changed, but Codetools tests still fail 
with the same error (pas2js system unit not found). Config contents:


Contents of /usr/local/bin/pas2js.cfg:
|
#
||
# Minimal config file for pas2js compiler
||
#
||
# -d is the same as #DEFINE
||
# -u is the same as #UNDEF
||
#
||
# Write always a nice logo ;)
||
-l
||

||
# Display Warnings, Notes and Hints
||
-vwnh
||
# If you don't want so much verbosity use
||
#-vw

#IFDEF FPC_SUBTARGET_NAMESPACED

-Fu$CfgDir../lib/fpc/3.3.1/pas2js/*/namespaced
||
-Fi$CfgDir../lib/fpc/3.3.1/pas2js/*/src
||
-Fu$CfgDir../lib/fpc/3.3.1/pas2js/rtl/src
|


I see that there are missing directory separators after $CfgDir, maybe 
this is the reason?


Also probably it would be worth to consider removing code duplication 
between createconfig.pp and fpmake.pp in regards of config file generation.



|||
#else
||
-Fu$CfgDir../lib/fpc/3.3.1/pas2js/*/src
||
#endif
||

||
#IFDEF nodejs
||
-Jirtl.js
||
#ENDIF
||

||
# Put all generated JavaScript into one file
||
-Jc
||

||
# end.

||
Contents of /usr/local/bin/pas2js-namespaced.cfg:
||-dUNICODERTL|

--

Best regards,
 Maxim Ganetskymailto:gan...@narod.ru
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Failing Lazarus Codetools Pas2JS-related tests

2023-12-25 Thread Maxim Ganetsky via fpc-devel

25.12.2023 13:01, Michael Van Canneyt via fpc-devel пишет:



On Sun, 24 Dec 2023, Maxim Ganetsky via fpc-devel wrote:

As far as I know, Mattias is busy with it and has at least fixed 
the tests ?


I see the commit by Mattias now, but it does not affect config file 
created by `make install`, because the following duplicated code is 
used for creating config files when running `make install`:



https://gitlab.com/freepascal.org/fpc/pas2js/-/blob/main/fpmake.pp?ref_type=heads#L20 



I updated the config file writing. 2 files are written now. My local 
tests are all OK.


Please elaborate. I just updated FPC and Pas2Js, nothing changed in 
behavior. Where is the commit?


Sorry, forgot to push. fpmake.pp in pas2js repo. 


OK, now config contents have changed, but Codetools tests still fail 
with the same error (pas2js system unit not found). Config contents:


Contents of /usr/local/bin/pas2js.cfg:
|
#
||
# Minimal config file for pas2js compiler
||
#
||
# -d is the same as #DEFINE
||
# -u is the same as #UNDEF
||
#
||
# Write always a nice logo ;)
||
-l
||

||
# Display Warnings, Notes and Hints
||
-vwnh
||
# If you don't want so much verbosity use
||
#-vw

#IFDEF FPC_SUBTARGET_NAMESPACED

-Fu$CfgDir../lib/fpc/3.3.1/pas2js/*/namespaced
||
-Fi$CfgDir../lib/fpc/3.3.1/pas2js/*/src
||
-Fu$CfgDir../lib/fpc/3.3.1/pas2js/rtl/src
||
#else
||
-Fu$CfgDir../lib/fpc/3.3.1/pas2js/*/src
||
#endif
||

||
#IFDEF nodejs
||
-Jirtl.js
||
#ENDIF
||

||
# Put all generated JavaScript into one file
||
-Jc
||

||
# end.

||
Contents of /usr/local/bin/pas2js-namespaced.cfg:
||-dUNICODERTL|

--
Best regards,
 Maxim Ganetskymailto:gan...@narod.ru
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Failing Lazarus Codetools Pas2JS-related tests

2023-12-25 Thread Michael Van Canneyt via fpc-devel




On Sun, 24 Dec 2023, Maxim Ganetsky via fpc-devel wrote:

As far as I know, Mattias is busy with it and has at least fixed the 
tests ?


I see the commit by Mattias now, but it does not affect config file 
created by `make install`, because the following duplicated code is 
used for creating config files when running `make install`:




https://gitlab.com/freepascal.org/fpc/pas2js/-/blob/main/fpmake.pp?ref_type=heads#L20


I updated the config file writing. 2 files are written now. My local 
tests are all OK.


Please elaborate. I just updated FPC and Pas2Js, nothing changed in 
behavior. Where is the commit?


Sorry, forgot to push. fpmake.pp in pas2js repo.

Michael.
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel