Re: [fpc-devel] MySQL 5.5 and Connector System
If sb wants in in 2.4.4, I urge you to be quick :-) Does it mean, that you are preparing release 2.4.4 in short time ? If yes, then I would happy, if also bug http://bugs.freepascal.org/view.php?id=16493 with attached patch will be commited. Thanks Laco. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] MySQL 5.5 and Connector System
On Tue, 18 Jan 2011, LacaK wrote: If sb wants in in 2.4.4, I urge you to be quick :-) Does it mean, that you are preparing release 2.4.4 in short time ? If yes, then I would happy, if also bug http://bugs.freepascal.org/view.php?id=16493 with attached patch will be commited. I checked the patch and committed the patch in trunk. Please test and report, then we can merge the patch to fixes. Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] MySQL 5.5 and Connector System
On Tue, 18 Jan 2011, LacaK wrote:
I checked the patch and committed the patch in trunk. Please test and
report, then we can merge the patch to fixes.
The patch is ok, as tested and reported also here
http://bugs.freepascal.org/view.php?id=18114
(and I also use this patch in my applications)
Please can you also apply this minor code cleanup:
101 uses
102 - dbconst, sysutils, typinfo, dateutils;
102 + dbconst, sysutils, dateutils;
193 - databaseerror('Parameter type
'+getenumname(typeinfo(tfieldtype),ord(P.datatype))+' not supported.');
193 + databaseerrorfmt(SUnsupportedParameter, [Fieldtypenames[P.DataType],
Self]);
Done. Revision 16776.
Michael.
___
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] MySQL 5.5 and Connector System
Done. Revision 16776. Thak you very much. Could I ask how/when are bugs/patch reviewed/commited ? Is there any single person(s) who maintains for example fcl-db or any fpc-developer can apply patches ? Is there any special time when patches are applied or in trunk can be patch applied any time (so if it is applied depends only on free time of developer(s)?) ? I am asking because some (simple) patches are waiting relative long time. For example: http://bugs.freepascal.org/view.php?id=15314 http://bugs.freepascal.org/view.php?id=16924 (patch 1) This is not criticism ;-) Laco. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] MySQL 5.5 and Connector System
In our previous episode, LacaK said: If sb wants in in 2.4.4, I urge you to be quick :-) Does it mean, that you are preparing release 2.4.4 in short time ? More that the process begins. It is at least 3 months between branching and release, though the third of a series is usually quick. I'm hoping to branch in februari, do a release candidate a month later, and release in may. If yes, then I would happy, if also bug http://bugs.freepascal.org/view.php?id=16493 with attached patch will be commited. The remark was mainly made because there were some doubts about the stability etc of the trunk restructuring of dynamic loading of libraries in the database drivers. Later changes in mysql, sqlite can depend on these. I'm currently categorizing remaining commits to merge here: http://www.stack.nl/~marcov/mergelogs/ the problem commits are, amongst others: http://www.stack.nl/~marcov/mergelogs/dynlibs.txt ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] MySQL 5.5 and Connector System
I just installed MySQL 5.5 and realized that the connector is bound to
5.1. I can see why looking at the code - why this is like that :-)
I had a problem with the usage of $ifdefs all over the place in the code.
It would be worth it since there are so many flavors of MySQL to
re-structure the MySQL component suite to employ the usage of
{$if defined(MySQL50) or defined(MYSQL51) or defined(MySQL55) or
defined(FutureVersions)}
CODE HERE
{$eslif defined(MYSQL41)}
OTHER CODE HERE.
{$endif}
IMO, presently the MySQL connection implement is getting too big to
just add another ifdef ad-hoc. I did set out yesterday to work on
this but I really don't have the time to figure out why the build
process on v50 connection didin't have $DEFINE mysql50 on a constant
from another unit. I edited the make files to include mysql55 etc.
So the questions are
1.) Is the dynamic unit system that MySQL connector uses compatible
with $if rather $ifdef ?
2.) What are the important things to change in /packages/mysql and
packages/fcl-db/*sql/ other than the obvious unit names for component
version?
I had to abandon this attempt due to lack of time for this particular
issue, but wanted to point out that I would be willing to implement
mysql connectors as they are released. My primary choice of DBMS is
MySQL. And I'm planning to stick with it.
___
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] MySQL 5.5 and Connector System
In our previous episode, Andrew Brunner said:
It would be worth it since there are so many flavors of MySQL to
re-structure the MySQL component suite to employ the usage of
{$if defined(MySQL50) or defined(MYSQL51) or defined(MySQL55) or
defined(FutureVersions)}
CODE HERE
{$eslif defined(MYSQL41)}
OTHER CODE HERE.
{$endif}
This is not logical, since it is not known if future versions will belong in
the same category as 5.0 or 5.1 before they emerge and are thoroughly
tested. This is _THE_ problem with mysql.
I had to abandon this attempt due to lack of time for this particular
issue, but wanted to point out that I would be willing to implement
mysql connectors as they are released. My primary choice of DBMS is
MySQL. And I'm planning to stick with it.
If sb wants in in 2.4.4, I urge you to be quick :-)
___
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel
