Re: [fpc-devel] Request for review of patch for issue 40261
On Mon, Oct 2, 2023 at 9:01 AM Michael Van Canneyt via fpc-devel wrote: > I did so, I left a small request. I attached a small test program to the bugreport (with a question). -- Bart ___ fpc-devel maillist - fpc-devel@lists.freepascal.org https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
Re: [fpc-devel] Request for review of patch for issue 40261
On Sat, 30 Sep 2023, Bart via fpc-devel wrote: Hi, Issue 40261 is about TStrings.AddObject issueing 2 consecutive OnChange events (and in the first one the to be added object is unassigned when accessing Objects[] property) when using InsertObject, AddObject and AddPair. This is Delphi incompatible. The patch attached to https://gitlab.com/freepascal.org/fpc/source/-/issues/40261#note_1406426712 fixes this at the expense of calling BeginUpdate/EndUpdate (and for that use a try..finally construct). I kindly ask for this patch to be reviewed by one of the devels. I did so, I left a small request. Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
[fpc-devel] Request for review of patch for issue 40261
Hi, Issue 40261 is about TStrings.AddObject issueing 2 consecutive OnChange events (and in the first one the to be added object is unassigned when accessing Objects[] property) when using InsertObject, AddObject and AddPair. This is Delphi incompatible. The patch attached to https://gitlab.com/freepascal.org/fpc/source/-/issues/40261#note_1406426712 fixes this at the expense of calling BeginUpdate/EndUpdate (and for that use a try..finally construct). I kindly ask for this patch to be reviewed by one of the devels. -- Bart ___ fpc-devel maillist - fpc-devel@lists.freepascal.org https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
