Re: [fpc-devel] patch for heaptrc

2007-04-16 Thread Pierre Muller 
> Pierre Muller schreef:
>>> Attached patch add the same sanity check for the frame pointer in
>>> TraceReAllocMem as
>>> already is in TraceGetMem. It fixed crashes of Lazarus on win64 when
>>> compiled with
>>> heaptrc.
>>>
>>> Tested with fpc 2.1.3. fpc 2.3.1 is currently broken on win64, see mail
>>> of
>>> 8 April.
>> I applied that to trunk,
>> is it needed fro fixes_2_2 branch also?
>
> Yes, please.
Merged in fixes_2_2 rev 7115.

Pierre


___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel

Re: [fpc-devel] patch for heaptrc

2007-04-11 Thread Vincent Snijders 

Pierre Muller schreef:

Attached patch add the same sanity check for the frame pointer in
TraceReAllocMem as
already is in TraceGetMem. It fixed crashes of Lazarus on win64 when
compiled with
heaptrc.

Tested with fpc 2.1.3. fpc 2.3.1 is currently broken on win64, see mail of
8 April.

I applied that to trunk,
is it needed fro fixes_2_2 branch also?


Yes, please.

Vincent
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel

Re: [fpc-devel] patch for heaptrc

2007-04-11 Thread Pierre Muller 
> Attached patch add the same sanity check for the frame pointer in
> TraceReAllocMem as
> already is in TraceGetMem. It fixed crashes of Lazarus on win64 when
> compiled with
> heaptrc.
>
> Tested with fpc 2.1.3. fpc 2.3.1 is currently broken on win64, see mail of
> 8 April.
I applied that to trunk,
is it needed fro fixes_2_2 branch also?

Pierre
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel

[fpc-devel] patch for heaptrc

2007-04-10 Thread Vincent Snijders 
Attached patch add the same sanity check for the frame pointer in TraceReAllocMem as 
already is in TraceGetMem. It fixed crashes of Lazarus on win64 when compiled with 
heaptrc.


Tested with fpc 2.1.3. fpc 2.3.1 is currently broken on win64, see mail of 8 
April.

Vincent
Index: heaptrc.pp
===
--- heaptrc.pp	(revision 7084)
+++ heaptrc.pp	(working copy)
@@ -628,6 +628,7 @@
   allocsize,
   movesize,
   i  : ptrint;
+  oldbp,
   bp : pointer;
   pl : pdword;
   pp : pheap_mem_info;
@@ -745,7 +746,10 @@
   for i:=1 to tracesize do
begin
  pp^.calls[i]:=get_caller_addr(bp);
+ oldbp:=bp;
  bp:=get_caller_frame(bp);
+ if (bp(StackBottom + StackLength)) then
+   bp:=nil;
end;
   { regenerate signature }
   if usecrc then
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel