Re: [fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2017-01-01 Thread Graeme Geldenhuys
On 2016-12-31 20:53, Bart wrote:
> I thought it was part of fpc packaes source

Correct, it is now included with FPC. The problem being, I found 3
different copies in the various FPC packages. I've asked Michael van
Canneyt if we can consolidate the various fasthtmlparser units into one
location, and let the various FPC packages use that one copy instead. He
agreed, but I haven't submitted a patch for that yet. It's on my todo list.

Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2016-12-31 Thread Lars
On Thu, December 29, 2016 12:09 pm, Bart wrote:
> On 12/29/16, Bart  wrote:
>
>
>> Is this intended behaviour?
>> If so, could it be made configurable to do fire the OnFoundText event
>> in such cases?
>
> Never mind, I did not think this through.
> I solved my problem in a better way (it should never have depended on
> the OnFoundText event in the first place).
>
> Sorry for wasting your time.
>
>

This brings some kind of Deja Vu as I may have had a similar issue once
upon a time... but cannot remember ;-)
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2016-12-31 Thread Bart
On 12/31/16, Lars  wrote:

> I have plans to put fast html parser on an official git hub so that any
> issues can be reported centrally

I thought it was part of fpc packaes source
(http://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/packages/chm/src/fasthtmlparser.pas?view=markup)
and bugs can be reported in fpc bugtracker?

Bart
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2016-12-31 Thread Lars
On Fri, December 30, 2016 1:22 pm, Graeme Geldenhuys wrote:
> On 2016-12-29 18:43, Bart wrote:
>
>> Is this intended behaviour?
>>
>
> I'm not sure. I used FastHTMLParser 2+ months ago and discovered a
> couple of bugs in it, and similar behaviour to what you mentioned. I wrote
> some unit tests for it and fixed the bugs I found. I'll make a not to
> publish my changes and test suite.
>

I have plans to put fast html parser on an official git hub so that any
issues can be reported centrally

Thanks for finding bugs (assuming they are not just technicalities as Bart
was saying)
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2016-12-30 Thread Graeme Geldenhuys
On 2016-12-29 18:43, Bart wrote:
> Is this intended behaviour?

I'm not sure. I used FastHTMLParser 2+ months ago and discovered a
couple of bugs in it, and similar behaviour to what you mentioned. I
wrote some unit tests for it and fixed the bugs I found. I'll make a not
to publish my changes and test suite.

Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2016-12-29 Thread Bart
On 12/29/16, Bart  wrote:

> Is this intended behaviour?
> If so, could it be made configurable to do fire the OnFoundText event
> in such cases?

Never mind, I did not think this through.
I solved my problem in a better way (it should never have depended on
the OnFoundText event in the first place).

Sorry for wasting your time.

Bart
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


[fpc-pascal] FastHtmlParser does not fire OnFoundText on e.g. empty table cell

2016-12-29 Thread Bart
Hi,

If you parse HTML using FastHtmlParser in order to extract a HTML
table content, then, if a table contains an empty cell (),
the OnFoundText event is not fired.
While technically this may be correct, I would have expected it to
fire OnFoundText('').

In my program I use the OnFoundText to populate a 2-dimesional
table-like structure, and this fails due to this behaviour of
FastHtmlParser.

Is this intended behaviour?
If so, could it be made configurable to do fire the OnFoundText event
in such cases?

Bart
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal